gh-108590: Fix sqlite3.iterdump for invalid unicode in text columns. #108657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
CorvinM
commented
Aug 29, 2023
Misc/NEWS.d/next/Library/2023-08-29-22-53-48.gh-issue-108590.6k0pOl.rst
Outdated
Show resolved
Hide resolved
…k0pOl.rst Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
erlend-aasland
approved these changes
Aug 30, 2023
erlend-aasland
added
needs backport to 3.11
2 tasks
|
Thank you for the speedy reviews and helpful feedback 😄 Let me know if you want me to pick up anything else with this (e.g., backports) |
This comment was marked as outdated.
This comment was marked as outdated.
|
Sorry, @CorvinM and @erlend-aasland, I could not cleanly backport this to |
|
Sorry, @CorvinM and @erlend-aasland, I could not cleanly backport this to |
|
@CorvinM, can you handle the backports? You can use the cherry-picker. See the devguide. |
Sure |
CorvinM
added a commit
to CorvinM/cpython
that referenced
this pull request
Aug 30, 2023
…EXT columns (pythonGH-108657) Co-authored-by: Erlend E. Aasland <erlend@python.org>. (cherry picked from commit 400a1ce) Co-authored-by: Corvin <corvin@corvin.dev>
|
GH-108673 is a backport of this pull request to the 3.12 branch. |
CorvinM
added a commit
to CorvinM/cpython
that referenced
this pull request
Aug 30, 2023
…EXT columns (pythonGH-108657) Co-authored-by: Erlend E. Aasland <erlend@python.org>. (cherry picked from commit 400a1ce) Co-authored-by: Corvin <corvin@corvin.dev>
|
GH-108674 is a backport of this pull request to the 3.11 branch. |
erlend-aasland
pushed a commit
that referenced
this pull request
Aug 30, 2023
erlend-aasland
added a commit
to erlend-aasland/cpython
that referenced
this pull request
Aug 30, 2023
Reverted per Serhiy's request.
carljm
added a commit
to carljm/cpython
that referenced
this pull request
Aug 30, 2023
* main: pythongh-108520: Fix bad fork detection in nested multiprocessing use case (python#108568) pythongh-108590: Revert pythongh-108657 (commit 400a1ce) (python#108686) pythongh-108494: Argument Clinic: Document how to generate code that uses the limited C API (python#108584) Document Python build requirements (python#108646) pythongh-101100: Fix Sphinx warnings in the Logging Cookbook (python#108678) Fix typo in multiprocessing docs (python#108666) pythongh-108669: unittest: Fix documentation for TestResult.collectedDurations (python#108670) pythongh-108590: Fix sqlite3.iterdump for invalid Unicode in TEXT columns (python#108657) Revert "pythongh-103224: Use the realpath of the Python executable in `test_venv` (pythonGH-103243)" (pythonGH-108667) pythongh-106320: Remove private _Py_ForgetReference() (python#108664) Mention Ellipsis pickling in the docs (python#103660) Revert "Use non alternate name for Kyiv (pythonGH-108533)" (pythonGH-108649) pythongh-108278: Deprecate passing the first param of sqlite3.Connection callback APIs by keyword (python#108632) pythongh-108455: peg_generator: install two stubs packages before running mypy (python#108637) pythongh-107801: Improve the accuracy of io.IOBase.seek docs (python#108268)
erlend-aasland
added a commit
to erlend-aasland/cpython
that referenced
this pull request
Aug 30, 2023
…on#108686) (cherry picked from commit 2a3926f) Reverted per Serhiy's request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an exception where sqlite3.iterdump would fail to decode if someone stuffed invalid unicode into a database column marked as TEXT (or alias of, like VARCHAR).
See #108590 for more info