Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add poker87c and poker87d #12810

Merged
merged 13 commits into from
Jul 7, 2021
Merged

Add poker87c and poker87d #12810

merged 13 commits into from
Jul 7, 2021

Conversation

mfkiiyd
Copy link
Contributor

@mfkiiyd mfkiiyd commented May 5, 2021 •
edited
Loading

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels May 5, 2021
@drashna
Copy link
Member

drashna commented May 13, 2021

These look like they're were pulled straight from kbfirmware. which is okay, but it's 4+ years out of date, and a lot has changed.

If you have the json's from kbfirmware, then please run them through this: https://noroadsleft.github.io/kbf_qmk_converter/

And then re-upload the newer files, as they should be pretty in line with current standards and config.

@mfkiiyd
Copy link
Contributor Author

mfkiiyd commented Jun 27, 2021

File has been updated, please pull merge, thank you

drashna
drashna requested changes Jul 3, 2021
View reviewed changes
keyboards/poker87c/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/poker87c/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/poker87c/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/poker87c/config.h Outdated Show resolved Hide resolved
keyboards/poker87d/config.h Show resolved Hide resolved
keyboards/poker87d/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/poker87d/keymaps/via/keymap.c Outdated Show resolved Hide resolved
mfkiiyd and others added 6 commits July 4, 2021 23:11
@mfkiiyd @drashna
Apply suggestions from code review
ff95fda 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@mfkiiyd @drashna
Update keyboards/poker87d/keymaps/via/keymap.c
d2a8e28 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@mfkiiyd @drashna
Update keyboards/poker87c/keymaps/default/keymap.c
f055020 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@mfkiiyd @drashna
Update keyboards/poker87c/keymaps/via/keymap.c
5e35509 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@mfkiiyd @drashna
Update keyboards/poker87d/keymaps/default/keymap.c
9b8992b 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@mfkiiyd @drashna
Update keyboards/poker87d/config.h
5c9992d 
Co-authored-by: Drashna Jaelre <drashna@live.com>
mfkiiyd
mfkiiyd commented Jul 4, 2021
View reviewed changes
Copy link
Contributor Author

@mfkiiyd mfkiiyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@drashna drashna requested a review from a team July 4, 2021 16:11
fauxpark
fauxpark requested changes Jul 5, 2021
View reviewed changes
keyboards/poker87c/config.h Outdated Show resolved Hide resolved
keyboards/poker87d/config.h Outdated Show resolved Hide resolved
mfkiiyd and others added 2 commits July 5, 2021 22:22
@mfkiiyd @fauxpark
Update keyboards/poker87d/config.h
a992eb0 
Co-authored-by: Ryan <fauxpark@gmail.com>
@mfkiiyd
Update config.h
e414a46
@mfkiiyd mfkiiyd requested a review from fauxpark July 5, 2021 14:27
@fauxpark fauxpark requested a review from a team July 5, 2021 14:31
@drashna
Copy link
Member

drashna commented Jul 7, 2021

Thanks!

@drashna drashna merged commit b976fcb into qmk:master Jul 7, 2021
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Jul 7, 2021
Merge remote-tracking branch 'qmk/develop' into develop
dd5a778 
* qmk/develop: (23 commits)
  Use the new ST7565 driver on Ergodox Infinity (qmk#13165)
  Xelus Ninjin: rename LAYOUT_all to LAYOUT_tkl_ansi_tsangan; add info.json (qmk#13477)
  Kopibeng XT65: Layout Macro Refactor (qmk#13476)
  [Keyboard] Add poker87c and poker87d (qmk#12810)
  [Keyboard] Add new Elise, 65% Keyboard ANSI / ISO  (qmk#12782)
  [Keyboard] Add bm65iso (qmk#13400)
  [Keyboard] Add keyboard reviung5 (qmk#13375)
  [Keyboard] Add kabedon98e (qmk#13314)
  [Keyboard] Set reasonable defaults for Corne keyboard (qmk#13440)
  /bin/bash to /usr/bin/env bash (qmk#13422)
  Update `MSG_PYTHON_MISSING` (qmk#13427)
  core: chibios: bootloader: use integer pointers as volatile (qmk#13450)
  Migrate SHIFT_ESC and RGB `fn_actions` to Grave Escape and RGB keycodes (qmk#13360)
  `keymap_extras`: Remove deprecated defines (qmk#12949)
  [Keyboard] fix encoder_update_user for nullbitsco/nibble (qmk#13451)
  Traveller cleanup (qmk#13441)
  LatinPadBLE: correct info.json data (qmk#13452)
  Jabberwocky: adjust key positioning in Configurator (qmk#13447)
  Molecule: Layout Macro Refactor (qmk#13453)
  [Docs] added list of MIDI keycodes (qmk#13159)
  ...
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
@mfkiiyd @drashna
@fauxpark @waterlv @HokieGeek
[Keyboard] Add poker87c and poker87d (qmk#12810)
e1e44ca 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Water <mfkiiyd@163.com>
@mfkiiyd mfkiiyd mentioned this pull request Jul 16, 2021
Merged
6 tasks
wox pushed a commit to wox/qmk_firmware that referenced this pull request Aug 14, 2021
@mfkiiyd @drashna
@fauxpark @waterlv @wox
[Keyboard] Add poker87c and poker87d (qmk#12810)
acfaf7a 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Water <mfkiiyd@163.com>
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@mfkiiyd @drashna
@fauxpark @waterlv @nhongooi
[Keyboard] Add poker87c and poker87d (qmk#12810)
ef7c1d3 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Water <mfkiiyd@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mfkiiyd @drashna @fauxpark @waterlv