-
-
Notifications
You must be signed in to change notification settings - Fork 39.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LatinPadBLE: correct info.json data #13452
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes an extra key object, and corrects the layout macro reference.
fauxpark
approved these changes
Jul 5, 2021
- remove invalid `LAYOUTS` rule - edits the rules.mk file to more closely resemble the file from QMK's AVR template.
fauxpark
requested changes
Jul 5, 2021
Apply suggestions from code review Co-authored-by: Ryan <fauxpark@gmail.com>
fauxpark
approved these changes
Jul 5, 2021
cadusk
pushed a commit
to cadusk/qmk_firmware
that referenced
this pull request
Jul 7, 2021
* qmk/develop: (23 commits) Use the new ST7565 driver on Ergodox Infinity (qmk#13165) Xelus Ninjin: rename LAYOUT_all to LAYOUT_tkl_ansi_tsangan; add info.json (qmk#13477) Kopibeng XT65: Layout Macro Refactor (qmk#13476) [Keyboard] Add poker87c and poker87d (qmk#12810) [Keyboard] Add new Elise, 65% Keyboard ANSI / ISO (qmk#12782) [Keyboard] Add bm65iso (qmk#13400) [Keyboard] Add keyboard reviung5 (qmk#13375) [Keyboard] Add kabedon98e (qmk#13314) [Keyboard] Set reasonable defaults for Corne keyboard (qmk#13440) /bin/bash to /usr/bin/env bash (qmk#13422) Update `MSG_PYTHON_MISSING` (qmk#13427) core: chibios: bootloader: use integer pointers as volatile (qmk#13450) Migrate SHIFT_ESC and RGB `fn_actions` to Grave Escape and RGB keycodes (qmk#13360) `keymap_extras`: Remove deprecated defines (qmk#12949) [Keyboard] fix encoder_update_user for nullbitsco/nibble (qmk#13451) Traveller cleanup (qmk#13441) LatinPadBLE: correct info.json data (qmk#13452) Jabberwocky: adjust key positioning in Configurator (qmk#13447) Molecule: Layout Macro Refactor (qmk#13453) [Docs] added list of MIDI keycodes (qmk#13159) ...
jakeprime
pushed a commit
to jakeprime/qmk_firmware
that referenced
this pull request
Jul 10, 2021
* correct info.json data Removes an extra key object, and corrects the layout macro reference. * refactor rules.mk file - remove invalid `LAYOUTS` rule - edits the rules.mk file to more closely resemble the file from QMK's AVR template. * additional rules.mk cleanup per fauxpark Apply suggestions from code review
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Jul 11, 2021
* correct info.json data Removes an extra key object, and corrects the layout macro reference. * refactor rules.mk file - remove invalid `LAYOUTS` rule - edits the rules.mk file to more closely resemble the file from QMK's AVR template. * additional rules.mk cleanup per fauxpark Apply suggestions from code review
wox
pushed a commit
to wox/qmk_firmware
that referenced
this pull request
Aug 14, 2021
* correct info.json data Removes an extra key object, and corrects the layout macro reference. * refactor rules.mk file - remove invalid `LAYOUTS` rule - edits the rules.mk file to more closely resemble the file from QMK's AVR template. * additional rules.mk cleanup per fauxpark Apply suggestions from code review
nhongooi
pushed a commit
to nhongooi/qmk_firmware
that referenced
this pull request
Dec 5, 2021
* correct info.json data Removes an extra key object, and corrects the layout macro reference. * refactor rules.mk file - remove invalid `LAYOUTS` rule - edits the rules.mk file to more closely resemble the file from QMK's AVR template. * additional rules.mk cleanup per fauxpark Apply suggestions from code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes an extra key object, and corrects the layout macro reference.
cc @haierwangwei2005 (keyboard maintainer)
Types of Changes
Checklist