[Keyboard] Set reasonable defaults for Corne keyboard #13440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fauxpark
requested changes
Jul 4, 2021
fauxpark
requested changes
Jul 4, 2021
Co-authored-by: Ryan <fauxpark@gmail.com>
fauxpark
approved these changes
Jul 4, 2021
noroadsleft
requested changes
Jul 4, 2021
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
zvecr
approved these changes
Jul 6, 2021
noroadsleft
approved these changes
Jul 6, 2021
cadusk
pushed a commit
to cadusk/qmk_firmware
that referenced
this pull request
Jul 7, 2021
* qmk/develop: (23 commits) Use the new ST7565 driver on Ergodox Infinity (qmk#13165) Xelus Ninjin: rename LAYOUT_all to LAYOUT_tkl_ansi_tsangan; add info.json (qmk#13477) Kopibeng XT65: Layout Macro Refactor (qmk#13476) [Keyboard] Add poker87c and poker87d (qmk#12810) [Keyboard] Add new Elise, 65% Keyboard ANSI / ISO (qmk#12782) [Keyboard] Add bm65iso (qmk#13400) [Keyboard] Add keyboard reviung5 (qmk#13375) [Keyboard] Add kabedon98e (qmk#13314) [Keyboard] Set reasonable defaults for Corne keyboard (qmk#13440) /bin/bash to /usr/bin/env bash (qmk#13422) Update `MSG_PYTHON_MISSING` (qmk#13427) core: chibios: bootloader: use integer pointers as volatile (qmk#13450) Migrate SHIFT_ESC and RGB `fn_actions` to Grave Escape and RGB keycodes (qmk#13360) `keymap_extras`: Remove deprecated defines (qmk#12949) [Keyboard] fix encoder_update_user for nullbitsco/nibble (qmk#13451) Traveller cleanup (qmk#13441) LatinPadBLE: correct info.json data (qmk#13452) Jabberwocky: adjust key positioning in Configurator (qmk#13447) Molecule: Layout Macro Refactor (qmk#13453) [Docs] added list of MIDI keycodes (qmk#13159) ...
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Jul 11, 2021
* [Keyboard] Set reasonable defaults for Corne keyboard * Add note about bootmagic * Make bootmagic config super weak * cleanup * Apply suggestions from code review * Update keyboards/crkbd/readme.md
wox
pushed a commit
to wox/qmk_firmware
that referenced
this pull request
Aug 14, 2021
* [Keyboard] Set reasonable defaults for Corne keyboard * Add note about bootmagic * Make bootmagic config super weak * cleanup * Apply suggestions from code review * Update keyboards/crkbd/readme.md
nhongooi
pushed a commit
to nhongooi/qmk_firmware
that referenced
this pull request
Dec 5, 2021
* [Keyboard] Set reasonable defaults for Corne keyboard * Add note about bootmagic * Make bootmagic config super weak * cleanup * Apply suggestions from code review * Update keyboards/crkbd/readme.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables bootmagic lite and extra keys by default (because they should have been), as well as sets the keys for bootmagic lite.
Also, auto-cformat pass due to commit hooks.
Types of Changes
Issues Fixed or Closed by This PR
Checklist