Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard buff75 #24297

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

Add keyboard buff75 #24297

wants to merge 27 commits into from

Conversation

Vem-596
Copy link

@Vem-596 Vem-596 commented Aug 17, 2024

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • [x ] Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • [x ] My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • [x ] I have added tests to cover my changes.
  • [x ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keymap via Adds via keymap and/or updates keyboard for via support labels Aug 17, 2024
keyboards/herevoland/buff75/halconf.h Outdated Show resolved Hide resolved
keyboards/herevoland/buff75/info.json Outdated Show resolved Hide resolved
keyboards/herevoland/buff75/readme.md Outdated Show resolved Hide resolved
keyboards/herevoland/buff75/matrix_diagram.md Show resolved Hide resolved
keyboards/herevoland/buff75/rules.mk Outdated Show resolved Hide resolved
Copy link
Author

@Vem-596 Vem-596 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes have been made, please help me review them, thank you. @zvecr

@zvecr zvecr added the invalid label Aug 19, 2024
@zvecr zvecr removed the invalid label Aug 19, 2024
@drashna
Copy link
Member

drashna commented Aug 27, 2024

As of August 26, 2024, qmk/qmk_firmware is no longer accepting VIA-enabled keymaps as these have now transitioned to a repository under the VIA team's control.

As you've submitted a PR containing via or VIA-enabled keymap(s), this is your notice that they should be removed from this PR. You should now submit a secondary PR to the VIA QMK Userspace repository with your associated via or VIA-enabled keymaps instead.
Copy

@drashna drashna requested a review from a team August 30, 2024 01:34
@drashna drashna removed the via Adds via keymap and/or updates keyboard for via support label Aug 30, 2024
keyboards/herevoland/buff75/matrix_diagram.md Outdated Show resolved Hide resolved
keyboards/herevoland/buff75/readme.md Outdated Show resolved Hide resolved
keyboards/herevoland/buff75/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/herevoland/buff75/keyboard.json Show resolved Hide resolved
keyboards/herevoland/buff75/keyboard.json Outdated Show resolved Hide resolved
keyboards/herevoland/buff75/mcuconf.h Outdated Show resolved Hide resolved
keyboards/herevoland/buff75/mcuconf.h Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants