Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Hannah910 V2 PCB and VIA support #8024

Merged
merged 13 commits into from
Feb 1, 2020
Merged

add Hannah910 V2 PCB and VIA support #8024

merged 13 commits into from
Feb 1, 2020

Conversation

mechlovin
Copy link
Contributor

@mechlovin mechlovin commented Jan 27, 2020 •
edited
Loading

add rev.2 pcb and via support

Description

Added firmware for Rev.2 PCB, and VIA support for both Rev.1 & Rev.2

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition )
  • Keymap/layout (addition and update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@wilba
Copy link
Contributor

wilba commented Jan 28, 2020

I think this needs to be restructured to hanna910/v1 and hanna910/v2 with keymaps/default, keymaps/via etc. for each. There should be no need to have config.h in the keymaps since it's not overriding anything (i.e. it's common with the others).

@noroadsleft
Copy link
Member

I agree with @Wilba6582. mechlovin/hannah910 should be moved to mechlovin/hannah910/v1, and then the V2 code added separately in mechlovin/hannah910/v2.

@mechlovin
Copy link
Contributor Author

I think this needs to be restructured to hanna910/v1 and hanna910/v2 with keymaps/default, keymaps/via etc. for each. There should be no need to have config.h in the keymaps since it's not overriding anything (i.e. it's common with the others).

Oh thank you, i'm feel lazy cuz i'm in lunar newyear vacation, lol.
I've update my board follow qmk structure

@mechlovin
Copy link
Contributor Author

I agree with @Wilba6582. mechlovin/hannah910 should be moved to mechlovin/hannah910/v1, and then the V2 code added separately in mechlovin/hannah910/v2.

thank you!
Updated

@mechlovin mechlovin mentioned this pull request Jan 28, 2020
Merged
7 tasks
noroadsleft
noroadsleft requested changes Jan 28, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the below, your keymaps should not be ifdef'd as they currently are.

The original unmodified keymaps should be moved to keyboards/mechlovin/hannah910/rev1/keymaps/, and the new keymaps under keyboards/mechlovin/hannah910/rev2/keymaps/.

keyboards/mechlovin/hannah910/hannah910.h Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah910/rev2/rev2.h Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah910/rev2/rev2.h Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah910/rev2/rev2.h Outdated Show resolved Hide resolved
noroadsleft
noroadsleft requested changes Jan 30, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, your info.json for rev2 isn't going to be functional, but it'll actually be easier for me to fix it as I can reverse engineer it from the code you're submitting here.

keyboards/mechlovin/hannah910/rev1/keymaps/ansi/keymap.c Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah910/rev1/keymaps/ansi/keymap.c Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah910/rev1/keymaps/via/readme.md Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah910/rev2/keymaps/ansi/readme.md Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah910/rev2/keymaps/default/readme.md Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah910/rev2/readme.md Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah910/rev2/readme.md Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah910/rev2/readme.md Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah910/rev1/keymaps/via/keymap.c Show resolved Hide resolved
keyboards/mechlovin/hannah910/rev2/keymaps/via/keymap.c Show resolved Hide resolved
noroadsleft
noroadsleft reviewed Jan 30, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just these two things IMO. Almost to the finish line!

keyboards/mechlovin/hannah910/rev2/keymaps/ansi/readme.md Show resolved Hide resolved
keyboards/mechlovin/hannah910/rev2/keymaps/default/readme.md Outdated Show resolved Hide resolved
noroadsleft
noroadsleft requested changes Jan 30, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh, spoke a little bit too soon.

keyboards/mechlovin/hannah910/rev1/readme.md Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah910/rev1/readme.md Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah910/rev1/readme.md Outdated Show resolved Hide resolved
@noroadsleft noroadsleft requested a review from a team January 31, 2020 00:17
@mechlovin
Copy link
Contributor Author

Thanks, bro

fauxpark
fauxpark requested changes Jan 31, 2020
View reviewed changes
keyboards/mechlovin/hannah910/config.h Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah910/hannah910.h Show resolved Hide resolved
keyboards/mechlovin/hannah910/hannah910.h Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah910/readme.md Show resolved Hide resolved
keyboards/mechlovin/hannah910/rev2/readme.md Outdated Show resolved Hide resolved
@mechlovin mechlovin requested a review from fauxpark January 31, 2020 14:19
fauxpark
fauxpark requested changes Jan 31, 2020
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing

@mechlovin
Copy link
Contributor Author

thanks

@noroadsleft noroadsleft merged commit fdabf52 into qmk:master Feb 1, 2020
@noroadsleft
Copy link
Member

Thank you!

HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@mechlovin @HokieGeek
[Keyboard] add Hannah910 V2 PCB and VIA support (qmk#8024)
25f8e33 
* add Hannah910 V2 and VIA support

add rev.2 pcb and via support

* Update config.h

* update

* Create config.h

* Update

* update

* update

* Move keymap folder

* add more layer and edit readme.md

* readme.md update

* update

* update

* Update hannah910.h
c0psrul3 pushed a commit to c0psrul3/qmk_firmware that referenced this pull request Mar 23, 2020
@mechlovin @c0psrul3
[Keyboard] add Hannah910 V2 PCB and VIA support (qmk#8024)
3b6973a 
* add Hannah910 V2 and VIA support

add rev.2 pcb and via support

* Update config.h

* update

* Create config.h

* Update

* update

* update

* Move keymap folder

* add more layer and edit readme.md

* readme.md update

* update

* update

* Update hannah910.h
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@mechlovin @kujawakk
[Keyboard] add Hannah910 V2 PCB and VIA support (qmk#8024)
80ba8b8 
* add Hannah910 V2 and VIA support

add rev.2 pcb and via support

* Update config.h

* update

* Create config.h

* Update

* update

* update

* Move keymap folder

* add more layer and edit readme.md

* readme.md update

* update

* update

* Update hannah910.h
@mechlovin mechlovin mentioned this pull request Sep 3, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mechlovin @wilba @noroadsleft @fauxpark @drashna