Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Slot fix #386

Merged
merged 2 commits into from
May 9, 2022
Merged

Document Slot fix #386

merged 2 commits into from
May 9, 2022

Conversation

benoitgrelard
Copy link
Contributor

@benoitgrelard benoitgrelard requested a review from andy-hook as a code owner May 6, 2022 14:07
@vercel
Copy link

vercel bot commented May 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
radix-website ✅ Ready (Inspect) Visit Preview May 6, 2022 at 7:23PM (UTC)

@andy-hook
Copy link
Contributor

Should we bump the page version number for completeness?

@benoitgrelard
Copy link
Contributor Author

Arr, yes I always forget.

@benoitgrelard
Copy link
Contributor Author

Updated all based on latest info here: radix-ui/primitives@f2d50b0

Copy link
Contributor

@andy-hook andy-hook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh nice one, I was only thinking about the slot page at the time 😄

@benoitgrelard benoitgrelard merged commit 6635b93 into release May 9, 2022
@benoitgrelard benoitgrelard deleted the release-slot-fix branch May 9, 2022 08:44
benoitgrelard added a commit that referenced this pull request May 17, 2022
* Document Slot fix

* PR feedback
benoitgrelard added a commit that referenced this pull request May 19, 2022
* Document Slot fix

* PR feedback
andy-hook pushed a commit that referenced this pull request May 30, 2022
* Document Slot fix

* PR feedback
benoitgrelard added a commit that referenced this pull request Jun 7, 2022
* Document Slot fix

* PR feedback
andy-hook pushed a commit that referenced this pull request Jun 8, 2022
* Document Slot fix

* PR feedback
benoitgrelard added a commit that referenced this pull request Jun 13, 2022
* Document Slot fix

* PR feedback
benoitgrelard added a commit that referenced this pull request Jun 15, 2022
* Document Slot fix

* PR feedback
benoitgrelard added a commit that referenced this pull request Jul 8, 2022
* Document Slot fix

* PR feedback
andy-hook pushed a commit that referenced this pull request Jul 18, 2022
* Document Slot fix

* PR feedback
benoitgrelard added a commit that referenced this pull request Jul 20, 2022
* Setup base PR

* Initial documentation updates (#369)

Catching up with merged features/fixes

* Update release note for React 18 (#371)

* Update release note for React 18

* Update data/primitives/overview/releases.mdx

Co-authored-by: Benoît Grélard <benoit.grelard@gmail.com>

Co-authored-by: Benoît Grélard <benoit.grelard@gmail.com>

* Primitives 1344 documentation (#376)

* Add new version pages

* Remove references to `forwards` in new versions

* Document NavigationMenu close on click 1347 (#380)

* Document Select fix (#381)

* Update `NavigationMenu` docs (#385)

* Document Slot fix (#386)

* Document Slot fix

* PR feedback

* Document latest menu/select updates (#387)

* Document latest menu/select updates

* Update 0.1.2.mdx

* Update 0.1.2.mdx

* Update 0.1.2.mdx

* Add context menu note to release (#388)

* Fix release note (#389)

* Document ScrollArea animatable Thumb change (#390)

* Remove enter key as per #393

* Document DismissableLayer fixes (#394)

* Catchup on demo updates (#396)

* Catchup on demo updates

* Update data/primitives/components/select/0.1.2.mdx

Co-authored-by: Andy Hook <hello@andyhook.dev>

* PR feedback

Co-authored-by: Andy Hook <hello@andyhook.dev>

* Document tabs animation (#397)

* Update file version/s

* Update doc

* Document submenu api change, `allowPinchZoom` prop move (#395)

* Document submenu changes

* Document `allowPinchZoom` prop change

* Feedback

* Document latest select fix (#398)

* Document latest select fix

* Update data/primitives/overview/releases.mdx

Co-authored-by: Andy Hook <hello@andyhook.dev>

Co-authored-by: Andy Hook <hello@andyhook.dev>

* Document latest RadioGroup change (#399)

* Document latest DismissableLayer change

radix-ui/primitives#1423

* Sync files with recent changes (#412)

* Document new Portal parts (#413)

* Document new Portal parts

* Document changes

* Update demos

* Update DeveloperExperienceSection.tsx

* Document latest ContextMenu changes (#414)

* Document latest Select changes (#415)

* Document latest Select changes

radix-ui/primitives#1459

* Add missing prop

* Document latest Portal changes (#416)

radix-ui/primitives#1463

* Parity in release branch from #417 (#419)

#417

* Document `data-*` attributes (#407)

* Setup base PR

* Initial documentation updates (#369)

Catching up with merged features/fixes

* Document `data-*` attributes

* Document `data-*`

* Fix spaces and render

* Fix data

* Document `data-*` attributes

* Document `data-*` attributes

* Add missing data attributes

* Fix minor tweaks

* Fix minor tweaks

* Fix minor tweaks

Co-authored-by: Benoît Grélard <benoit.grelard@gmail.com>

* Parity with #421 (#422)

* Document toast animation improvements (#423)

* Update release note

* Label required, update package version

* Document CSS variables (#426)

* Document CSS variables

* Change `Tooltip` CSS variable description

* remove from slider

* Fix `Accordion` CSS variable

* Remove `ScrollArea` CSS variables

* Update `transform-origin` description

* Add `Toast` CSS variables better description

* Fix `PropsTable` width

* Fix minor tweaks

* Fix minor tweaks

* Apply copy suggestions

* Fix minor tweaks

* Fix minor tweaks

* Fix minor tweaks

* Update data/primitives/components/tooltip/0.1.8.mdx

Co-authored-by: Andy Hook <hello@andyhook.dev>

Co-authored-by: Benoît Grélard <benoit.grelard@gmail.com>
Co-authored-by: Andy Hook <hello@andyhook.dev>

* Document tooltip hover changes (#431)

* Parity with #430 (#432)

* Document `allowPinchZoom` changes (#433)

* Document `allowPinchZoom` changes

* Feedback

* Release docs adjustments

* Updating versions in log to v1 (for all hands purpose)

* Copy change

* Fix typo in `onSelect` desc and release note

* Document popper changes (#437)

* Update changelog

* Document prop changes

* Update demos with props

* Update live demos

* Add missing portals

* Update deps

* Revert "Update live demos"

This reverts commit 981d20a.

* Update deps

* Update codesandbox css

* Remove portal in marketing hero demos

* Document new boundary prop

* Missing changelog + add portal back on subs

* PR feedback

* PR feedback

* Update stats (#438)

* Update release to use 1.0.0 filenames (#439)

* Shift breaking to first in change log

* Move files to 1.0.0

* Upgrade DS version (#440)

* Release refinement (#441)

* Revert announce filename and deprecate

* Update data-highlighted description

* Release date consistency

* Revert "Update data-highlighted description"

This reverts commit 30b3ae1.

* Tweak realease note order

* Update release tags to major

* Upgrade DS and primitives (#442)

Co-authored-by: Andy Hook <hello@andyhook.dev>
Co-authored-by: Bu Kinoshita <bukinoshita@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants