Catchup on demo updates #396

benoitgrelard · 2022-05-20T10:20:18Z

The only real change was the data-highlighted which actually isn't even a breaking change yet, because :focus would still work too.

vercel · 2022-05-20T10:22:12Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
radix-website	✅ Ready (Inspect)	Visit Preview	May 20, 2022 at 11:41AM (UTC)

benoitgrelard · 2022-05-20T10:21:18Z

components/demos/Select.jsx

      <SelectTrigger aria-label="Food">
-        <SelectValue />
+        <SelectValue placeholder="Select a fruit…" />


I took the opportunity to add placeholder showcase to the demo

benoitgrelard · 2022-05-20T10:21:26Z

data/primitives/components/select/0.1.2.mdx

@@ -484,6 +484,29 @@ export default () => (
 );
 ```

+### With a placeholder


as well as an example for it

benoitgrelard · 2022-05-20T10:21:51Z

package.json

-    "@radix-ui/react-toolbar": "0.1.5",
-    "@radix-ui/react-tooltip": "0.1.7",
-    "@radix-ui/react-visually-hidden": "0.1.4",
+    "@radix-ui/react-accessible-icon": "next",


They all needed an update, so all flipped to next

benoitgrelard · 2022-05-20T10:22:11Z

package.json

-    "@radix-ui/react-label": "0.1.5",
-    "@radix-ui/react-navigation-menu": "^0.1.2",
-    "@radix-ui/react-popover": "0.1.6",
-    "@radix-ui/react-primitive": "0.1.4",


I removed this one react-primitive as it doesn't seem to be imported anywhere, I'm not sure why it was ever added.

I dug, and it looks like it was introduced here: 3354a56 because of extendPrimitive but then never removed when we ditched it.

andy-hook

Nice one

andy-hook · 2022-05-20T10:44:13Z

components/demos/Select.jsx

@@ -20,6 +20,11 @@ const StyledTrigger = styled(SelectPrimitive.SelectTrigger, {
  boxShadow: `0 2px 10px ${blackA.blackA7}`,
  '&:hover': { backgroundColor: mauve.mauve3 },
  '&:focus': { boxShadow: `0 0 0 2px black` },
+  '&[data-placeholder]': { color: violet.violet8 },


I'm finding the contrast here challenging:

should we align with the scale recommendation of 11 for low contrast text?

haha I know, the issue is 11 is what we have already, so how to differentiate the placeholder from a value then?

I see what you mean, would 11 for the placeholder and 12 for the active value be appropriate? or we can noodle with the weight.

I tried that but 12 is very dark and looks muddy and out of place as 11 is used everywhere on most components.

How about with 9 on the placeholder?

Looks good 👍

data/primitives/components/select/0.1.2.mdx

Co-authored-by: Andy Hook <hello@andyhook.dev>

…bsite into release-demo-updates

* Catchup on demo updates * Update data/primitives/components/select/0.1.2.mdx Co-authored-by: Andy Hook <hello@andyhook.dev> * PR feedback Co-authored-by: Andy Hook <hello@andyhook.dev>

* Setup base PR * Initial documentation updates (#369) Catching up with merged features/fixes * Update release note for React 18 (#371) * Update release note for React 18 * Update data/primitives/overview/releases.mdx Co-authored-by: Benoît Grélard <benoit.grelard@gmail.com> Co-authored-by: Benoît Grélard <benoit.grelard@gmail.com> * Primitives 1344 documentation (#376) * Add new version pages * Remove references to `forwards` in new versions * Document NavigationMenu close on click 1347 (#380) * Document Select fix (#381) * Update `NavigationMenu` docs (#385) * Document Slot fix (#386) * Document Slot fix * PR feedback * Document latest menu/select updates (#387) * Document latest menu/select updates * Update 0.1.2.mdx * Update 0.1.2.mdx * Update 0.1.2.mdx * Add context menu note to release (#388) * Fix release note (#389) * Document ScrollArea animatable Thumb change (#390) * Remove enter key as per #393 * Document DismissableLayer fixes (#394) * Catchup on demo updates (#396) * Catchup on demo updates * Update data/primitives/components/select/0.1.2.mdx Co-authored-by: Andy Hook <hello@andyhook.dev> * PR feedback Co-authored-by: Andy Hook <hello@andyhook.dev> * Document tabs animation (#397) * Update file version/s * Update doc * Document submenu api change, `allowPinchZoom` prop move (#395) * Document submenu changes * Document `allowPinchZoom` prop change * Feedback * Document latest select fix (#398) * Document latest select fix * Update data/primitives/overview/releases.mdx Co-authored-by: Andy Hook <hello@andyhook.dev> Co-authored-by: Andy Hook <hello@andyhook.dev> * Document latest RadioGroup change (#399) * Document latest DismissableLayer change radix-ui/primitives#1423 * Sync files with recent changes (#412) * Document new Portal parts (#413) * Document new Portal parts * Document changes * Update demos * Update DeveloperExperienceSection.tsx * Document latest ContextMenu changes (#414) * Document latest Select changes (#415) * Document latest Select changes radix-ui/primitives#1459 * Add missing prop * Document latest Portal changes (#416) radix-ui/primitives#1463 * Parity in release branch from #417 (#419) #417 * Document `data-*` attributes (#407) * Setup base PR * Initial documentation updates (#369) Catching up with merged features/fixes * Document `data-*` attributes * Document `data-*` * Fix spaces and render * Fix data * Document `data-*` attributes * Document `data-*` attributes * Add missing data attributes * Fix minor tweaks * Fix minor tweaks * Fix minor tweaks Co-authored-by: Benoît Grélard <benoit.grelard@gmail.com> * Parity with #421 (#422) * Document toast animation improvements (#423) * Update release note * Label required, update package version * Document CSS variables (#426) * Document CSS variables * Change `Tooltip` CSS variable description * remove from slider * Fix `Accordion` CSS variable * Remove `ScrollArea` CSS variables * Update `transform-origin` description * Add `Toast` CSS variables better description * Fix `PropsTable` width * Fix minor tweaks * Fix minor tweaks * Apply copy suggestions * Fix minor tweaks * Fix minor tweaks * Fix minor tweaks * Update data/primitives/components/tooltip/0.1.8.mdx Co-authored-by: Andy Hook <hello@andyhook.dev> Co-authored-by: Benoît Grélard <benoit.grelard@gmail.com> Co-authored-by: Andy Hook <hello@andyhook.dev> * Document tooltip hover changes (#431) * Parity with #430 (#432) * Document `allowPinchZoom` changes (#433) * Document `allowPinchZoom` changes * Feedback * Release docs adjustments * Updating versions in log to v1 (for all hands purpose) * Copy change * Fix typo in `onSelect` desc and release note * Document popper changes (#437) * Update changelog * Document prop changes * Update demos with props * Update live demos * Add missing portals * Update deps * Revert "Update live demos" This reverts commit 981d20a. * Update deps * Update codesandbox css * Remove portal in marketing hero demos * Document new boundary prop * Missing changelog + add portal back on subs * PR feedback * PR feedback * Update stats (#438) * Update release to use 1.0.0 filenames (#439) * Shift breaking to first in change log * Move files to 1.0.0 * Upgrade DS version (#440) * Release refinement (#441) * Revert announce filename and deprecate * Update data-highlighted description * Release date consistency * Revert "Update data-highlighted description" This reverts commit 30b3ae1. * Tweak realease note order * Update release tags to major * Upgrade DS and primitives (#442) Co-authored-by: Andy Hook <hello@andyhook.dev> Co-authored-by: Bu Kinoshita <bukinoshita@gmail.com>

Catchup on demo updates

37263ca

benoitgrelard requested a review from andy-hook as a code owner May 20, 2022 10:20

vercel bot deployed to Preview May 20, 2022 10:22 View deployment

benoitgrelard commented May 20, 2022

View reviewed changes

andy-hook approved these changes May 20, 2022

View reviewed changes

Update data/primitives/components/select/0.1.2.mdx

ca7851e

Co-authored-by: Andy Hook <hello@andyhook.dev>

vercel bot deployed to Preview May 20, 2022 11:03 View deployment

benoitgrelard added 2 commits May 20, 2022 12:40

PR feedback

e8e6894

Merge branch 'release-demo-updates' of https://github.com/radix-ui/we…

33fa64a

…bsite into release-demo-updates

vercel bot deployed to Preview May 20, 2022 11:41 View deployment

benoitgrelard merged commit 850e6c3 into release May 20, 2022

benoitgrelard deleted the release-demo-updates branch May 20, 2022 11:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Catchup on demo updates #396

Catchup on demo updates #396

benoitgrelard commented May 20, 2022 •

edited

Loading

vercel bot commented May 20, 2022 •

edited

Loading

benoitgrelard May 20, 2022

benoitgrelard May 20, 2022

benoitgrelard May 20, 2022

benoitgrelard May 20, 2022

benoitgrelard May 20, 2022

andy-hook left a comment

andy-hook May 20, 2022

benoitgrelard May 20, 2022

andy-hook May 20, 2022 •

edited

Loading

benoitgrelard May 20, 2022

benoitgrelard May 20, 2022

andy-hook May 20, 2022

Catchup on demo updates #396

Catchup on demo updates #396

Conversation

benoitgrelard commented May 20, 2022 • edited Loading

vercel bot commented May 20, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andy-hook left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andy-hook May 20, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

benoitgrelard commented May 20, 2022 •

edited

Loading

vercel bot commented May 20, 2022 •

edited

Loading

andy-hook May 20, 2022 •

edited

Loading