Document new Portal parts #413

benoitgrelard · 2022-06-08T17:12:36Z

radix-ui/primitives#1425
radix-ui/primitives#1426
radix-ui/primitives#1427
radix-ui/primitives#1429

vercel · 2022-06-08T17:12:39Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
radix-website	✅ Ready (Inspect)	Visit Preview	Jun 9, 2022 at 11:19AM (UTC)

andy-hook

Looks good, only notable comment is regarding consistency in the Dialog docs.

We should also remove the reference to portalled in the home page code slider:

website/components/marketing/DeveloperExperienceSection.tsx

Line 436 in 5083be0

portalled={false}

andy-hook · 2022-06-09T10:03:36Z

data/primitives/components/context-menu/0.1.7.mdx

+        <span>
+          Used to force mounting when more control is needed. Useful when
+          controlling animation with React animation libraries. If used on this
+          part, it will be inherited by <Code>ContextMenu.Content</Code> and{' '}
+          <Code>ContextMenu.SubContent</Code> respectively.
+        </span>


I like these expanded descriptions mentioning inheritance, perhaps we should align Dialog to include these as well?

I'm confused, it should already be the case no? That's where I got it from.

Whoops, I was looking at the live url 🙈

andy-hook · 2022-06-09T10:38:32Z

data/primitives/components/tooltip/0.1.8.mdx

+    {
+      name: 'forceMount',
+      type: 'boolean',
+      description: (
+        <span>
+          Used to force mounting when more control is needed. Useful when
+          controlling animation with React animation libraries. It inherits from{' '}
+          <Code>Tooltip.Portal</Code>.
+        </span>
+      ),
+    },


andy-hook · 2022-06-09T10:45:02Z

data/primitives/overview/releases.mdx

@@ -25,6 +25,7 @@ metaDescription: Radix Primitives releases and their changelogs.
 - Add `data-highlighted` attribute to support styling <PRLink id={1388} />
 - [**Breaking**] Improve indirect nesting of context menus. Submenus must now be created using explicit parts. <PRLink id={1394} />
 - [**Breaking**] Move `allowPinchZoom` to root. <PRLink id={1400} />
+- [**Breaking**] Add new `Portal` part. To avoid regressions, use this part if you want portalling behavior. Note that `z-index` isn't managed anymore so you have full control of layering. <PRLink id={1429} />


I don't think we've been super consistent about it in the past but just checking, is American english our preference?

I would say yes, given our global audience.

* Document new Portal parts * Document changes * Update demos * Update DeveloperExperienceSection.tsx

* Setup base PR * Initial documentation updates (#369) Catching up with merged features/fixes * Update release note for React 18 (#371) * Update release note for React 18 * Update data/primitives/overview/releases.mdx Co-authored-by: Benoît Grélard <benoit.grelard@gmail.com> Co-authored-by: Benoît Grélard <benoit.grelard@gmail.com> * Primitives 1344 documentation (#376) * Add new version pages * Remove references to `forwards` in new versions * Document NavigationMenu close on click 1347 (#380) * Document Select fix (#381) * Update `NavigationMenu` docs (#385) * Document Slot fix (#386) * Document Slot fix * PR feedback * Document latest menu/select updates (#387) * Document latest menu/select updates * Update 0.1.2.mdx * Update 0.1.2.mdx * Update 0.1.2.mdx * Add context menu note to release (#388) * Fix release note (#389) * Document ScrollArea animatable Thumb change (#390) * Remove enter key as per #393 * Document DismissableLayer fixes (#394) * Catchup on demo updates (#396) * Catchup on demo updates * Update data/primitives/components/select/0.1.2.mdx Co-authored-by: Andy Hook <hello@andyhook.dev> * PR feedback Co-authored-by: Andy Hook <hello@andyhook.dev> * Document tabs animation (#397) * Update file version/s * Update doc * Document submenu api change, `allowPinchZoom` prop move (#395) * Document submenu changes * Document `allowPinchZoom` prop change * Feedback * Document latest select fix (#398) * Document latest select fix * Update data/primitives/overview/releases.mdx Co-authored-by: Andy Hook <hello@andyhook.dev> Co-authored-by: Andy Hook <hello@andyhook.dev> * Document latest RadioGroup change (#399) * Document latest DismissableLayer change radix-ui/primitives#1423 * Sync files with recent changes (#412) * Document new Portal parts (#413) * Document new Portal parts * Document changes * Update demos * Update DeveloperExperienceSection.tsx * Document latest ContextMenu changes (#414) * Document latest Select changes (#415) * Document latest Select changes radix-ui/primitives#1459 * Add missing prop * Document latest Portal changes (#416) radix-ui/primitives#1463 * Parity in release branch from #417 (#419) #417 * Document `data-*` attributes (#407) * Setup base PR * Initial documentation updates (#369) Catching up with merged features/fixes * Document `data-*` attributes * Document `data-*` * Fix spaces and render * Fix data * Document `data-*` attributes * Document `data-*` attributes * Add missing data attributes * Fix minor tweaks * Fix minor tweaks * Fix minor tweaks Co-authored-by: Benoît Grélard <benoit.grelard@gmail.com> * Parity with #421 (#422) * Document toast animation improvements (#423) * Update release note * Label required, update package version * Document CSS variables (#426) * Document CSS variables * Change `Tooltip` CSS variable description * remove from slider * Fix `Accordion` CSS variable * Remove `ScrollArea` CSS variables * Update `transform-origin` description * Add `Toast` CSS variables better description * Fix `PropsTable` width * Fix minor tweaks * Fix minor tweaks * Apply copy suggestions * Fix minor tweaks * Fix minor tweaks * Fix minor tweaks * Update data/primitives/components/tooltip/0.1.8.mdx Co-authored-by: Andy Hook <hello@andyhook.dev> Co-authored-by: Benoît Grélard <benoit.grelard@gmail.com> Co-authored-by: Andy Hook <hello@andyhook.dev> * Document tooltip hover changes (#431) * Parity with #430 (#432) * Document `allowPinchZoom` changes (#433) * Document `allowPinchZoom` changes * Feedback * Release docs adjustments * Updating versions in log to v1 (for all hands purpose) * Copy change * Fix typo in `onSelect` desc and release note * Document popper changes (#437) * Update changelog * Document prop changes * Update demos with props * Update live demos * Add missing portals * Update deps * Revert "Update live demos" This reverts commit 981d20a. * Update deps * Update codesandbox css * Remove portal in marketing hero demos * Document new boundary prop * Missing changelog + add portal back on subs * PR feedback * PR feedback * Update stats (#438) * Update release to use 1.0.0 filenames (#439) * Shift breaking to first in change log * Move files to 1.0.0 * Upgrade DS version (#440) * Release refinement (#441) * Revert announce filename and deprecate * Update data-highlighted description * Release date consistency * Revert "Update data-highlighted description" This reverts commit 30b3ae1. * Tweak realease note order * Update release tags to major * Upgrade DS and primitives (#442) Co-authored-by: Andy Hook <hello@andyhook.dev> Co-authored-by: Bu Kinoshita <bukinoshita@gmail.com>

Document new Portal parts

8795fd3

vercel bot deployed to Preview June 8, 2022 17:14 View deployment

Document changes

35cfd6a

vercel bot deployed to Preview June 8, 2022 17:39 View deployment

Update demos

3611ecd

benoitgrelard marked this pull request as ready for review June 8, 2022 18:01

benoitgrelard requested a review from andy-hook as a code owner June 8, 2022 18:01

vercel bot deployed to Preview June 8, 2022 18:02 View deployment

andy-hook reviewed Jun 9, 2022

View reviewed changes

Update DeveloperExperienceSection.tsx

586eb8a

vercel bot deployed to Preview June 9, 2022 11:19 View deployment

andy-hook approved these changes Jun 9, 2022

View reviewed changes

benoitgrelard merged commit c671e26 into release Jun 9, 2022

benoitgrelard deleted the release-portal-parts branch June 9, 2022 11:30

benoitgrelard added a commit that referenced this pull request Jun 13, 2022

Document new Portal parts (#413)

f359f33

* Document new Portal parts * Document changes * Update demos * Update DeveloperExperienceSection.tsx

benoitgrelard added a commit that referenced this pull request Jun 15, 2022

Document new Portal parts (#413)

56c08f0

* Document new Portal parts * Document changes * Update demos * Update DeveloperExperienceSection.tsx

benoitgrelard added a commit that referenced this pull request Jul 8, 2022

Document new Portal parts (#413)

4540018

* Document new Portal parts * Document changes * Update demos * Update DeveloperExperienceSection.tsx

andy-hook pushed a commit that referenced this pull request Jul 18, 2022

Document new Portal parts (#413)

32ef54f

* Document new Portal parts * Document changes * Update demos * Update DeveloperExperienceSection.tsx

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Document new Portal parts #413

Document new Portal parts #413

benoitgrelard commented Jun 8, 2022

vercel bot commented Jun 8, 2022 •

edited

Loading

andy-hook left a comment

andy-hook Jun 9, 2022

benoitgrelard Jun 9, 2022

andy-hook Jun 9, 2022

andy-hook Jun 9, 2022

andy-hook Jun 9, 2022

benoitgrelard Jun 9, 2022

Document new Portal parts #413

Document new Portal parts #413

Conversation

benoitgrelard commented Jun 8, 2022

vercel bot commented Jun 8, 2022 • edited Loading

andy-hook left a comment

Choose a reason for hiding this comment

andy-hook Jun 9, 2022

Choose a reason for hiding this comment

benoitgrelard Jun 9, 2022

Choose a reason for hiding this comment

andy-hook Jun 9, 2022

Choose a reason for hiding this comment

andy-hook Jun 9, 2022

Choose a reason for hiding this comment

andy-hook Jun 9, 2022

Choose a reason for hiding this comment

benoitgrelard Jun 9, 2022

Choose a reason for hiding this comment

vercel bot commented Jun 8, 2022 •

edited

Loading