Unpin grpcio for Ray Client #37368
Merged
Unpin grpcio for Ray Client #37368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardliaw
approved these changes
Jul 13, 2023
ericl
approved these changes
Jul 13, 2023
rkooo567
added a commit
to rkooo567/ray
that referenced
this pull request
Jul 14, 2023
This reverts commit 61401da.
richardliaw
pushed a commit
that referenced
this pull request
Jul 14, 2023
8 tasks
pcmoritz
pushed a commit
that referenced
this pull request
Jul 16, 2023
Redo #37368 and #37398 while avoiding grpc/grpc#33714 Closes #37432 --------- Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Bhav00
pushed a commit
to Bhav00/ray
that referenced
this pull request
Jul 28, 2023
It seems like the bug grpc/grpc#31885 that caused the problems with Ray Client tests has been fixed in grpcio 1.56, so we are removing the pin so people can upgrade to fix https://nvd.nist.gov/vuln/detail/CVE-2023-32731 Pinning to just the latest version would be too restrictive so we remove the pin (since the Ray client works with other versions as well except for some corner cases).
Bhav00
pushed a commit
to Bhav00/ray
that referenced
this pull request
Jul 28, 2023
Bhav00
pushed a commit
to Bhav00/ray
that referenced
this pull request
Jul 28, 2023
Redo ray-project#37368 and ray-project#37398 while avoiding grpc/grpc#33714 Closes ray-project#37432 --------- Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
NripeshN
pushed a commit
to NripeshN/ray
that referenced
this pull request
Aug 15, 2023
It seems like the bug grpc/grpc#31885 that caused the problems with Ray Client tests has been fixed in grpcio 1.56, so we are removing the pin so people can upgrade to fix https://nvd.nist.gov/vuln/detail/CVE-2023-32731 Pinning to just the latest version would be too restrictive so we remove the pin (since the Ray client works with other versions as well except for some corner cases). Signed-off-by: NripeshN <nn2012@hw.ac.uk>
NripeshN
pushed a commit
to NripeshN/ray
that referenced
this pull request
Aug 15, 2023
…#37427) Signed-off-by: NripeshN <nn2012@hw.ac.uk>
NripeshN
pushed a commit
to NripeshN/ray
that referenced
this pull request
Aug 15, 2023
Redo ray-project#37368 and ray-project#37398 while avoiding grpc/grpc#33714 Closes ray-project#37432 --------- Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com> Signed-off-by: NripeshN <nn2012@hw.ac.uk>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
It seems like the bug grpc/grpc#31885 that caused the problems with Ray Client tests has been fixed in grpcio 1.56, so we are removing the pin so people can upgrade to fix https://nvd.nist.gov/vuln/detail/CVE-2023-32731 Pinning to just the latest version would be too restrictive so we remove the pin (since the Ray client works with other versions as well except for some corner cases). Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…#37427) Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
Redo ray-project#37368 and ray-project#37398 while avoiding grpc/grpc#33714 Closes ray-project#37432 --------- Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
It seems like the bug grpc/grpc#31885 that caused the problems with Ray Client tests has been fixed in grpcio 1.56, so we are removing the pin so people can upgrade to fix https://nvd.nist.gov/vuln/detail/CVE-2023-32731 Pinning to just the latest version would be too restrictive so we remove the pin (since the Ray client works with other versions as well except for some corner cases). Signed-off-by: Victor <vctr.y.m@example.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
…#37427) Signed-off-by: Victor <vctr.y.m@example.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
Redo ray-project#37368 and ray-project#37398 while avoiding grpc/grpc#33714 Closes ray-project#37432 --------- Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com> Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
It seems like the bug grpc/grpc#31885 that caused the problems with Ray Client tests has been fixed in grpcio 1.56, so we are removing the pin so people can upgrade to fix https://nvd.nist.gov/vuln/detail/CVE-2023-32731
Pinning to just the latest version would be too restrictive so we remove the pin (since the Ray client works with other versions as well except for some corner cases).
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.