Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Unpin grpcio for Ray client #37449

Merged
merged 3 commits into from
Jul 16, 2023
Merged

Conversation

jjyao
Copy link
Collaborator

@jjyao jjyao commented Jul 15, 2023

Why are these changes needed?

Redo #37368 and #37398 while avoiding grpc/grpc#33714

Related issue number

Closes #37432

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
@cxieCoveo
Copy link

Do we have an eta for the release of this fix? It is blocking our release. Thanks!

@jjyao
Copy link
Collaborator Author

jjyao commented Jul 18, 2023

It will be late this week or early next week.

Bhav00 pushed a commit to Bhav00/ray that referenced this pull request Jul 28, 2023
Redo ray-project#37368 and ray-project#37398 while avoiding grpc/grpc#33714

Closes ray-project#37432

---------

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
NripeshN pushed a commit to NripeshN/ray that referenced this pull request Aug 15, 2023
Redo ray-project#37368 and ray-project#37398 while avoiding grpc/grpc#33714

Closes ray-project#37432

---------

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: NripeshN <nn2012@hw.ac.uk>
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
Redo ray-project#37368 and ray-project#37398 while avoiding grpc/grpc#33714

Closes ray-project#37432

---------

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
Redo ray-project#37368 and ray-project#37398 while avoiding grpc/grpc#33714

Closes ray-project#37432

---------

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core] Upgrade grpcio to the latest
4 participants