Skip to content

Commit

Permalink
[Core] Unpin grpcio for Ray client (ray-project#37449)
Browse files Browse the repository at this point in the history
Redo ray-project#37368 and ray-project#37398 while avoiding grpc/grpc#33714

Closes ray-project#37432

---------

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Victor <vctr.y.m@example.com>
  • Loading branch information
jjyao authored and Victor committed Oct 11, 2023
1 parent 918bfac commit 1f621ed
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
5 changes: 2 additions & 3 deletions python/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ requests

# Python version-specific requirements
dataclasses; python_version < '3.7'
grpcio >= 1.32.0; python_version < '3.10'
grpcio >= 1.42.0; python_version >= '3.10'
grpcio == 1.54.2; sys_platform == "darwin"
grpcio >= 1.54.2; sys_platform != "darwin"
numpy>=1.16; python_version < '3.9'
numpy>=1.19.3; python_version >= '3.9'
typing_extensions; python_version < '3.8'
Expand Down Expand Up @@ -54,7 +54,6 @@ requests
pandas
tensorboardX<=2.6.0,>=1.9 # >=2.6.1 uses protobuf>=4, and conflicts with other packages.
gymnasium==0.26.3
grpcio<=1.50.0,>=1.42.0 # ray client
aiohttp>=3.7
starlette
typer
Expand Down
6 changes: 4 additions & 2 deletions python/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -265,8 +265,10 @@ def get_packages(self):
],
"client": [
# The Ray client needs a specific range of gRPC to work:
# Tracking issue: https://github.com/grpc/grpc/issues/31885
"grpcio >= 1.42.0, <= 1.50.0",
# Tracking issues: https://github.com/grpc/grpc/issues/33714
"grpcio != 1.56.0"
if sys.platform == "darwin"
else "grpcio",
],
"serve": ["uvicorn", "requests", "starlette", "fastapi", "aiorwlock"],
"tune": ["pandas", "tensorboardX>=1.9", "requests", pyarrow_dep],
Expand Down

0 comments on commit 1f621ed

Please sign in to comment.