Call Digital Growth Charts API asynchronously #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This weirdly fixed the issue where the save failed because of rounding errors. I have no idea why.
mbarton
commented
Dec 5, 2024
| @@ -61,15 +58,7 @@ class Meta: | |||
| "hospital_discharge_date", | |||
| "hospital_admission_reason", | |||
| "dka_additional_therapies", | |||
| "hospital_admission_other", | |||
| # calculated fields | |||
| "height_centile", | |||
There was a problem hiding this comment.
As these are calculated fields it should not be possible to submit them through the form
| pass | ||
| cleaned_data["weight"] = weight = round_to_one_decimal_place(weight) | ||
|
|
||
| if not getattr(self, "async_validation_results", None): |
There was a problem hiding this comment.
This is the same trick we already use for the patient form, allows us to run things asynchronously for the CSV upload but synchronously for the questionnaire form submission
| @@ -0,0 +1,46 @@ | |||
| from asgiref.sync import async_to_sync | |||
There was a problem hiding this comment.
I wrote this for performance profiling as you can put cProfile in front of it easily (https://stackoverflow.com/questions/582336/how-do-i-profile-a-python-script).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #399
Fixes #415
Follow on from #388 and #405, moving the calls to the Digital Growth Charts API to be made asynchronously during CSV upload.
Uploading a CSV of 100 patients with 16 visits each (1600 rows):
Also pass through warnings from the API as validation errors. This catches height and weight measurements that are so extreme they are wrong (see rcpch/rcpchgrowth-python#32 for the methodology)