Fix : Cannot complete checkout on second visit when using Anonymous user #3640

prinzdezibel · 2018-02-02T10:35:31Z

Changes:
Whenever the user choose to checkout as anonymous user, the address
book step should be skipped, if there's already a shipping AND billing
address specified for the cart.

Otherwise the address book grid would come up, but both options are
already selected (green check icon). Repeatedly clicking the active
item does not help, one would need to change the address to move beyond
the addressBook workflow step.

To test:

1A - Place an order for a single product as an anonymous user

Click on “Basic Reaction Product”
Click “Add to Cart”
Click on “Checkout Now”
Click on “Continue As Guest”
Fill out address
Click on “Save and Continue”
Select “Free Shipping”
(The Generic Payment method should be expanded by default) Enter any name
Enter 4242424242424242 for credit card number
Choose an expiration month
Choose an expiration year
Enter 345 as the CV2 code
Select “Complete your order”
Verify that you receive the confirmation screen (“Thank You!”)

1B - Place two consecutive orders as an anonymous user

Follow the instructions for “Place an order for a single product as an anonymous user”
Return to the home screen by clicking on “Reaction” up in the upper left corner
Click on “Basic Reaction Product”
Click “Add to Cart”
Click on “Checkout Now”
Select "Continue As Guest"

EXPECTED: The shipping workflow step should be active now.

EDIT 2: Please do also check the above another time with stripe payment selected.

Closes #3638 Changes: Whenever the user choosed to checkout as anonymous user, the address book step should be skipped, if there's already a shipping AND billing address specified for the cart. Otherwise the address book grid would come up, but both options are already selected (green check icon). Repeatedly clicking the active item does not help, one would need to change the address to move beyond the addressBook workflow step.

prinzdezibel · 2018-02-02T10:37:23Z

@jshimko Brent asked me to get my code changes reviewed from you.

mattt416 · 2018-02-02T12:28:12Z

Hi @prinzdezibel I've made this modification locally but am still running into the reported issue. I reset the database after making the change and tried two consecutive checkouts as an anon user but can't proceed on 2nd checkout. As I'm unsure if anything needs to be reset/flushed in the JavaScript console, I've tried with a new browser/email combination but still hit the same problem on the 2nd checkout.

prinzdezibel · 2018-02-05T09:21:39Z

@mattt416 Did you have a chance to look into this again? I can't reproduce the problem you're describing.

mattt416 · 2018-02-05T13:55:41Z

Hi @prinzdezibel , I just started a new app (reaction init), applied your fix, ran reaction run, and then went through the steps to replicate this. I'm still seeing the behaviour from before. Are there any client-side caches that I would need to flush here, even though I've started with a fresh app?

prinzdezibel · 2018-02-05T14:00:35Z

Hi @mattt416 , can we chat on Gitter? I'd like to go this through with you.

also result in a double-push of the workflow if shipping & billing is already set.

prinzdezibel · 2018-02-05T15:36:57Z

@mattt416 I also fixed it for the case that Stripe as payment option is enabled. Which was obviously the case in your scenario, even if it was not checked active in the settings (I can re-construct your behavior when changing the following values directly in db - which essentially is a data corruption):

I don't know if this is what resulted in the observations that you made, nor do I know if such a db state can happen in an erroneous situation. If so and you know why, I'd be glad to get more details on this.

But as far as the original problem goes: This should be fixed with my latest changes.

Thank you again, Michael.

mattt416 · 2018-02-05T16:52:15Z

Hi @prinzdezibel, I just did a db reset on my dummy install and this is what I see:

meteor:PRIMARY> db.Packages.find({name: 'reaction-stripe'}).pretty()
{
        "_id" : "LD9s6WgxZqu8otQbx",
        "name" : "reaction-stripe",
        "shopId" : "J8Bhq3uTtdgwZx3rz",
        "icon" : "fa fa-cc-stripe",
        "enabled" : true,
        "settings" : {
                "mode" : false,
                "api_key" : "",
                "reaction-stripe" : {
                        "enabled" : false,
                        "support" : [
                                "Authorize",
                                "Capture",
                                "Refund"
                        ]
                },
                "public" : {
                        "client_id" : ""
                },
                "connectAuth" : {

                }
        },
        "registry" : [
                {
                        "label" : "Stripe",
                        "provides" : [
                                "paymentSettings"
                        ],
                        "container" : "dashboard",
                        "template" : "stripeSettings",
                        "hideForShopTypes" : [
                                "merchant",
                                "affiliate"
                        ]
                },
                {
                        "template" : "stripePaymentForm",
                        "provides" : [
                                "paymentMethod",
                                "marketplacePaymentMethod"
                        ],
                        "icon" : "fa fa-cc-stripe"
                },
                {
                        "route" : "/stripe/connect/authorize",
                        "template" : "stripeConnectAuthorize"
                },
                {
                        "label" : "Stripe Merchant Account",
                        "icon" : "fa fa-cc-stripe",
                        "container" : "dashboard",
                        "provides" : [
                                "marketplaceMerchantSettings"
                        ],
                        "template" : "stripeConnectMerchantSignup",
                        "hideForShopTypes" : [
                                "primary"
                        ]
                }
        ],
        "layout" : null
}
meteor:PRIMARY>

Nothing has been toggled in the admin panel yet.

prinzdezibel · 2018-02-05T17:01:31Z

@mattt416 Thanks for hint! this looks like an error. I'm going to file a separate ticket for this.

mattt416 · 2018-02-05T17:10:25Z

@prinzdezibel Regarding the actual bug tho -- I've tested this with stripe implicitly enabled, with it explicitly enabled, and with it explicitly disabled, and the 2nd checkout now pops up the shipping selection as expected. So, tl;dr your fix seems to be working! 👍

prinzdezibel · 2018-02-05T17:11:02Z

@mattt416 Please check your reaction.json file in /private/settings/. I guess there's a wrong default there. If enabled = true you'd also need this:

"settings" : {
        "mode" : false,
        "api_key" : "XXXX",
        "reaction-stripe" : {
            "enabled" : true,
            // more stuff
        }
    },

mattt416 · 2018-02-05T17:12:34Z

@prinzdezibel Looks like the default is wrong? https://github.com/reactioncommerce/reaction/blob/master/private/settings/reaction.json.example#L77

prinzdezibel · 2018-02-05T17:14:29Z

@mattt416 that's it !! Thanks for your help. I'm going to file a new ticket for that.

mattt416 · 2018-02-05T17:16:39Z

@prinzdezibel Unless the cart code shouldn't be using isStripeEnabled, but rather something that checks if the enabled inside reaction-stripe's settings is true?

prinzdezibel · 2018-02-05T17:18:30Z

@mattt416 yup, not sure which one is the source of truth actually. Not sure why this field is redundant at all. Need to dig into it.

brent-hoover · 2018-02-06T00:50:03Z

@prinzdezibel Just to clarify. There should be two enabled values there. The top-level one might be better labeled "installed" but it controls whether the payment function would display in the dashboard, the second whether the payment method is actually used during checkout.

prinzdezibel · 2018-02-06T07:17:53Z

i ve been thinking this too, but realized, that toggling stripe on/off actually alters both booleans. which doesnt quite make sense. also the plugin appears still in dashboard, even if upper boolean is false Sent from mobile device. Please excuse brevity and typos.

…

On Feb 6, 2018 1:50 AM, "Brent Hoover" ***@***.***> wrote: @prinzdezibel <https://github.com/prinzdezibel> Just to clarify. There should be two enabled values there. The top-level one might be better labeled "installed" but it controls whether the payment function would display in the dashboard, the second whether the payment method is actually used during checkout. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3640 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABpybYveqX9IM8CadHtUgI7Rqv7Ogb3lks5tR6G_gaJpZM4R2_HP> .

brent-hoover · 2018-02-07T23:25:56Z

@prinzdezibel So what's the status of this PR?

prinzdezibel · 2018-02-08T06:54:11Z

ready for approval ;) Sent from mobile device. Please excuse brevity and typos. On Feb 8, 2018 12:26 AM, "Brent Hoover" <notifications@github.com> wrote: @prinzdezibel <https://github.com/prinzdezibel> So what's the status of this PR? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3640 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABpybblUxVq0TQqF3X93SMiD0WQMTQvoks5tSjEIgaJpZM4R2_HP> .

aaronjudd · 2018-02-16T18:37:56Z

@jshimko @prinzdezibel do you think this PR introduced this new behavior?

Was checkout testing completed with anonymous, guest, registered users?
Was checkout testing completed with Avalara, Shippo, multiple payment packages?

prinzdezibel · 2018-02-16T19:17:26Z

@aaronjudd: yes, but should be addressed already by this: #3766

Will test again after applying @Akarshit 's PR

prinzdezibel · 2018-02-19T09:18:52Z

@aaronjudd Tested with avalara, stripe, paypal, shippo.
Tested anonymously and registered. Looks good to me after applying @Akarshit 's PR. Moving to closed again.

prinzdezibel requested a review from jshimko February 2, 2018 10:36

Fix: Consider the second use-case when Stripe is enabled. This should

d2221a6

also result in a double-push of the workflow if shipping & billing is already set.

machikoyasuda mentioned this pull request Feb 8, 2018

Major bug: Unable to place 2 consecutive orders as an anonymous user #3671

Closed

jshimko approved these changes Feb 12, 2018

View reviewed changes

prinzdezibel mentioned this pull request Feb 12, 2018

Cannot complete checkout on second visit when using Anonymous user #3638

Closed

spencern changed the base branch from master to release-1.8.0 February 13, 2018 16:26

spencern merged commit 0367619 into release-1.8.0 Feb 13, 2018

spencern deleted the fix-3638-prinzdezibel-fix-second-checkout-anonymous branch February 13, 2018 16:27

This was referenced Feb 15, 2018

Release 1.8.0 #3645

Merged

(refactor): upgrade Meteor to 1.6.1 #3615

Merged

spencern mentioned this pull request Mar 9, 2018

Release 1.9.0 #3941

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix : Cannot complete checkout on second visit when using Anonymous user #3640

Fix : Cannot complete checkout on second visit when using Anonymous user #3640

prinzdezibel commented Feb 2, 2018 •

edited

Loading

prinzdezibel commented Feb 2, 2018

mattt416 commented Feb 2, 2018 •

edited

Loading

prinzdezibel commented Feb 5, 2018

mattt416 commented Feb 5, 2018

prinzdezibel commented Feb 5, 2018

prinzdezibel commented Feb 5, 2018

mattt416 commented Feb 5, 2018

prinzdezibel commented Feb 5, 2018

mattt416 commented Feb 5, 2018

prinzdezibel commented Feb 5, 2018 •

edited

Loading

mattt416 commented Feb 5, 2018

prinzdezibel commented Feb 5, 2018

mattt416 commented Feb 5, 2018 •

edited

Loading

prinzdezibel commented Feb 5, 2018

brent-hoover commented Feb 6, 2018

prinzdezibel commented Feb 6, 2018 via email

brent-hoover commented Feb 7, 2018

prinzdezibel commented Feb 8, 2018 via email

aaronjudd commented Feb 16, 2018

prinzdezibel commented Feb 16, 2018 •

edited

Loading

prinzdezibel commented Feb 19, 2018 •

edited

Loading

Fix : Cannot complete checkout on second visit when using Anonymous user #3640

Fix : Cannot complete checkout on second visit when using Anonymous user #3640

Conversation

prinzdezibel commented Feb 2, 2018 • edited Loading

To test:

prinzdezibel commented Feb 2, 2018

mattt416 commented Feb 2, 2018 • edited Loading

prinzdezibel commented Feb 5, 2018

mattt416 commented Feb 5, 2018

prinzdezibel commented Feb 5, 2018

prinzdezibel commented Feb 5, 2018

mattt416 commented Feb 5, 2018

prinzdezibel commented Feb 5, 2018

mattt416 commented Feb 5, 2018

prinzdezibel commented Feb 5, 2018 • edited Loading

mattt416 commented Feb 5, 2018

prinzdezibel commented Feb 5, 2018

mattt416 commented Feb 5, 2018 • edited Loading

prinzdezibel commented Feb 5, 2018

brent-hoover commented Feb 6, 2018

prinzdezibel commented Feb 6, 2018 via email

brent-hoover commented Feb 7, 2018

prinzdezibel commented Feb 8, 2018 via email

aaronjudd commented Feb 16, 2018

prinzdezibel commented Feb 16, 2018 • edited Loading

prinzdezibel commented Feb 19, 2018 • edited Loading

prinzdezibel commented Feb 2, 2018 •

edited

Loading

mattt416 commented Feb 2, 2018 •

edited

Loading

prinzdezibel commented Feb 5, 2018 •

edited

Loading

mattt416 commented Feb 5, 2018 •

edited

Loading

prinzdezibel commented Feb 16, 2018 •

edited

Loading

prinzdezibel commented Feb 19, 2018 •

edited

Loading