Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receive "No shipping methods defined" when checking out as guest #3766

Closed
brent-hoover opened this issue Feb 16, 2018 · 8 comments · Fixed by #3645
Closed

Receive "No shipping methods defined" when checking out as guest #3766

brent-hoover opened this issue Feb 16, 2018 · 8 comments · Fixed by #3645
Assignees
Labels
bug For issues that describe a defect or regression in the released software

Comments

@brent-hoover
Copy link
Collaborator

Expected behavior

Shipping methods should not show until you've entered an address

Actual behavior

"No shipping methods are configured" displays even though, shipping methods are in fact configured.

Steps to reproduce the behavior

  1. Visit the site in incognito mode
  2. Add something to cart
  3. Click on "Continue as Guest"
  4. Observe that the "No shipping methods are configured. Please contact the store administrator." message displays
  5. Once you enter your address the shipping methods display as expected

Versions

Node: 8.9.1
NPM: 5.5.1
Meteor Node: 8.9.4
Meteor NPM: 5.6.0
Reaction CLI: 0.27.0
Docker: 17.12.0-ce
@brent-hoover brent-hoover added bug For issues that describe a defect or regression in the released software impact-major labels Feb 16, 2018
@brent-hoover
Copy link
Collaborator Author

I don't know if this is a regression yet but will update shortly

@brent-hoover
Copy link
Collaborator Author

Doesn't happen on master.

@prinzdezibel
Copy link
Contributor

prinzdezibel commented Feb 16, 2018

Has probably to do with this: https://github.com/reactioncommerce/reaction/pull/3640/files
(Not sure actually on a second look, but could be)

@prinzdezibel
Copy link
Contributor

prinzdezibel commented Feb 16, 2018

@Akarshit Yup, I see you found it out already. Thank you! Maybe it's worth to see if the Problem : #3638 is still addressed with your changes.

@Akarshit
Copy link
Contributor

@prinzdezibel Yes #3628 is still fixed with my changes.

@spencern
Copy link
Contributor

@Akarshit @zenweasel This issue is also popping up when there is a "bad" address and no shipping results can be found for the address in question.

http://recordit.co/yZQqnEtbH7

@Akarshit
Copy link
Contributor

@spencern What should be displayed if no shipping results are found because of bad address?
Also I think this might be out of the scope of the issue as this issue is about the "Shipping method" stage being shown before the user enters the address. What do you think?

aaronjudd pushed a commit that referenced this issue Feb 21, 2018
…ping-workflow

Fixes #3766: Checking for shipping address and billing address
@Akarshit
Copy link
Contributor

Closing this, please open a new issue if you think something needs to be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For issues that describe a defect or regression in the released software
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants