Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3766: Checking for shipping address and billing address #3771

Merged
merged 1 commit into from
Feb 21, 2018
Merged

Fixes #3766: Checking for shipping address and billing address #3771

merged 1 commit into from
Feb 21, 2018

Conversation

Akarshit
Copy link
Contributor

Resolves #3766
Impact: minor
Type: bugfix

Issue

Only the billing and shipping object were being checked for existence. It was not checked if they actually had and address or not.

Solution

Now checking if those object contain the address field.

Testing

  1. Visit the site in incognito mode
  2. Add something to cart
  3. Click on "Continue as Guest"
  4. Enter the email
  5. Observe no shipping methods are displayed
  6. Once you enter your address the shipping methods display as expected.

@prinzdezibel prinzdezibel mentioned this pull request Feb 16, 2018
Closed
@aaronjudd aaronjudd merged commit f8fa813 into release-1.8.0 Feb 21, 2018
@brent-hoover brent-hoover deleted the fix-3766-akarshit-shipping-workflow branch February 21, 2018 21:47
@spencern spencern mentioned this pull request Feb 22, 2018
Merged
@spencern spencern mentioned this pull request Mar 9, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jshimko jshimko jshimko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Akarshit @jshimko @aaronjudd