Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot complete checkout on second visit when using Anonymous user #3638

Closed
mattt416 opened this issue Feb 2, 2018 · 5 comments · Fixed by #3645
Closed

Cannot complete checkout on second visit when using Anonymous user #3638

mattt416 opened this issue Feb 2, 2018 · 5 comments · Fixed by #3645
Assignees
@prinzdezibel
Labels
bug For issues that describe a defect or regression in the released software verified reproducible For issues that describe bugs that the core team was able to confirm
Milestone
Bugfix Sprint 1

Comments

@mattt416
Copy link
Contributor

mattt416 commented Feb 2, 2018 •
edited by brent-hoover
Loading

While trying to familiarise myself w/ React Commerce, I thought I'd try some of the acceptance tests documented here.

Expected behavior

To be able to successfully complete tests 1A and 1B acceptable tests.

Actual behavior

After completing 1A and then moving onto 1B, the checkout is stalled by the inability to select Shipping options. A shipping and billing address are present from the order placed in 1A, but the Shipping options box is empty on the second checkout which prevents the checkout from proceeding.

Steps to reproduce the behavior

In my testing, I:

  1. Enabled Flat Rate shipping followed by the Free method
  2. Enabled the Example Provider payment option

Workarounds

Either of the following workarounds cause the Shipping options box to populate and the checkout to proceed:

  1. Delete shipping addresses and re-add
  2. Edit shipping addresses, click Save and continue

Versions

Node: 8.9.4
NPM: 5.6.0
Meteor Node: 8.9.3
Meteor NPM: 5.5.1
Reaction CLI: 0.26.4
Reaction: 1.7.0
Reaction branch: master
Docker: 17.12.0-ce

I had a quick look through existing issues and found #674, which appears to be the exact same issue I'm experiencing here.
@brent-hoover
Copy link
Collaborator

The reaction-sample-data repo has not been maintained, so I not sure that testing with it is still valid.

@mattt416
Copy link
Contributor Author

mattt416 commented Feb 2, 2018 •
edited
Loading

@zenweasel I nuked my reaction app, re-ran reaction init, and was able to replicate this issue using the stock data.

@brent-hoover
Copy link
Collaborator

@mattt416 Noted, thanks.

@aaronjudd aaronjudd added the verified reproducible For issues that describe bugs that the core team was able to confirm label Feb 2, 2018
@prinzdezibel prinzdezibel self-assigned this Feb 2, 2018
prinzdezibel added a commit that referenced this issue Feb 2, 2018
@prinzdezibel
Fix : Cannot complete checkout on second visit when using Anonymous user
848dcf8 
Closes #3638

Changes:
Whenever the user choosed to checkout as anonymous user, the address
book step should be skipped, if there's already a shipping AND billing
address specified for the cart.

Otherwise the address book grid would come up, but both options are
already selected (green check icon). Repeatedly clicking the active
item does not help, one would need to change the address to move beyond
the addressBook workflow step.
@prinzdezibel prinzdezibel mentioned this issue Feb 2, 2018
Merged
@prinzdezibel prinzdezibel assigned jshimko and unassigned jshimko Feb 2, 2018
@brent-hoover brent-hoover added bug For issues that describe a defect or regression in the released software impact-major labels Feb 5, 2018
@prinzdezibel prinzdezibel mentioned this issue Feb 5, 2018
Closed
@machikoyasuda machikoyasuda mentioned this issue Feb 8, 2018
Closed
@spencern spencern added this to the Bugfix Sprint 1 milestone Feb 9, 2018
@prinzdezibel
Copy link
Contributor

prinzdezibel commented Feb 12, 2018 •
edited
Loading

Moved to ready via: #3640

@prinzdezibel prinzdezibel removed their assignment Feb 15, 2018
@prinzdezibel prinzdezibel mentioned this issue Feb 16, 2018
Closed
@prinzdezibel
Copy link
Contributor

need to test with again with PR: #3771

@prinzdezibel prinzdezibel reopened this Feb 16, 2018
@prinzdezibel prinzdezibel self-assigned this Feb 16, 2018
@spencern spencern mentioned this issue Feb 20, 2018
Merged
@spencern spencern mentioned this issue Mar 9, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prinzdezibel prinzdezibel

Labels
bug For issues that describe a defect or regression in the released software verified reproducible For issues that describe bugs that the core team was able to confirm
Projects
None yet
Milestone
Bugfix Sprint 1
Development

Successfully merging a pull request may close this issue.

Release 1.8.0 reactioncommerce/reaction
6 participants
@mattt416 @brent-hoover @aaronjudd @spencern @prinzdezibel @jshimko