Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rector Demo isn't doing any transformations #6412

Closed
tylerc opened this issue May 13, 2021 · 3 comments
Closed

Rector Demo isn't doing any transformations #6412

tylerc opened this issue May 13, 2021 · 3 comments
Labels
bug

Comments

@tylerc
Copy link

tylerc commented May 13, 2021

Bug Report

Subject Details
Rector version Whatever getrector.org is running
Installed as https://getrector.org/demo/

I've been working through understanding which Rector transformations make the most sense for the project I'm working on, and in the past I've used the demo page https://getrector.org/demo as an easy way to try some experiments.

Today when I tried it, I always get "What did Rector change?" // no change no matter what input or configuration I use.

For example, the default demo showing dead code elimination is doing nothing for me:

image

Expected Behaviour

I'd expect the default demo to work at least.
@tylerc tylerc added the bug label May 13, 2021
@TomasVotruba
Copy link
Member

Thanks for reporting, we'll look into it 👍

@TomasVotruba
Copy link
Member

Should be fixed: https://getrector.org/demo/800bb28b-4dc3-4fd4-9584-60f7867ce4d3

@tylerc
Copy link
Author

tylerc commented May 14, 2021

Lookin' good! Thanks!

@tylerc tylerc closed this as completed May 14, 2021
TomasVotruba added a commit that referenced this issue Nov 8, 2024
@TomasVotruba
Updated Rector to commit 1b1807b0f8426641e13e5914389e1c118b3a3d14
13fa633 
rectorphp/rector-src@1b1807b [Privatization] Skip with parameter on PrivatizeLocalGetterToPropertyRector (#6412)
carlos-granados added a commit to carlos-granados/rector that referenced this issue Nov 13, 2024
@carlos-granados
Updated Rector to commit fb3c33aec495946d0bd1b9422b9b65f44665defd
1556d66 
carlos-granados/rector-src@f7ea3db [PHP8.3] add new rectors for get_class()/get_parent_class() without arguments (rectorphp#6405)
carlos-granados/rector-src@1afc647 Rectify (rectorphp#6408)
carlos-granados/rector-src@afe7c46 [DeadCode] Skip nullable @ template on RemoveUselessReturnTagRector (rectorphp#6409)
carlos-granados/rector-src@293eb97 [Php81] Skip Doctrine Embeddable on ReadOnlyPropertyRector (rectorphp#6411)
carlos-granados/rector-src@1b1807b [Privatization] Skip with parameter on PrivatizeLocalGetterToPropertyRector (rectorphp#6412)
carlos-granados/rector-src@2c67908 Fix ClassDependencyManipulator to add dependency on right position (rectorphp#6413)
carlos-granados/rector-src@29e8932 [automated] Apply Coding Standard (rectorphp#6414)
carlos-granados/rector-src@3949fc2 Move instanceof PHPStan Type to ->is*() take 1 (rectorphp#6416)
carlos-granados/rector-src@0cac71a [CodeQuality] Add fixture test for skip nullable array from property with default value (rectorphp#6417)
carlos-granados/rector-src@d2db35e [Php80] Returns null on no change on ClassPropertyAssignToConstructorPromotionRector (rectorphp#6418)
carlos-granados/rector-src@06adce3 use ->isInteger()->yes() on ReturnTypeFromStrictNewArrayRector (rectorphp#6419)
carlos-granados/rector-src@bcfb598 Add ClassNameFromObjectTypeResolver to cover TypeWithClassName instance checks (rectorphp#6420)
carlos-granados/rector-src@84bb596 [StaticTypeMapper] Reduce instanceof TypeWithClassName usage via ClassNameFromObjectTypeResolver (rectorphp#6421)
carlos-granados/rector-src@26b8b54 [Naming] Reduce instanceof ObjectType on ExpectedNameResolver (take 5) (rectorphp#6423)
carlos-granados/rector-src@5baf487 Require-dev phpstan/phpstan-deprecation-rules to show list of deprecated (rectorphp#6415)
carlos-granados/rector-src@c23ba82 [deprecation] Remove deprecated PublicConstantVisibilityRector, cleanup deprecated SetListInterface (rectorphp#6424)
carlos-granados/rector-src@c2053c7 [deprecation] Deprecate AbstractScopeAwareRector in favor of single AbstractRector (rectorphp#6425)
carlos-granados/rector-src@2c5cd97 [deprecated] Remove deprecated AbstractTestCase (rectorphp#6426)
carlos-granados/rector-src@fb3c33a Merge commit '2c5cd97a3a98ab5af9efb846f6f78738e4a195a6'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tylerc @TomasVotruba