-
-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SetList::DEAD_CODE with SetList::SAFE_07 causes PHP Fatal error #6420
Labels
Comments
@TomasVotruba I took a look into it yesterday. Seems a tough one. The culprit is the RemoveDeadStmtRector which holds context of the nodes. So if a node has changed during the run, PhpParser fails because nodes are not the same anymore. |
I see. Could you send a failing test case? I'll see if I can tackle it |
sabbelasichon
added a commit
to sabbelasichon/rector-src
that referenced
this issue
May 17, 2021
TomasVotruba
pushed a commit
to rectorphp/rector-src
that referenced
this issue
May 17, 2021
Thank you 👍 |
TomasVotruba
added a commit
that referenced
this issue
Nov 12, 2024
rectorphp/rector-src@bcfb598 Add ClassNameFromObjectTypeResolver to cover TypeWithClassName instance checks (#6420)
carlos-granados
added a commit
to carlos-granados/rector
that referenced
this issue
Nov 13, 2024
carlos-granados/rector-src@f7ea3db [PHP8.3] add new rectors for get_class()/get_parent_class() without arguments (rectorphp#6405) carlos-granados/rector-src@1afc647 Rectify (rectorphp#6408) carlos-granados/rector-src@afe7c46 [DeadCode] Skip nullable @ template on RemoveUselessReturnTagRector (rectorphp#6409) carlos-granados/rector-src@293eb97 [Php81] Skip Doctrine Embeddable on ReadOnlyPropertyRector (rectorphp#6411) carlos-granados/rector-src@1b1807b [Privatization] Skip with parameter on PrivatizeLocalGetterToPropertyRector (rectorphp#6412) carlos-granados/rector-src@2c67908 Fix ClassDependencyManipulator to add dependency on right position (rectorphp#6413) carlos-granados/rector-src@29e8932 [automated] Apply Coding Standard (rectorphp#6414) carlos-granados/rector-src@3949fc2 Move instanceof PHPStan Type to ->is*() take 1 (rectorphp#6416) carlos-granados/rector-src@0cac71a [CodeQuality] Add fixture test for skip nullable array from property with default value (rectorphp#6417) carlos-granados/rector-src@d2db35e [Php80] Returns null on no change on ClassPropertyAssignToConstructorPromotionRector (rectorphp#6418) carlos-granados/rector-src@06adce3 use ->isInteger()->yes() on ReturnTypeFromStrictNewArrayRector (rectorphp#6419) carlos-granados/rector-src@bcfb598 Add ClassNameFromObjectTypeResolver to cover TypeWithClassName instance checks (rectorphp#6420) carlos-granados/rector-src@84bb596 [StaticTypeMapper] Reduce instanceof TypeWithClassName usage via ClassNameFromObjectTypeResolver (rectorphp#6421) carlos-granados/rector-src@26b8b54 [Naming] Reduce instanceof ObjectType on ExpectedNameResolver (take 5) (rectorphp#6423) carlos-granados/rector-src@5baf487 Require-dev phpstan/phpstan-deprecation-rules to show list of deprecated (rectorphp#6415) carlos-granados/rector-src@c23ba82 [deprecation] Remove deprecated PublicConstantVisibilityRector, cleanup deprecated SetListInterface (rectorphp#6424) carlos-granados/rector-src@c2053c7 [deprecation] Deprecate AbstractScopeAwareRector in favor of single AbstractRector (rectorphp#6425) carlos-granados/rector-src@2c5cd97 [deprecated] Remove deprecated AbstractTestCase (rectorphp#6426) carlos-granados/rector-src@fb3c33a Merge commit '2c5cd97a3a98ab5af9efb846f6f78738e4a195a6'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Report
SetList::DEAD_CODE
withSetList::SAFE_07
causesPHP Fatal error
:terminal output
Minimal PHP Code Causing Issue
https://getrector.org/demo/65c1e5e4-a8e7-4fa5-872d-f6adc0457817
Expected Behaviour
Rector should display a diff which replaces
preg_replace()
with\Safe\preg_replace()
The text was updated successfully, but these errors were encountered: