Throw exception when provideConfigFilePath is not overridden

[matthiasnoback]

When upgrading from Rector 0.8 to 0.11, you should no longer implement provideConfigFileInfo() in tests but instead return the config file path from provideConfigFilePath(). If you don't do this, the error you get will be hard to interpret and fix:

File path "" was not found while creating "RectorPrefix20210514\Symplify\SmartFileSystem\SmartFileInfo" object.
 /opt/project/vendor/rector/rector/vendor/symplify/smart-file-system/src/SmartFileInfo.php:31
 /opt/project/vendor/rector/rector/packages/Testing/PHPUnit/AbstractRectorTestCase.php:58
 /opt/.phpstorm_helpers/codeception.php:51

The empty string comes from the default implementation in AbstractRectorTestCase, but instead of saying "// must be implementedand returning''` it should throw an exception (imo) because it will help the user find out what's wrong.

[matthiasnoback]

(or mark the method as abstract?)

[sabbelasichon]

I think there was a time where different options were possible like use this class or either this config file. But now as far as i can see this is the only option to configure which rules should be applied.

[sabbelasichon]

The method is already required through the RectorTestInterface. So no need to mark it as abstract.

[matthiasnoback]

The method is already required through the RectorTestInterface. So no need to mark it as abstract.

Ah, I didn't know. In that case I think it should not be implemented in AbstractRectorTestCase.

[sabbelasichon]

Best Pull Request i ever had: https://github.com/rectorphp/rector-src/pull/32/files
Put both together, what´s the result ;-)

[sabbelasichon]

This can be closed.

[samsonasik]

@sabbelasichon I closed it, thank you.