-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(): Add Spanish translations #3882
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3882 +/- ##
==========================================
Coverage ? 60.18%
==========================================
Files ? 80
Lines ? 874
Branches ? 127
==========================================
Hits ? 526
Misses ? 321
Partials ? 27 ☔ View full report in Codecov by Sentry. |
Hi @mg-diego ! Although we will release your work in the next version, we will not be able to provide proper translations of new texts in future versions, as we don't have anyone on our team with an acceptable level of Spanish. Thank you once again! |
Hi @AmsterGet, I can provide support for the following RP release spanish translations, just contact me when needed. |
Really appreciate your help! What is the best way to contact you on this matter? |
Yes you can tag me in the pull request directly, that way I'll receive the notification and I can check the new resources missing translation. |
* EPMRPP-91329 || Launch merge functionality is not working as the start/end time values are incorrect (#3873) * EPMRPP-91775 & EPMRPP-91774 || Notification modal bugfixes (#3879) * EPMRPP-91774 || Modal windows should have notification type in the title * EPMRPP-91775 || Incorrect error text on trying to create a rule * EPMRPP-91775 || Translations * EPMRPP-91775 || code review fix -1 * EPMRPP-91264 || Extra request for 'locations' is sent in debug mode (#3880) * EPMRPP-91774 || Added plugin type in delete modal (#3881) * EPMRPP-91774 || Added plugin type in delete modal * EPMRPP-91774 || moved util from editNotificationModal to modal * feat: Add Spanish translations (#3882) * Add spanish translations (202/2220) * Add missing files * Add ES translations (346/2220) * Add ES translations (1593/2220) * Add new ES keys * Add missing translations * Add missing import * Update .md file --------- Co-authored-by: Diego Martinez Gilabert <diego.martinez@betterask.erni> * EPMRPP-91201 || Update the Documentation link (#3885) * EPMRPP-91235 || Use Checkbox & Button components from UI-kit (#3886) * EPMRPP-91235 || button topaz variant fix (#3887) * EPMRPP-90835 || Add GA4 events for Notifications (#3894) * EPMRPP-90835 || Add GA4 events for Notifications * EPMRPP-90835 || code review fix -1 * EPMRPP-91264 || Extra llocation request is sent for error log messages (#3892) * EPMRPP-91264 || Add Condition for Fetching Error Log Location in Detailed Log View Mode (#3897) * EPMRPP-91264 || Add Condition for Fetching Error Log Location in Detailed Log View Mode * EPMRPP-91264 || Removed console.log Statement * EPMRPP-92500 || GA4. Issues with events for Notifications (#3899) * EPMRPP-92500 || GA4. Issues with events for Notifications * EPMRPP-92500 | renaming * EPMRPP-92200 || Disable ability to delete the account of default user (#3900) * EPMRPP-92500 || There is no 'condition' when clicking on the "Configure integration" link (#3902) * Update release.yml * EPMRPP-87464 || Update confirmation messages for Posting issue (#3903) --------- Co-authored-by: maria-hambardzumian <164881199+maria-hambardzumian@users.noreply.github.com> Co-authored-by: mg-diego <39908763+mg-diego@users.noreply.github.com> Co-authored-by: Diego Martinez Gilabert <diego.martinez@betterask.erni> Co-authored-by: Vadim73i <55870906+Vadim73i@users.noreply.github.com> Co-authored-by: Reingold Shekhtel <13565058+raikbitters@users.noreply.github.com>
PR Checklist
develop
for features/bugfixes, other if mentioned in the task)npm run lint
) prior to submission? Enable the git hook on commit in your IDE to run it and format the code automatically.npm run build
)?manage:translations
script?Visuals