-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EPMRPP-90835 || Add GA4 events for Notifications #3894
Merged
maria-hambardzumian
merged 2 commits into
develop
from
feature/EPMRPP-90835-added-ga4-events-for-notifications
Jul 2, 2024
Merged
EPMRPP-90835 || Add GA4 events for Notifications #3894
maria-hambardzumian
merged 2 commits into
develop
from
feature/EPMRPP-90835-added-ga4-events-for-notifications
Jul 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maria-hambardzumian
requested review from
AmsterGet,
Vadim73i and
BlazarQSO
as code owners
July 2, 2024 10:13
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3894 +/- ##
========================================
Coverage 60.18% 60.18%
========================================
Files 80 80
Lines 874 874
Branches 127 127
========================================
Hits 526 526
Misses 321 321
Partials 27 27 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
Vadim73i
approved these changes
Jul 2, 2024
maria-hambardzumian
deleted the
feature/EPMRPP-90835-added-ga4-events-for-notifications
branch
July 2, 2024 13:22
BlazarQSO
added a commit
that referenced
this pull request
Jul 9, 2024
* EPMRPP-91329 || Launch merge functionality is not working as the start/end time values are incorrect (#3873) * EPMRPP-91775 & EPMRPP-91774 || Notification modal bugfixes (#3879) * EPMRPP-91774 || Modal windows should have notification type in the title * EPMRPP-91775 || Incorrect error text on trying to create a rule * EPMRPP-91775 || Translations * EPMRPP-91775 || code review fix -1 * EPMRPP-91264 || Extra request for 'locations' is sent in debug mode (#3880) * EPMRPP-91774 || Added plugin type in delete modal (#3881) * EPMRPP-91774 || Added plugin type in delete modal * EPMRPP-91774 || moved util from editNotificationModal to modal * feat: Add Spanish translations (#3882) * Add spanish translations (202/2220) * Add missing files * Add ES translations (346/2220) * Add ES translations (1593/2220) * Add new ES keys * Add missing translations * Add missing import * Update .md file --------- Co-authored-by: Diego Martinez Gilabert <diego.martinez@betterask.erni> * EPMRPP-91201 || Update the Documentation link (#3885) * EPMRPP-91235 || Use Checkbox & Button components from UI-kit (#3886) * EPMRPP-91235 || button topaz variant fix (#3887) * EPMRPP-90835 || Add GA4 events for Notifications (#3894) * EPMRPP-90835 || Add GA4 events for Notifications * EPMRPP-90835 || code review fix -1 * EPMRPP-91264 || Extra llocation request is sent for error log messages (#3892) * EPMRPP-91264 || Add Condition for Fetching Error Log Location in Detailed Log View Mode (#3897) * EPMRPP-91264 || Add Condition for Fetching Error Log Location in Detailed Log View Mode * EPMRPP-91264 || Removed console.log Statement * EPMRPP-92500 || GA4. Issues with events for Notifications (#3899) * EPMRPP-92500 || GA4. Issues with events for Notifications * EPMRPP-92500 | renaming * EPMRPP-92200 || Disable ability to delete the account of default user (#3900) * EPMRPP-92500 || There is no 'condition' when clicking on the "Configure integration" link (#3902) * Update release.yml * EPMRPP-87464 || Update confirmation messages for Posting issue (#3903) --------- Co-authored-by: maria-hambardzumian <164881199+maria-hambardzumian@users.noreply.github.com> Co-authored-by: mg-diego <39908763+mg-diego@users.noreply.github.com> Co-authored-by: Diego Martinez Gilabert <diego.martinez@betterask.erni> Co-authored-by: Vadim73i <55870906+Vadim73i@users.noreply.github.com> Co-authored-by: Reingold Shekhtel <13565058+raikbitters@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
develop
for features/bugfixes, other if mentioned in the task)npm run lint
) prior to submission? Enable the git hook on commit in your IDE to run it and format the code automatically.npm run build
)?manage:translations
script?Visuals