Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/epmrpp 92303 merge develop #3906

Merged
merged 19 commits into from
Jul 9, 2024

Conversation

BlazarQSO
Copy link
Contributor

@BlazarQSO BlazarQSO commented Jul 5, 2024

PR Checklist

  • Have you verified that the PR is pointing to the correct target branch? (develop for features/bugfixes, other if mentioned in the task)
  • Have you verified that your branch is consistent with the target branch and has no conflicts? (if not, make a rebase under the target branch)
  • Have you checked that everything works within the branch according to the task description and tested it locally?
  • Have you run the linter (npm run lint) prior to submission? Enable the git hook on commit in your IDE to run it and format the code automatically.
  • Have you run the tests locally and added/updated them if needed?
  • Have you checked that app can be built (npm run build)?
  • Have you made sure that all the necessary pipelines has been successfully completed?
  • If the task requires translations to be updated, have you done this by running the manage:translations script?

Visuals

BlazarQSO and others added 17 commits June 19, 2024 00:48
* EPMRPP-91774 || Modal windows should have notification type in the title

* EPMRPP-91775 || Incorrect error text on trying to create a rule

* EPMRPP-91775 || Translations

* EPMRPP-91775 || code review fix -1
* EPMRPP-91774 || Added plugin type in delete modal

* EPMRPP-91774 || moved util from editNotificationModal to modal
* Add spanish translations (202/2220)

* Add missing files

* Add ES translations (346/2220)

* Add ES translations (1593/2220)

* Add new ES keys

* Add missing translations

* Add missing import

* Update .md file

---------

Co-authored-by: Diego Martinez Gilabert <diego.martinez@betterask.erni>
* EPMRPP-90835 || Add GA4 events for Notifications

* EPMRPP-90835 || code review fix -1
…iled Log View Mode (#3897)

* EPMRPP-91264 || Add Condition for Fetching Error Log Location in Detailed Log View Mode

* EPMRPP-91264 || Removed console.log Statement
* EPMRPP-92500 || GA4. Issues with events for Notifications

* EPMRPP-92500 | renaming
Copy link

sonarcloud bot commented Jul 8, 2024

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.08%. Comparing base (3ef87b7) to head (b200fcb).
Report is 1 commits behind head on feature/orgs.

Files Patch % Lines
app/src/common/constants/supportedLanguages.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           feature/orgs    #3906      +/-   ##
================================================
- Coverage         61.15%   61.08%   -0.07%     
================================================
  Files                81       81              
  Lines               901      902       +1     
  Branches            130      130              
================================================
  Hits                551      551              
- Misses              321      322       +1     
  Partials             29       29              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BlazarQSO BlazarQSO merged commit 01c5962 into feature/orgs Jul 9, 2024
7 checks passed
@BlazarQSO BlazarQSO deleted the feature/EPMRPP-92303-merge-develop branch July 9, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants