Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity-path order is not stable with new blueprint #2193

Closed
jleibs opened this issue May 24, 2023 · 1 comment · Fixed by #2327
Closed

Entity-path order is not stable with new blueprint #2193

jleibs opened this issue May 24, 2023 · 1 comment · Fixed by #2327
Labels
🟦 blueprint The data that defines our UI 🪳 bug Something isn't working ⛃ re_datastore affects the datastore itself

Comments

@jleibs
Copy link
Member

jleibs commented May 24, 2023

The real root cause of:

Is that the entity-path query-order can change on storing/retrieving the space-view blueprint from the store.

This allows for numerous "unstable" bugs that result in flickering, etc.

We should define a reasonable order and always use it stably.

@jleibs jleibs added 🪳 bug Something isn't working ⛃ re_datastore affects the datastore itself 🟦 blueprint The data that defines our UI labels May 24, 2023
@abey79
Copy link
Member

abey79 commented Jun 7, 2023

Easy to reproduce/test of a behaviour that's likely due to this issue:

flicker.mp4

Wumpf added a commit that referenced this issue Jun 8, 2023
…ion (#2327)

<!--
Open the PR up as a draft until you feel it is ready for a proper
review.

Do not make PR:s from your own `main` branch, as that makes it difficult
for reviewers to add their own fixes.

Add any improvements to the branch as new commits to make it easier for
reviewers to follow the progress. All commits will be squashed to a
single commit once the PR is merged into `main`.

Make sure you mention any issues that this PR closes in the description,
as well as any other related issues.

To get an auto-generated PR description you can put "copilot:summary" or
"copilot:walkthrough" anywhere.
-->

### What

List of space views is now a BTreeMap, not a HashMap
Fixes #2193
* #2193

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)


<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: https://build.rerun.io/pr/2327

<!-- pr-link-docs:start -->
Docs preview: https://rerun.io/preview/e376b61/docs
Examples preview: https://rerun.io/preview/e376b61/examples
<!-- pr-link-docs:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🟦 blueprint The data that defines our UI 🪳 bug Something isn't working ⛃ re_datastore affects the datastore itself
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants