Don't early-exit on non-pinhole transforms when looking up cameras #2194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleibs
changed the title
jleibs
changed the title
teh-cmc
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a real bug that we started hitting due to:
(one benefit of unstable traversal orders is it uncovers stuff like this).
Previously I assume we always got lucky due to something like the order being mostly deterministic as a function of insertion-order which was stable for objectron, but it seems likely a different insertion order could have broken this since if we ever hit a 3D transform before hitting the pinhole, we would never find the pinhole camera necessary to override the existence of the image in the heuristics.
Fixes:
Checklist
PR Build Summary: https://build.rerun.io/pr/2194