Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opencv_canny example has 2+ seconds latency on macOS #2216

Closed
nikolausWest opened this issue May 25, 2023 · 1 comment · Fixed by #2219
Closed

opencv_canny example has 2+ seconds latency on macOS #2216

nikolausWest opened this issue May 25, 2023 · 1 comment · Fixed by #2219
Labels
🪳 bug Something isn't working examples Issues relating to the Rerun examples 🦟 regression A thing that used to work in an earlier release

Comments

@nikolausWest
Copy link
Member

On macOS, but not linux, the opencv_canny example has 2+ seconds of latency.

How to reproduce:
On a M1 Mac with Rerun version rerun-sdk-0.6.0a0+2023.5.25.b298258 run

./examples/python/opencv_canny/main.py
@nikolausWest nikolausWest added 🪳 bug Something isn't working examples Issues relating to the Rerun examples 🦟 regression A thing that used to work in an earlier release labels May 25, 2023
@emilk
Copy link
Member

emilk commented May 25, 2023

The problem is that we are using crossbeam::channel::unbounded which means there is no back-pressure if the user is logging quicker than then SDK can process the data.

emilk added a commit that referenced this issue May 25, 2023
@emilk
Bound the channels on the SDK to apply back-pressure on slow ingest
a476efd 
Mitigates #2216
This was referenced May 25, 2023
Closed
Merged
emilk added a commit that referenced this issue May 25, 2023
@emilk
Support RRD streams with and without compression. Turn off for SDK co…
8fc7a63 
…mms (#2219)

### What
Closes #2216

The compression for SDK comms was added in
#2065 and now removed in this PR.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)

<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: https://build.rerun.io/pr/2219
emilk added a commit that referenced this issue May 25, 2023
@emilk
Support RRD streams with and without compression. Turn off for SDK co…
0530990 
…mms (#2219)

Closes #2216

The compression for SDK comms was added in
#2065 and now removed in this PR.

* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)

<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: https://build.rerun.io/pr/2219
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🪳 bug Something isn't working examples Issues relating to the Rerun examples 🦟 regression A thing that used to work in an earlier release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support RRD streams with and without compression. Turn off for SDK comms rerun-io/rerun
2 participants
@emilk @nikolausWest