Use the same RRD encoding for the SDK comms as for everything else #2065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comes with two benefits: * We get nice error messages on version mismatch * We get compression of the TCP stream There is also a downside: we need to pay for the slow zstd encoding and decoding. Closes #2003
jprochazk
approved these changes
May 9, 2023
jprochazk
pushed a commit
that referenced
this pull request
May 11, 2023
…2065) * Use the same RRD encoding for the SDK comms as for everything else This comes with two benefits: * We get nice error messages on version mismatch * We get compression of the TCP stream There is also a downside: we need to pay for the slow zstd encoding and decoding. Closes #2003 * Use let-else to reduce rightward drift
1 task
emilk
added a commit
that referenced
this pull request
May 25, 2023
…mms (#2219) ### What Closes #2216 The compression for SDK comms was added in #2065 and now removed in this PR. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2219
emilk
added a commit
that referenced
this pull request
May 25, 2023
…mms (#2219) Closes #2216 The compression for SDK comms was added in #2065 and now removed in this PR. * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2219
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes with two benefits:
There is also a downside: we need to pay for the slow zstd encoding and decoding.
Closes #2003
Checklist
PR Build Summary: https://build.rerun.io/pr/2065