Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support RRD streams with and without compression. Turn off for SDK comms #2219

Merged
merged 5 commits into from
May 25, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented May 25, 2023

What

Closes #2216

The compression for SDK comms was added in #2065 and now removed in this PR.

Checklist

PR Build Summary: https://build.rerun.io/pr/2219

@emilk emilk added the 🚀 performance Optimization, memory use, etc label May 25, 2023
@Wumpf Wumpf self-requested a review May 25, 2023 16:06
crates/re_log_encoding/src/encoder.rs Outdated Show resolved Hide resolved
crates/re_log_encoding/src/decoder.rs Outdated Show resolved Hide resolved
@emilk emilk merged commit 8fc7a63 into main May 25, 2023
@emilk emilk deleted the emilk/configurable-compression branch May 25, 2023 17:24
emilk added a commit that referenced this pull request May 25, 2023
…mms (#2219)

Closes #2216

The compression for SDK comms was added in
#2065 and now removed in this PR.

* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)

<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: https://build.rerun.io/pr/2219
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 performance Optimization, memory use, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opencv_canny example has 2+ seconds latency on macOS
2 participants