Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stuff Cheeks cleanup #3950

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Stuff Cheeks cleanup #3950

merged 1 commit into from
Jan 9, 2024

Conversation

AsparagusEduardo
Copy link
Collaborator

Description

  • Adds tests for Stuff Cheeks.
  • Cleans up CheckMoveLimitations to use less horizontal space..
  • Fixed harcoded uses of MOVE_STUFF_CHEEKS and MOVE_ME_FIRST.
  • Fixed Teatime test checking for Wonder Room instead of Magic Room.

Discord contact info

AsparagusEduardo

@AlexOn1ine AlexOn1ine merged commit 0d75ccd into rh-hideout:upcoming Jan 9, 2024
1 check passed
@AlexOn1ine
Copy link
Collaborator

AlexOn1ine commented Jan 9, 2024 •
edited
Loading

Oops, wasn't this supposed to go to master? I will never stop to forget remembering to check it.

@AsparagusEduardo
Copy link
Collaborator Author

Oops, wasn't this supposed to go to master? I will never stop to forget remembering to check it.

This I wasn't sure tbh. Cleanup I don't immediately means master, since it may mean refactors, and in this case I'm not fixing any bugs.
We could add the Stuff Cheeks tests and Teatime test fix to master if that's what you mean.

@AsparagusEduardo AsparagusEduardo deleted the RHH/pr/upcoming/stuffCheeks branch January 9, 2024 09:55
@AlexOn1ine
Copy link
Collaborator

Oops, wasn't this supposed to go to master? I will never stop to forget remembering to check it.

This I wasn't sure tbh. Cleanup I don't immediately means master, since it may mean refactors, and in this case I'm not fixing any bugs. We could add the Stuff Cheeks tests and Teatime test fix to master if that's what you mean.

No, it's fine since there is no immediate bug from it, no need port them to master.

Fervstheone added a commit to Fervstheone/pokeemerald-expansion that referenced this pull request Jan 9, 2024
@Fervstheone
Stuff Cheeks cleanup (rh-hideout#3950)
ceecc03 
Co-authored-by: Biffalo XIII <--global>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexOn1ine AlexOn1ine AlexOn1ine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AsparagusEduardo @AlexOn1ine