Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin .ini files in icub-main are now automatially generated #586

Merged
merged 5 commits into from
Sep 2, 2019
Merged

Plugin .ini files in icub-main are now automatially generated #586

merged 5 commits into from
Sep 2, 2019

Conversation

randaz81
Copy link
Member

pull request on icub-main master as requested

@randaz81 randaz81 self-assigned this Jun 17, 2019
drdanz
drdanz suggested changes Jun 19, 2019
View reviewed changes
Copy link
Member

@drdanz drdanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review

src/libraries/icubmod/canBusSkin/canBusSkin.ini Show resolved Hide resolved
src/libraries/icubmod/canBusVirtualAnalogSensor/canBusVirtualAnalogSensor.ini Show resolved Hide resolved
src/libraries/icubmod/cartesianController/CMakeLists.txt Show resolved Hide resolved
src/libraries/icubmod/cfw2Can/cfw2can.ini Show resolved Hide resolved
src/libraries/icubmod/dragonfly2/CMakeLists.txt Show resolved Hide resolved
src/libraries/icubmod/embObjInertials/embObjInertials.ini Show resolved Hide resolved
src/libraries/icubmod/embObjMais/embObjMais.ini Show resolved Hide resolved
src/libraries/icubmod/embObjMultiEnc/embObjMultiEnc.ini Show resolved Hide resolved
src/libraries/icubmod/embObjPSC/embObjPSC.ini Show resolved Hide resolved
src/libraries/icubmod/embObjStrain/embObjStrain.ini Show resolved Hide resolved
barbalberto
barbalberto approved these changes Jun 19, 2019
View reviewed changes
Copy link

@barbalberto barbalberto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it

src/libraries/icubmod/imu3DM_GX3/CMakeLists.txt Show resolved Hide resolved
@randaz81 randaz81 requested a review from drdanz June 19, 2019 12:24
drdanz
drdanz previously requested changes Jun 20, 2019
View reviewed changes
Copy link
Member

@drdanz drdanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these 2 are still wrong

src/libraries/icubmod/bcbBattery/bcbBattery.ini Show resolved Hide resolved
src/libraries/icubmod/bmsBattery/bmsBattery.ini Show resolved Hide resolved
@randaz81 randaz81 requested a review from drdanz August 28, 2019 08:13
@randaz81
Copy link
Member Author

Ready to be merged @drdanz

drdanz
drdanz approved these changes Sep 2, 2019
View reviewed changes
Copy link
Member

@drdanz drdanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@randaz81 randaz81 merged commit 29fb856 into master Sep 2, 2019
@pattacini pattacini deleted the plugin_ini_files branch September 2, 2019 12:14
This was referenced May 24, 2020
Closed
Closed
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drdanz drdanz drdanz approved these changes

@barbalberto barbalberto barbalberto approved these changes

Assignees

@randaz81 randaz81

Labels
Resolution: Merged Type: Cleanup Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@randaz81 @drdanz @barbalberto @Nicogene