Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eomcParser and embObjMotionControl to support the new velocityThresh param #902

Closed
wants to merge 2 commits into from

Conversation

sgiraz
Copy link
Contributor

@sgiraz sgiraz commented Aug 29, 2023

What's new:

  • The eomcParser now detects the presence of the new velocityThresh when it is written in the configuration files. If the velocityThresh is omitted its default value is 0.
  • ⚠️ The eomcParser will not recognize the kbemf parameter. Hence, all the config files in robots-configuration have to be updated accordingly

Note

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sgiraz,

Given this change, you ought to update the dependencies here too.

@pattacini
Copy link
Member

Hi @sgiraz

Any reason why you opened another PR (see #903)?

@sgiraz
Copy link
Contributor Author

sgiraz commented Aug 31, 2023

Hi @sgiraz,

Given this change, you ought to update the dependencies here too.

Hi @pattacini, yes!
I'm going to close this PR in favor of #903

@sgiraz sgiraz closed this Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants