Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix covers deleted when uploading extension other then PNG #1002

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

gantoine
Copy link
Member

Instead of explicitly looking for .png files, we glob for any file that matches the folder structure

@gantoine gantoine requested a review from zurdi15 July 14, 2024 21:37
Copy link

Test Results

72 tests  ±0   72 ✅ ±0   19s ⏱️ -1s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit d05a539. ± Comparison against base commit d8ffc1a.

@zurdi15 zurdi15 merged commit 7617daf into master Jul 15, 2024
8 checks passed
@zurdi15 zurdi15 deleted the fix-delete-cover-on-rescan branch July 15, 2024 08:00
spiceratops added a commit to spiceratops/k8s-gitops that referenced this pull request Jul 23, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [rommapp/romm](https://github.com/rommapp/romm) | minor | `3.2.0` ->
`3.3.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>rommapp/romm (rommapp/romm)</summary>

### [`v3.3.0`](https://github.com/rommapp/romm/releases/tag/3.3.0)

[Compare
Source](https://github.com/rommapp/romm/compare/3.2.0...3.3.0)

#### What's Changed

- UI complete redesign by
[@&#8203;zurdi15](https://github.com/zurdi15) in
[rommapp/romm#934
- Covers are now fetch in their 1080p version by
[@&#8203;zurdi15](https://github.com/zurdi15) in
[rommapp/romm#934
- Now sibling roms can have different covers by
[@&#8203;zurdi15](https://github.com/zurdi15) in
[rommapp/romm#934
- Screenshots are fetch in their big version by
[@&#8203;zurdi15](https://github.com/zurdi15) in
[rommapp/romm#934
- Setup wizard added for new **RomM** installations by
[@&#8203;zurdi15](https://github.com/zurdi15) in
[rommapp/romm#976
- Added collections by [@&#8203;zurdi15](https://github.com/zurdi15)
in
[rommapp/romm#964
- Add favourites collection as special collection by
[@&#8203;zurdi15](https://github.com/zurdi15) in
[rommapp/romm#977
- SteamGridDB integration. Roms and collections can be edited with a
SteamGridDB cover by [@&#8203;zurdi15](https://github.com/zurdi15) in
[rommapp/romm#960
- Enhanced scan logs by [@&#8203;zurdi15](https://github.com/zurdi15)
in
[rommapp/romm#965
- Select main sibling added for merged roms in gallery by
[@&#8203;zurdi15](https://github.com/zurdi15) in
[rommapp/romm#963
- Allow users to edit their own profile by
[@&#8203;zurdi15](https://github.com/zurdi15) in
[rommapp/romm#975
- Fixed firmware drawer permissions by
[@&#8203;zurdi15](https://github.com/zurdi15) in
[rommapp/romm#956
- Added total filesize endpoint by
[@&#8203;adamantike](https://github.com/adamantike) in
[rommapp/romm#969
- Improved Docker image size by
[@&#8203;adamantike](https://github.com/adamantike) in
[rommapp/romm#947
- Install redis instead of building in Dockerfile by
[@&#8203;gantoine](https://github.com/gantoine) in
[rommapp/romm#945
- Fix section links and improve grammar/spelling in README.md by
[@&#8203;TylerVigario](https://github.com/TylerVigario) in
[rommapp/romm#914
- Add trunk.io checks by
[@&#8203;gantoine](https://github.com/gantoine) in
[rommapp/romm#868
- Add parallel-n64 to cores by
[@&#8203;gantoine](https://github.com/gantoine) in
[rommapp/romm#923
- Use core icon when showing version by
[@&#8203;gantoine](https://github.com/gantoine) in
[rommapp/romm#922
- Add interactive table of contents by
[@&#8203;Nicmorris1820](https://github.com/Nicmorris1820) in
[rommapp/romm#924
- Added linuxserver/mariadb as alternative by
[@&#8203;need4swede](https://github.com/need4swede) in
[rommapp/romm#926
- Added large carousel on screnshot click by
[@&#8203;zurdi15](https://github.com/zurdi15) in
[rommapp/romm#932
- Resources structure migrated from
`resources/{platform_slug}/{rom_name}` to
`resources/roms/{platform_id}/{rom_id}`.
- Disabled zip compression on streaming multi-file download to increase
speed by [@&#8203;adamantike](https://github.com/adamantike) in
[rommapp/romm#983
- Prevent mass-purging of roms during scan if filesystem is not
correctly mounted by [@&#8203;gantoine](https://github.com/gantoine)
in
[rommapp/romm#987
- Fixed abort scan by [@&#8203;gantoine](https://github.com/gantoine)
in
[rommapp/romm#1004
- Added support for any kind of image extension on custom covers by
[@&#8203;gantoine](https://github.com/gantoine) in
[rommapp/romm#1002
-   Fixes and improvements everywhere

#### New Contributors

- [@&#8203;adamantike](https://github.com/adamantike) made their first
contribution in
[rommapp/romm#947
- [@&#8203;TylerVigario](https://github.com/TylerVigario) made their
first contribution in
[rommapp/romm#914
- [@&#8203;Nicmorris1820](https://github.com/Nicmorris1820) made their
first contribution in
[rommapp/romm#924
- [@&#8203;need4swede](https://github.com/need4swede) made their first
contribution in
[rommapp/romm#926
- [@&#8203;lepture](https://github.com/lepture) made their first
contribution in
[rommapp/romm#931

**Full Changelog**:
rommapp/romm@3.2.0...3.3.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzQuMiIsInVwZGF0ZWRJblZlciI6IjM3LjQzNC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL21pbm9yIl19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants