-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent mass purging of games and platforms during scan #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results72 tests 72 ✅ 20s ⏱️ Results for commit 5e3522c. |
zurdi15
approved these changes
Jul 8, 2024
Merged
spiceratops
referenced
this pull request
in spiceratops/k8s-gitops
Jul 23, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [rommapp/romm](https://github.com/rommapp/romm) | minor | `3.2.0` -> `3.3.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>rommapp/romm (rommapp/romm)</summary> ### [`v3.3.0`](https://github.com/rommapp/romm/releases/tag/3.3.0) [Compare Source](https://github.com/rommapp/romm/compare/3.2.0...3.3.0) #### What's Changed - UI complete redesign by [@​zurdi15](https://github.com/zurdi15) in [https://github.com/rommapp/romm/pull/934](https://github.com/rommapp/romm/pull/934) - Covers are now fetch in their 1080p version by [@​zurdi15](https://github.com/zurdi15) in [https://github.com/rommapp/romm/pull/934](https://github.com/rommapp/romm/pull/934) - Now sibling roms can have different covers by [@​zurdi15](https://github.com/zurdi15) in [https://github.com/rommapp/romm/pull/934](https://github.com/rommapp/romm/pull/934) - Screenshots are fetch in their big version by [@​zurdi15](https://github.com/zurdi15) in [https://github.com/rommapp/romm/pull/934](https://github.com/rommapp/romm/pull/934) - Setup wizard added for new **RomM** installations by [@​zurdi15](https://github.com/zurdi15) in [https://github.com/rommapp/romm/pull/976](https://github.com/rommapp/romm/pull/976) - Added collections by [@​zurdi15](https://github.com/zurdi15) in [https://github.com/rommapp/romm/pull/964](https://github.com/rommapp/romm/pull/964) - Add favourites collection as special collection by [@​zurdi15](https://github.com/zurdi15) in [https://github.com/rommapp/romm/pull/977](https://github.com/rommapp/romm/pull/977) - SteamGridDB integration. Roms and collections can be edited with a SteamGridDB cover by [@​zurdi15](https://github.com/zurdi15) in [https://github.com/rommapp/romm/pull/960](https://github.com/rommapp/romm/pull/960) - Enhanced scan logs by [@​zurdi15](https://github.com/zurdi15) in [https://github.com/rommapp/romm/pull/965](https://github.com/rommapp/romm/pull/965) - Select main sibling added for merged roms in gallery by [@​zurdi15](https://github.com/zurdi15) in [https://github.com/rommapp/romm/pull/963](https://github.com/rommapp/romm/pull/963) - Allow users to edit their own profile by [@​zurdi15](https://github.com/zurdi15) in [https://github.com/rommapp/romm/pull/975](https://github.com/rommapp/romm/pull/975) - Fixed firmware drawer permissions by [@​zurdi15](https://github.com/zurdi15) in [https://github.com/rommapp/romm/pull/956](https://github.com/rommapp/romm/pull/956) - Added total filesize endpoint by [@​adamantike](https://github.com/adamantike) in [https://github.com/rommapp/romm/pull/969](https://github.com/rommapp/romm/pull/969) - Improved Docker image size by [@​adamantike](https://github.com/adamantike) in [https://github.com/rommapp/romm/pull/947](https://github.com/rommapp/romm/pull/947) - Install redis instead of building in Dockerfile by [@​gantoine](https://github.com/gantoine) in [https://github.com/rommapp/romm/pull/945](https://github.com/rommapp/romm/pull/945) - Fix section links and improve grammar/spelling in README.md by [@​TylerVigario](https://github.com/TylerVigario) in [https://github.com/rommapp/romm/pull/914](https://github.com/rommapp/romm/pull/914) - Add trunk.io checks by [@​gantoine](https://github.com/gantoine) in [https://github.com/rommapp/romm/pull/868](https://github.com/rommapp/romm/pull/868) - Add parallel-n64 to cores by [@​gantoine](https://github.com/gantoine) in [https://github.com/rommapp/romm/pull/923](https://github.com/rommapp/romm/pull/923) - Use core icon when showing version by [@​gantoine](https://github.com/gantoine) in [https://github.com/rommapp/romm/pull/922](https://github.com/rommapp/romm/pull/922) - Add interactive table of contents by [@​Nicmorris1820](https://github.com/Nicmorris1820) in [https://github.com/rommapp/romm/pull/924](https://github.com/rommapp/romm/pull/924) - Added linuxserver/mariadb as alternative by [@​need4swede](https://github.com/need4swede) in [https://github.com/rommapp/romm/pull/926](https://github.com/rommapp/romm/pull/926) - Added large carousel on screnshot click by [@​zurdi15](https://github.com/zurdi15) in [https://github.com/rommapp/romm/pull/932](https://github.com/rommapp/romm/pull/932) - Resources structure migrated from `resources/{platform_slug}/{rom_name}` to `resources/roms/{platform_id}/{rom_id}`. - Disabled zip compression on streaming multi-file download to increase speed by [@​adamantike](https://github.com/adamantike) in [https://github.com/rommapp/romm/pull/983](https://github.com/rommapp/romm/pull/983) - Prevent mass-purging of roms during scan if filesystem is not correctly mounted by [@​gantoine](https://github.com/gantoine) in [https://github.com/rommapp/romm/pull/987](https://github.com/rommapp/romm/pull/987) - Fixed abort scan by [@​gantoine](https://github.com/gantoine) in [https://github.com/rommapp/romm/pull/1004](https://github.com/rommapp/romm/pull/1004) - Added support for any kind of image extension on custom covers by [@​gantoine](https://github.com/gantoine) in [https://github.com/rommapp/romm/pull/1002](https://github.com/rommapp/romm/pull/1002) - Fixes and improvements everywhere #### New Contributors - [@​adamantike](https://github.com/adamantike) made their first contribution in [https://github.com/rommapp/romm/pull/947](https://github.com/rommapp/romm/pull/947) - [@​TylerVigario](https://github.com/TylerVigario) made their first contribution in [https://github.com/rommapp/romm/pull/914](https://github.com/rommapp/romm/pull/914) - [@​Nicmorris1820](https://github.com/Nicmorris1820) made their first contribution in [https://github.com/rommapp/romm/pull/924](https://github.com/rommapp/romm/pull/924) - [@​need4swede](https://github.com/need4swede) made their first contribution in [https://github.com/rommapp/romm/pull/926](https://github.com/rommapp/romm/pull/926) - [@​lepture](https://github.com/lepture) made their first contribution in [https://github.com/rommapp/romm/pull/931](https://github.com/rommapp/romm/pull/931) **Full Changelog**: rommapp/romm@3.2.0...3.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzQuMiIsInVwZGF0ZWRJblZlciI6IjM3LjQzNC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL21pbm9yIl19-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My NAS didn't mount correctly after a reboot, so when the nightly scan ran, it found no files in the filesystem, and purged all the games from my library. This PR prevents purging all games during a scan, but still allows for manual removal via the UI.