[testing] draft cases for private generics #285

feliciss · 2023-06-14T09:06:23Z

Attempt to resolve #265

steelgeek091 · 2023-06-14T09:54:13Z

The error message should be explicitly displayed in the exp file.

feliciss · 2023-06-15T05:14:50Z

The error message should be explicitly displayed in the exp file.

Noted. I'll try to add them.

jolestar · 2023-06-22T13:47:15Z

...-framework-tests/tests/cases/private_generics/verify_private_generics_in_primitive_types.exp

+41 │         bar<vector<u8>>();
+   │         ^^^^^^^^^^^^^^^^^
+
+status EXECUTED


If the verifier raises an error, the module should not publish success, and the status is not EXECUTED @steelgeek091

Fxied in PR #345

Fixed this PR.

steelgeek091 · 2023-06-24T12:27:45Z

...-framework-tests/tests/cases/private_generics/verify_private_generics_in_primitive_types.exp

+41 │         bar<vector<u8>>();
+   │         ^^^^^^^^^^^^^^^^^
+
+status EXECUTED


Fxied in PR #345

steelgeek091 · 2023-06-24T12:29:27Z

...och-framework-tests/tests/cases/private_generics/verify_private_generics_outside_module.move

+    }
+
+    public fun invoke_publish_bar(s: &signer) {
+        publish_bar<Foo>(s);


After merging PR #345, some modifications need to be made to the test cases.

steelgeek091

The relevant detection Rust code for private_generics has been updated. Please make the necessary modifications and resubmit.

feliciss · 2023-06-27T02:57:32Z

The relevant detection Rust code for private_generics has been updated. Please make the necessary modifications and resubmit.

I think you should change the decoration of datatest_stable::harness!?

When changing the line

use rooch_integration_test_runner::run_test;

to

use rooch_integration_test_runner::run_integration_test_with_extended_check;

and use it in test cases in replacement to run_test:

datatest_stable::harness!(run_integration_test_with_extended_check, "integration-tests", r".*\.move");

There would be errors stating that

error[E0308]: mismatched types
  --> crates/rooch-integration-test-runner/tests/tests.rs:3:1
   |
3  | datatest_stable::harness!(run_integration_test_with_extended_check, "integration-tests", r".*\.move");
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   | |
   | incorrect number of function parameters
   | arguments to this function are incorrect
   |
   = note: expected fn pointer `for<'a> fn(&'a Path) -> Result<_, _>`
                 found fn item `for<'a, 'b, 'c> fn(&'a Path, ..., ...) -> ... {run_integration_test_with_extended_check}`
note: associated function defined here
  --> runner.rs:30:12
   |
30 |     pub fn new(
   |            ^^^
   = note: this error originates in the macro `datatest_stable::harness` (in Nightly builds, run with -Z macro-backtrace for more info)

For more information about this error, try `rustc --explain E0308`.
error: could not compile `rooch-integration-test-runner` due to previous error

It may originate from adding additional params to function run_integration_test_with_extended_check but no changes leave in datatest_stable::harness! function?

steelgeek091 · 2023-06-27T03:17:32Z

The relevant detection Rust code for private_generics has been updated. Please make the necessary modifications and resubmit.

I think you should change the decoration of datatest_stable::harness!?

When changing the line

use rooch_integration_test_runner::run_test;

to

use rooch_integration_test_runner::run_integration_test_with_extended_check;

and use it in test cases in replacement to run_test:

datatest_stable::harness!(run_integration_test_with_extended_check, "integration-tests", r".*\.move");

There would be errors stating that

error[E0308]: mismatched types
  --> crates/rooch-integration-test-runner/tests/tests.rs:3:1
   |
3  | datatest_stable::harness!(run_integration_test_with_extended_check, "integration-tests", r".*\.move");
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   | |
   | incorrect number of function parameters
   | arguments to this function are incorrect
   |
   = note: expected fn pointer `for<'a> fn(&'a Path) -> Result<_, _>`
                 found fn item `for<'a, 'b, 'c> fn(&'a Path, ..., ...) -> ... {run_integration_test_with_extended_check}`
note: associated function defined here
  --> runner.rs:30:12
   |
30 |     pub fn new(
   |            ^^^
   = note: this error originates in the macro `datatest_stable::harness` (in Nightly builds, run with -Z macro-backtrace for more info)

For more information about this error, try `rustc --explain E0308`.
error: could not compile `rooch-integration-test-runner` due to previous error

It may originate from adding additional params to function run_integration_test_with_extended_check but no changes leave in datatest_stable::harness! function?

The situation is the same for crates/rooch-integration-test-runner and crates/rooch-framework-tests. However, when executing rooch move integration-test under the move package, the situation is different from the previous two and requires special handling.

feliciss · 2023-06-27T04:24:06Z

The relevant detection Rust code for private_generics has been updated. Please make the necessary modifications and resubmit.

I think you should change the decoration of datatest_stable::harness!?
When changing the line
use rooch_integration_test_runner::run_test;
to
use rooch_integration_test_runner::run_integration_test_with_extended_check;
and use it in test cases in replacement to run_test:
datatest_stable::harness!(run_integration_test_with_extended_check, "integration-tests", r".*\.move");
There would be errors stating that
error[E0308]: mismatched types
  --> crates/rooch-integration-test-runner/tests/tests.rs:3:1
   |
3  | datatest_stable::harness!(run_integration_test_with_extended_check, "integration-tests", r".*\.move");
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   | |
   | incorrect number of function parameters
   | arguments to this function are incorrect
   |
   = note: expected fn pointer `for<'a> fn(&'a Path) -> Result<_, _>`
                 found fn item `for<'a, 'b, 'c> fn(&'a Path, ..., ...) -> ... {run_integration_test_with_extended_check}`
note: associated function defined here
  --> runner.rs:30:12
   |
30 |     pub fn new(
   |            ^^^
   = note: this error originates in the macro `datatest_stable::harness` (in Nightly builds, run with -Z macro-backtrace for more info)

For more information about this error, try `rustc --explain E0308`.
error: could not compile `rooch-integration-test-runner` due to previous error
It may originate from adding additional params to function run_integration_test_with_extended_check but no changes leave in datatest_stable::harness! function?
The situation is the same for crates/rooch-integration-test-runner and crates/rooch-framework-tests. However, when executing rooch move integration-test under the move package, the situation is different from the previous two and requires special handling.

Got it. Code in this PR are under directories crates/rooch-integration-test-runner and crates/rooch-framework-tests so it doesn't need special handlings.

I will remain them unchanged and request your review.

* commit '5c4f49d911ef44975a6de8e2bc8ff8f8b181314c': migration rooch network (rooch-network#364) Remove the TxContext in the move test file. (rooch-network#362) Rename framework modules (rooch-network#361) fix README typo (rooch-network#359) [integration-test-runner] private_generics tests. (rooch-network#354) [testing] draft cases for private generics (rooch-network#285) Remove TxContext from the check in the entry function. (rooch-network#360) [Framework Testing] Add test to account_storage exists and move_from (rooch-network#358) add rust setup to workflow (rooch-network#356) Fix the issue of illegal invocation of private_generics in the module without throwing an error. (rooch-network#345) (rooch-network#351)

jolestar requested a review from steelgeek091 June 14, 2023 09:14

feliciss force-pushed the issue#265 branch from 5c7773f to 7c65816 Compare June 14, 2023 22:25

feliciss force-pushed the issue#265 branch from 7c65816 to 68cfe11 Compare June 21, 2023 22:34

feliciss marked this pull request as ready for review June 22, 2023 09:23

jolestar reviewed Jun 22, 2023

View reviewed changes

feliciss force-pushed the issue#265 branch from d1e012f to 6a69d56 Compare June 23, 2023 07:35

steelgeek091 reviewed Jun 24, 2023

View reviewed changes

feliciss force-pushed the issue#265 branch from 6a69d56 to ebe353e Compare June 24, 2023 22:15

feliciss requested review from jolestar and steelgeek091 June 24, 2023 22:28

feliciss mentioned this pull request Jun 25, 2023

[gh-296] Add example integration test for private generics. #297

Closed

Feliciss added 7 commits June 26, 2023 19:05

[testing] draft cases for private generics

371d7d9

[commit] request for review.

43671fb

Fix exp from a new line.

ffe73f2

Add ObjectID and String cases.

9145b00

Fix test cases accroding to PR rooch-network#345.

97260a0

rename private_generics test files.

ee56a38

[rooch-framework-tests] add recursive struct test.

196e59d

feliciss force-pushed the issue#265 branch from 38e3b81 to 196e59d Compare June 27, 2023 01:15

steelgeek091 reviewed Jun 27, 2023

View reviewed changes

feliciss requested a review from steelgeek091 June 27, 2023 04:22

[rooch-framework-tests] rename tests.

c809a47

steelgeek091 approved these changes Jun 27, 2023

View reviewed changes

steelgeek091 merged commit 4dafd3c into rooch-network:main Jun 27, 2023

feliciss deleted the issue#265 branch June 27, 2023 21:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[testing] draft cases for private generics #285

[testing] draft cases for private generics #285

feliciss commented Jun 14, 2023 •

edited

Loading

steelgeek091 commented Jun 14, 2023

feliciss commented Jun 15, 2023

jolestar Jun 22, 2023

steelgeek091 Jun 24, 2023

feliciss Jun 24, 2023

steelgeek091 Jun 24, 2023

steelgeek091 Jun 24, 2023

feliciss Jun 24, 2023

steelgeek091 left a comment •

edited

Loading

feliciss commented Jun 27, 2023 •

edited

Loading

steelgeek091 commented Jun 27, 2023

feliciss commented Jun 27, 2023

[testing] draft cases for private generics #285

[testing] draft cases for private generics #285

Conversation

feliciss commented Jun 14, 2023 • edited Loading

steelgeek091 commented Jun 14, 2023

feliciss commented Jun 15, 2023

jolestar Jun 22, 2023

Choose a reason for hiding this comment

steelgeek091 Jun 24, 2023

Choose a reason for hiding this comment

feliciss Jun 24, 2023

Choose a reason for hiding this comment

steelgeek091 Jun 24, 2023

Choose a reason for hiding this comment

steelgeek091 Jun 24, 2023

Choose a reason for hiding this comment

feliciss Jun 24, 2023

Choose a reason for hiding this comment

steelgeek091 left a comment • edited Loading

Choose a reason for hiding this comment

feliciss commented Jun 27, 2023 • edited Loading

steelgeek091 commented Jun 27, 2023

feliciss commented Jun 27, 2023

feliciss commented Jun 14, 2023 •

edited

Loading

steelgeek091 left a comment •

edited

Loading

feliciss commented Jun 27, 2023 •

edited

Loading