Check if private_generics is used correctly in the integration-test. #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jolestar
reviewed
Jun 25, 2023
| @@ -238,8 +246,8 @@ impl IntegrationTest { | |||
| test_args.push(filter); | |||
| } | |||
|
|
|||
| let test_opts = datatest_stable::TestOpts::try_parse_from(test_args.as_slice())?; | |||
There was a problem hiding this comment.
The datatest_stable::TestOpt can support filters, for example, running a specific test or running tests via prefix.
It also can run tests in multi-thread, I think the datatest_stable is useful, we can refactor it.
There was a problem hiding this comment.
The issue has been fixed, and we have resumed using datatest for testing.
… without throwing an error. (#345) Check if private_generics is used correctly in the integration-test. Resume using datatest for testing. cargo fmt Change the path of the datatest library.
jolestar
approved these changes
Jun 26, 2023
wubuku
added a commit
to wubuku/rooch
that referenced
this pull request
Jun 27, 2023
* commit '5c4f49d911ef44975a6de8e2bc8ff8f8b181314c': migration rooch network (rooch-network#364) Remove the TxContext in the move test file. (rooch-network#362) Rename framework modules (rooch-network#361) fix README typo (rooch-network#359) [integration-test-runner] private_generics tests. (rooch-network#354) [testing] draft cases for private generics (rooch-network#285) Remove TxContext from the check in the entry function. (rooch-network#360) [Framework Testing] Add test to account_storage exists and move_from (rooch-network#358) add rust setup to workflow (rooch-network#356) Fix the issue of illegal invocation of private_generics in the module without throwing an error. (rooch-network#345) (rooch-network#351)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue of not checking
private_genericswhen executing the commandrooch move integration-test -p private_generics/ --named-addresses rooch_examples=0x1234in theexamples/private_genericsdirectory has been resolved.However, there are still some remaining issues:
The
datatest_stable::runner_with_optsinvocation is bypassed, and the test cases are executed directly. This means that some additional options, such asrooch move test --listto view the current test projects, will not be executed (but it does not affect the testing process).Because the
integration-testdepends on a complete Move package, and it is itself a separate Move file, it is not possible to compile them together. Instead, the dependent Move package is compiled first, followed by the compilation of the individual Move file. Finally, the result of compiling the Move package is injected into the checking process of the individual Move file.resolve #350.