Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the issue of not throwing an error during compilation of the private_generics module. #345

Merged
merged 1 commit into from
Jun 24, 2023
Merged

Fix the issue of not throwing an error during compilation of the private_generics module. #345

merged 1 commit into from
Jun 24, 2023

Conversation

steelgeek091
Copy link
Collaborator

  1. Fix the issue of illegal invocation of private_generics in the module without throwing an error. @feliciss
  2. In the testing framework, do not print 'EXECUTED' when there is a compilation error.

@steelgeek091 steelgeek091 mentioned this pull request Jun 24, 2023
Merged
@steelgeek091
Fix the issue of illegal invocation of private_generics in the module…
7777bd9 
… without throwing an error.

update the content of exp file in testcase
@jolestar jolestar merged commit e943c62 into rooch-network:main Jun 24, 2023
feliciss pushed a commit to feliciss/rooch that referenced this pull request Jun 24, 2023
Fix test cases accroding to PR rooch-network#345.
ebe353e
wubuku added a commit to wubuku/rooch that referenced this pull request Jun 26, 2023
@wubuku
Merge commit '4b1455160a92181c304e87395cf94328aa611a7b'
fa5419d 
* commit '4b1455160a92181c304e87395cf94328aa611a7b':
  [Testing] moveos_stdlib::account_storage (rooch-network#355)
  add release workflow (rooch-network#343)
  [cli] return a string for init command. (rooch-network#347)
  Feature owen eth rooch address mapping (rooch-network#348)
  Fix the issue of illegal invocation of private_generics in the module without throwing an error. (rooch-network#345)
jolestar pushed a commit that referenced this pull request Jun 26, 2023
@steelgeek091
Fix the issue of illegal invocation of private_generics in the module…
55373ef 
… without throwing an error. (#345) (#351)

Check if private_generics is used correctly in the integration-test.

Resume using datatest for testing.

cargo fmt

Change the path of the datatest library.
feliciss pushed a commit to feliciss/rooch that referenced this pull request Jun 27, 2023
Fix test cases accroding to PR rooch-network#345.
97260a0
steelgeek091 pushed a commit that referenced this pull request Jun 27, 2023
@feliciss
[testing] draft cases for private generics (#285)
4dafd3c 
* [testing] draft cases for private generics

* [commit] request for review.

* Fix exp from a new line.

* Add ObjectID and String cases.

* Fix test cases accroding to PR #345.

* rename private_generics test files.

* [rooch-framework-tests] add recursive struct test.

* [rooch-framework-tests] rename tests.

---------

Co-authored-by: Feliciss <10203-feliciss@users.noreply.0xacab.org>
wubuku added a commit to wubuku/rooch that referenced this pull request Jun 27, 2023
@wubuku
Merge commit '5c4f49d911ef44975a6de8e2bc8ff8f8b181314c'
591afac 
* commit '5c4f49d911ef44975a6de8e2bc8ff8f8b181314c':
  migration rooch network (rooch-network#364)
  Remove the TxContext in the move test file. (rooch-network#362)
  Rename framework modules (rooch-network#361)
  fix README typo (rooch-network#359)
  [integration-test-runner] private_generics tests. (rooch-network#354)
  [testing] draft cases for private generics (rooch-network#285)
  Remove TxContext from the check in the entry function. (rooch-network#360)
  [Framework Testing] Add test to account_storage exists and move_from (rooch-network#358)
  add rust setup to workflow (rooch-network#356)
  Fix the issue of illegal invocation of private_generics in the module without throwing an error. (rooch-network#345) (rooch-network#351)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baichuan3 baichuan3 baichuan3 approved these changes

@jolestar jolestar jolestar approved these changes

@wow-sven wow-sven Awaiting requested review from wow-sven

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@steelgeek091 @jolestar @baichuan3