Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[diff_drive_controller] Remove non-stamped Twist option #812

Merged
merged 2 commits into from
Nov 7, 2023
Merged

[diff_drive_controller] Remove non-stamped Twist option #812

merged 2 commits into from
Nov 7, 2023

Conversation

bmagyar
Copy link
Member

@bmagyar bmagyar commented Nov 1, 2023

As per popular demand @destogl

@bmagyar bmagyar added the hold Holding off merging this PR until some condition label Nov 1, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #812 (973608c) into master (6e46053) will increase coverage by 0.11%.
The diff coverage is 27.27%.

❗ Current head 973608c differs from pull request most recent head 4c70502. Consider uploading reports for the commit 4c70502 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #812      +/-   ##
==========================================
+ Coverage   45.29%   45.40%   +0.11%     
==========================================
  Files          40       40              
  Lines        3663     3649      -14     
  Branches     1730     1723       -7     
==========================================
- Hits         1659     1657       -2     
+ Misses        821      810      -11     
+ Partials     1183     1182       -1
Flag Coverage Δ
unittests 45.40% <27.27%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...de/diff_drive_controller/diff_drive_controller.hpp 100.00% <ø> (ø)
...iff_drive_controller/src/diff_drive_controller.cpp 48.76% <27.27%> (+1.62%) ⬆️

destogl
destogl approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!!! 🎉🎉🎉

@bmagyar bmagyar merged commit 9d4ea6b into ros-controls:master Nov 7, 2023
11 of 13 checks passed
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Nov 19, 2023
@christophfroehlich
Merge branch 'master' into jtc/controller_plugin
3e78665 
Squashed commit of the following:

commit 0a9f4b0
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Thu Nov 16 23:17:20 2023 +0000

    Bump ros-tooling/action-ros-ci from 0.3.4 to 0.3.5 (ros-controls#833)

commit 3fc0f50
Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Date:   Wed Nov 15 20:03:40 2023 +0100

    [JTC] Activate update of dynamic parameters (ros-controls#761)

commit b13ae5b
Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Date:   Wed Nov 15 19:14:09 2023 +0100

    [JTC] Fix tests when state offset is used (ros-controls#797)

    * Simplify initialization of states
    * Rename read_state_from_hardware method
    * Don't set state_desired in on_activate
    ---------

    Co-authored-by: Dr. Denis <denis@stoglrobotics.de>

commit f1a5397
Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Date:   Wed Nov 15 12:18:38 2023 +0100

    [JTC] Remove deprecation warnings, set `allow_nonzero_velocity_at_trajectory_end` default false (ros-controls#834)

commit 232154d
Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Date:   Sat Nov 11 15:30:19 2023 +0100

    [CI] Update coverage workflows and some cleanup (ros-controls#819)

    * Add CI coverage jobs for humble and iron

    * Add all packages to source build

    * Update repos files

    * Build ros-control packages from source

    * use humble job names

    Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>

    ---------

    Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>

commit 0196eeb
Author: Tony Baltovski <tony.baltovski@gmail.com>
Date:   Thu Nov 9 17:15:45 2023 -0500

    [diff_drive_controller] Fixed typos in diff_drive_controller_parameter.yaml. (ros-controls#822)

commit 71ec842
Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Date:   Tue Nov 7 13:47:23 2023 +0100

    [CI] Re-add humble workflow files and add iron to readme (ros-controls#818)

commit 9d4ea6b
Author: Bence Magyar <bence.magyar.robotics@gmail.com>
Date:   Tue Nov 7 12:01:23 2023 +0000

    [diff_drive_controller] Remove non-stamped Twist option (ros-controls#812)

commit 5f78fe4
Author: Bence Magyar <bence.magyar.robotics@gmail.com>
Date:   Tue Nov 7 12:01:02 2023 +0000

    Adjust tests after passing URDF to controllers (ros-controls#817)

commit 2c6d7a6
Author: Bence Magyar <bence.magyar.robotics@gmail.com>
Date:   Mon Nov 6 18:29:10 2023 +0000

    Add iron branch (ros-controls#814)

commit f81a82c
Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Date:   Fri Nov 3 21:18:31 2023 +0100

    [CI] Codecov  (ros-controls#807)

commit c6ecab7
Author: Bence Magyar <bence.magyar.robotics@gmail.com>
Date:   Wed Nov 1 21:38:16 2023 +0000

    Use pre-commit fork of clang-format instead of local (ros-controls#813)

commit 6e46053
Author: Bence Magyar <bence.magyar.robotics@gmail.com>
Date:   Tue Oct 31 21:34:10 2023 +0000

    3.17.0

commit 822552f
Author: Bence Magyar <bence.magyar.robotics@gmail.com>
Date:   Tue Oct 31 21:33:40 2023 +0000

    Update changelogs

commit 8a90b51
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue Oct 31 20:27:04 2023 +0000

    Bump ros-tooling/action-ros-ci from 0.3.3 to 0.3.4 (ros-controls#810)

commit b65314d
Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Date:   Thu Oct 26 12:09:27 2023 +0200

    Cleanup comments and unnecessary checks (ros-controls#803)

commit b36b9d2
Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Date:   Tue Oct 24 20:17:28 2023 +0200

    [CI] Fix coverage build and codecov stats (ros-controls#804)

commit 22356e0
Author: Dr. Denis <denis@stoglrobotics.de>
Date:   Mon Oct 16 18:49:47 2023 +0200

    [TestNodes] Optimize output about setup of JTC publisher (ros-controls#792)

commit ac291ab
Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Date:   Mon Oct 16 13:00:53 2023 +0200

    Steering controllers library: fix open loop mode (ros-controls#793)

    * set last*velocity variables for open loop odometry

    * Make function arguments const

    * Update function in header file too

commit c831b6c
Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Date:   Mon Oct 16 12:58:44 2023 +0200

    Update requirements of state interfaces (ros-controls#798)
This was referenced Dec 28, 2023
Merged
Merged
@christophfroehlich christophfroehlich mentioned this pull request Jan 1, 2024
Merged
skpawar1305 added a commit to cyberbotics/webots_ros2 that referenced this pull request Feb 26, 2024
@skpawar1305
unstamped cmd_vel option is removed
99d9117 
ros-controls/ros2_controllers#812
@skpawar1305 skpawar1305 mentioned this pull request Feb 26, 2024
Merged
1 task
skpawar1305 added a commit to cyberbotics/webots_ros2 that referenced this pull request Feb 26, 2024
@skpawar1305
unstamped cmd_vel option is removed
4c99cc6 
ros-controls/ros2_controllers#812
skpawar1305 added a commit to cyberbotics/webots_ros2 that referenced this pull request Feb 26, 2024
@skpawar1305
unstamped cmd_vel option is removed
fe7905b 
ros-controls/ros2_controllers#812
skpawar1305 added a commit to cyberbotics/webots_ros2 that referenced this pull request Feb 26, 2024
@skpawar1305
unstamped cmd_vel option is removed
323b488 
ros-controls/ros2_controllers#812
skpawar1305 added a commit to cyberbotics/webots_ros2 that referenced this pull request Feb 26, 2024
@skpawar1305
unstamped cmd_vel option is removed
b1db544 
ros-controls/ros2_controllers#812
omichel pushed a commit to cyberbotics/webots_ros2 that referenced this pull request Feb 26, 2024
@skpawar1305
unstamped cmd_vel option is removed (#903)
7b0e501 
* unstamped cmd_vel option is removed

ros-controls/ros2_controllers#812

* enable stamped cmd_vel for nav2

ros-navigation/navigation2#4077

* don't enable twist stamped cmd_vel yet

as nav2 packages are not available for rolling
@christophfroehlich christophfroehlich mentioned this pull request Mar 23, 2024
Open
JafarAbdi pushed a commit to JafarAbdi/ros2_controllers that referenced this pull request Oct 6, 2024
@bmagyar @JafarAbdi
[diff_drive_controller] Remove non-stamped Twist option (ros-controls…
77864aa 
…#812)
@atinfinity atinfinity mentioned this pull request Oct 21, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@destogl destogl destogl approved these changes

@anfemosa anfemosa Awaiting requested review from anfemosa

@livanov93 livanov93 Awaiting requested review from livanov93

@mhubii mhubii Awaiting requested review from mhubii

@peterdavidfagan peterdavidfagan Awaiting requested review from peterdavidfagan

@rosterloh rosterloh Awaiting requested review from rosterloh

Assignees
No one assigned
Labels
hold Holding off merging this PR until some condition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmagyar @destogl