Skip to content

Commit

Permalink
Humble sync 6 June 9: 1.1.7 (#3616)
Browse files Browse the repository at this point in the history
* Option allowing to use simple lookupTransform API (#3412)

* Option allowing to use simple lookupTransform API
ignoring time shifts between source and base frame during the movement

* Refine comments

* Fix wrong warning message format (#3416)

* Fix wrong warning message format (Closes #3415)

* fix code formatting

* nav2_dwb_controller: add forward_prune_distance parameter (#3374)

Until now, the prune_distance was used as distance threshold to shorten
the upcoming path when shorten_transformed_plan was enabled. However,
the prune and shortening mechanisms are de-correlated mechanisms. One
could wish to use a different shortening distance for upcoming points,
than the prune distance used for passed points. For this reason, a new
parameter "forward_prune_distance" was added.

* Fix service_name for server_name in cancel assisted teleop node

* Fix mask coordinates calculation in worldToMask (#3418)

* Remove goal checker default from follow path node

* Correct CostmapFilters copyrights (#3423)

* Correct the parameter description for AMCL (#3451)

Signed-off-by: Trung Kien <letrungkien.k53.hut@gmail.com>

* Add default service name to BTServiceNode (#3448)

* Add default service name to BtServiceNode

* docstring

* fix initialization-list order

* Update nav2_behavior_tree/include/nav2_behavior_tree/bt_service_node.hpp

Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>

---------

Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>

* Fix Typos (#3452)

* removing galactic from table as EOL (#3460)

* Support for Dev Containers and Codespaces (#3457)

* Alias image tag over current branch name

* Duplicate build and push steps for dev tag

* Alias image tag over current branch name

* Modify build and push steps for dev tag

* Build and push dev tag first
to not cache from stale stages
as otherwise caching from multple regestry images seems error prone

* Revert "Build and push dev tag first"
as otherwise the build failer durring the dev tag
could then still block build of the main tag

This reverts commit 12dd5b1.

* Cache from multple reference images
while giving layers from the main tag priority
this assumes that cache-from prioritizes firstly listed references

https://github.com/moby/buildkit/blob/0ad8d61575be009ce6478edf1d85716849c8ff1a/solver/llbsolver/bridge.go#L92

* Cache tests in dev image as well
colcon cache can then skip tests for uneffected packages

* Add devcontainer.json

* Ignore doc for image builds

* Add more extensions

* Change workspaceFolder to root src path
to avoid auto generating .vscode folder in repo
created by ms-iot.vscode-ros extension
upon configuring ros packages with c_cpp_properties.json

* Enable features
for github-cli

* Add docs about codespaces
and have it opened when starting codespaces

* Update update_ci_image.yaml

to fix duplicate step ids
and add workflow file to push paths

* Patch CI actions and Dockerfiles (#3468)

* Unset default value for FAIL_ON_TEST_FAILURE
as unsetting it via --build-arg seems unreliable
docker/compose#3608

* Use build arg default for failing on test failers

* Update from deprecated set-output commands
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

* Use Codespaces prebuilds (#3470)

* Add commands to devcontainer

* Set builtin bash to be safe
https://gist.github.com/mohanpedala/1e2ff5661761d3abd0385e8223e16425
https://vaneyckt.io/posts/safer_bash_scripts_with_set_euxo_pipefail/

* Setup workspace on create

* Revert use of set -u for bash
don't raise error due to variables
otherwise colcon setup.sh chokes from using an unbounded path variable

* Add safe.directory for git config
otherwise colcon cache errors out because of issues with git
due to complex user mapping magic that vscode does with devcontainers

https://stackoverflow.com/questions/72978485/git-submodule-update-failed-with-fatal-detected-dubious-ownership-in-repositor

also used by Moveit2:
moveit/moveit2#1994

https://github.blog/2022-04-12-git-security-vulnerability-announced/

* Set env using remoteEnv
instead of inlining them in scripts

* Revert to using the main tag
now that the tester stage has been replicated
with the new devcontainer script commands instead

* formating

* Scrap `-dev` image tag
and use codspaces prebuilds instead

* Build incrementally from update content command
by copying the build workspace steps from circleci config

* Adapt the build workspace steps for bash

* Fix for different ceres isinf() API (#3471)

* Fixing name of security launch file

* Clean up pending service client request on interrupt/timeout (#3479)

Signed-off-by: Øystein Sture <os@skarvtech.com>

* Added str cast to parse int (#3486)

Co-authored-by: antoniomarangi <antonio.marangi@alba-robot.com>

* Add flag to not send request in BTServiceNode (#3431)

* Add flag to not send request in BTServiceNode

* rename goal to request

* Fail if should not send goal

* Update nav2_behavior_tree/include/nav2_behavior_tree/bt_service_node.hpp

Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>

* Update nav2_behavior_tree/include/nav2_behavior_tree/bt_service_node.hpp

Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>

* .

* fix linter

* fix CI

---------

Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>

* Prepare test results to only use junit/xunit schema (#3441)

* Set ctest arg to output junit

To try and help CircleCI to parse the output files
https://stackoverflow.com/a/70774733/2577586

* Replace the original Test.xml

by outputting the junit to the same filename
Context:
https://github.com/colcon/colcon-cmake/blob/8f1b92a190b2ad4289ecf837c3200d540c13fdd9/colcon_cmake/task/cmake/test.py#L133

* Fix default formatting to a list

WARNING:colcon.colcon_defaults.argument_parser.defaults:Default value 'ctest-args' for parser 'test' should be a list, not:  --output-junit Test.xml

* Revert junit file name
https://circleci.com/docs/collect-test-data/#ctest-for-c-cxx-tests

* Fine and rename ctest summary Test.xml

* Fix find path

* Simplify extention renaming

* Copy ctest junit file into test_results
so that they can be stored by CI

* Revert ctest config modifications

* Prepare Test Results by removing Test.xml
generated by ctest
to simplify fix for circleci

* Reorder storage of test result artifacts
before Test.xml files are removed
so that they can still be archived and viewed for later

* Use find command

* Container retention via version tagging (#3491)

* Use github action expression syntax
to alias over github repository name

* Tag by version instead of by timestamp

* Avoid pushing untagged image to GHCR
by setting provenance to false
now that provenance is enabled by default
as of v4 of docker/build-push-action

- docker/build-push-action#781
- docker/build-push-action#778

* Use checkout action to set version output (#3492)

Otherwise there is no source code to use to set the version output.
Fixes: #3491

* Change directory to inside checked out repo (#3493)

or relative path under $GITHUB_WORKSPACE
that actions/checkout places the repository

* Write and read from correct output mapping (#3494)

* Revert "Change directory to inside checked out repo (#3493)"

This reverts commit 332c1fb.

* Add `version` to outputs for check step
and use output from `check` id

* Use output from check_ci_files job

* updating world in simple commander for TB3 package change (#3495)

* Ensure version output is always set (#3503)

even when github.event_name != 'push'
by moving run step to same job as build-push action.

Also set context path provided by checkout action
to avoid future nonintuitive behavoir using default Git context,
even when the checkout action appears to be being used.

- https://github.com/docker/build-push-action#git-context
- https://github.com/docker/build-push-action#path-context

* Add labels to pushed image versions (#3505)

using Pre-Defined Annotation Keys
as defined by The OpenContainers Annotations Spec

- https://specs.opencontainers.org/image-spec/annotations/#pre-defined-annotation-keys
- https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows
- https://docs.github.com/en/rest/repos/repos?apiVersion=2022-11-28#get-a-repository

* Typo README.md (#3506)

* [Velocity smoother] Set zeros command if timeout (#3512)

* Set zeros command if timeout

* Fix lint

* Fix gtest 

increase time to allow deceleration

* Always update last_cmd_

* Revert test modif

* remove test logs

* Fix paste error

* Update velocity_smoother.cpp

* Update velocity_smoother.cpp

* Improve Dev Container ergonomics (#3482)

* Install and enable bash autocompletion
by using apt durring on create command
and by copying skelton .bashrc file that sources it by default

* Edit apt for autocomplete
by disabling docker-clean from containerized ubuntu

* Add ROS2 Ament Task Provider extension
Provides tasks and problem matchers for ROS2 projects using ament

https://marketplace.visualstudio.com/items?itemName=althack.ament-task-provider

* Source underlay for extentions
to allow them to find the path to ros binaries
such as ament_cpplint needed for althack.ament-task-provider

* Target new dever stage in Dockerfile

* Reduce need for internet after image build
by installing developer dependencies earlier

* Edit apt caching before apt updating

* Source underlay systemwide
this is a hacky workarround
to ensure VS Code can run ShellExecution tasks
with the ros envorment included in PATH

otherwise, postponing this to the on-create-command
results in vscode extentions not finding system installed ros commands

this also works for all user shells
regardless of how devontainers could change the user

* Postpone bashrc setup to postCreateCommand
once the dev container has been assigned to a user for the first time

* Cleanup onCreateCommand
as we don't use ros_entrypoint.sh for development
and so it doesn't really need to be updated

* Quite down the logs when building devcontainer

* Formatting

* Add refrence ccp properties config file
generated from the vscode ROS extention
but with the hardcoded paths in includePath deleted

* Update version of cppStandard for ROS Rolling

* Update workspaceFolder to use new .vscode folder

* Mount ccache directory to volume
to speed up rebuilding devcontainer
whenever onCreateCommand is triggered
because of modifications to .devcontainer/ files

* Avoid use of containerEnv to express ccache direcotry
as doing so is not possable, for more info:
- https://stackoverflow.com/a/75759647/2577586
- microsoft/vscode-remote-release#7147 (comment)

Just target a path in the temp direcotry instead

* Stage auto generated includePath

* Remove workspace install from include path
except for autogenerated headers from message packages

* Avoid hardcoded path to sorce folder

* Avoid hardcoded path to install folder
but this is still rather fragile
as the reletive path
between workspaceFolder and the colcon workspace isn't fixed

* Sort list of paths

* Remove cpp properties configuration
as it seems it's existance prevents autoupdating the includePaths property
unless user manually runs the vscode command `>ROS:Update C++ Properties`

https://github.com/ms-iot/vscode-ros/blob/47d8f14f4ec0498cd9e8381e6fcc5f47abb340f2/src/extension.ts#L71

and even when this command is invoked
it blows aways any customizated properties anyhow

issue about wrong cppStandard tracked here:
ms-iot/vscode-ros#818

* Fix typo
to move docker-clean from loaded config path

* fix data race: addFilter() and resizeMap() can be executed concurrently (#3518)

Co-authored-by: Dirk Braunschweiger <dirk.braunschweiger@symovo.de>

* fix data race: prohibit resizeMap() during plugin/filter initialization (#3522)

Co-authored-by: Dirk Braunschweiger <dirk.braunschweiger@symovo.de>

* Mount overlay workspace into Dev Container via volume (#3524)

* Add volume for overlay
to avoid rebuilding it from scratch
whenever the dev container is rebuilt
this saves startup time locally when fiddling with the configs

* Append devcontainerId to volume name
to avoid conflicts with other devcontainers
note that devcontainerId is stable across rebuilds
- https://containers.dev/implementors/json_reference/#variables-in-devcontainerjson

* Call updateContentCommand from onCreateCommand
to deduplicate scripts and keep setup DRY
given the addition of a mounted overlay volume
which could include a prebuilt colcon workspace
well before the dev container is created/rebuilt

* Comment out colcon clean from setup
to avoid unintentional removal of built packages
from the persistent overlay workspace volume.
Users can uncomment the line locally
or simply remove the overlay workspace volume
if they want to rebuild packages from scratch.

* Format json

* Add headless and use_rviz LaunchConfigurations to demo launch files (#3527)

* Add headless and use_rviz LaunchConfigurations
in nav2_simple_commander demo launch files
for whether to start rviz or gzclient
to simplify their use in headless environments

* Fix headless logic to match tb3_simulation_launch.py
for launch arg consistency

* Fix State-Lattice planner crashes due to FP precision loss (#3531)

* Fix State-Lattice planner crashes due to FP precision loss

* Move testcase comment

* Add PoseProgressChecker (#3530)

* add rotation progress checker

* clean include

* add stopped goal checker reset test

* add rotation progress checker tests

* uncrustify

* better name: PoseProgressChecker instead of RotationProgressChecker

* camelCase

* uncrustify

* rename in tests

* more rename

* simplify parentheses

* faster and better tests

---------

Co-authored-by: Guillaume Doisy <guillaume@dexory.com>

* [velocity_smoother] Fix accel and deccel inverted for negative speeds (#3529)

* fix inverted accel / deccel

* handle speed through 0.0

* add applyConstraints tests

* fold logic

* same logic in findEtaConstraint

* lint

* Update nav2_velocity_smoother/src/velocity_smoother.cpp

* Update nav2_velocity_smoother/src/velocity_smoother.cpp

* findEtaConstraint tests

* space

* lint

* typos

* comment typos

---------

Co-authored-by: Guillaume Doisy <guillaume@dexory.com>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>

* Enable Visualizations for Dev Container (#3523)

* Add visualizer stage
to install demo dependencies

* Install foxglove

* Install gzweb

* Add hack for resolvable mesh URIs
located by the aws SDL model files
- aws-robotics/aws-robomaker-small-warehouse-world#24

* Revert hack and use fork
that fixes issues with deploy.sh
- osrf/gzweb#248

* Update target stage to visualizer

* Comment out gzclient and rviz for debugging

* Add hack for resolvable mesh URIs
as migrating the python3 scripts still hasn't resolved the issue

* Reorder stages for readability
by keeping sequential builder and tester stages adjacent
while keeping tester stage the default exported target

* fix typo

* Install gdb for launching ros launch files
using the ROS VS Code extension
- ms-iot/vscode-ros#588

* Add vscode tasks file

* Add Start Gzweb task

* Add Start Foxglove tasks
for bridge and studio

* Add Start Foxglove compound task
using dependsOn

* Set default problemMatcher to empty
to avoid nagging the user to select one
as currently none really support our use case

* Source overlay before running foxglove_bridge
to ensure nav2 message types are defined
by inlining all args into command
and sourcing workspace setup

* Formatting

* Generalize and simplify hack

* Generalize gazebo model discovery

* Patch gzserver to run headless using xvfb
to avoid host/platform specific x11 quirks
exposed by vscode automatic x11 forwarding

This is needed to provide gazebo a virtual frame buffer
as it still need one after all these years.
This also avoids the need modifying launch files to call xvfb-run

- microsoft/vscode-remote-release#8031
- gazebosim/gazebo-classic#1602

* Set isBackground for start tasks

* Add stop tasks

* Add restart foxglove task

* Switch to shell for commanding pkill
to gracefully return 0 when process is not running
allowing sequence of dependsOn tasks to run
such as for the restart tasks

* Add icons to tasks
for readability

* Add restart gzweb task

* Add global start, stop, and restart tasks
for all background visualization tasks

* Formatting

* Hide tasks users need not run manually
to avoid cluttering up the run task quick pick

* Shorten label for background tasks
so they succinctly show from the running task list

* Show global start and stop visualizations tasks
as they may be too helpful to hide

* Revert "Comment out gzclient and rviz for debugging"

This reverts commit 0addae2.

* Add --ipc=host to runArgs
to enable shared memory transport
- https://community.rti.com/kb/communicate-between-two-docker-containers-using-rti-connext-dds-and-shared-memory

* Add --pid=host to runArgs
to simplify discovery
- https://community.rti.com/kb/communicate-between-two-docker-containers-using-rti-connext-dds-and-shared-memory

* Add to runArgs
to simplify debugging
- https://code.visualstudio.com/docs/devcontainers/create-dev-container#_use-docker-compose

* Add comments

* Comment out runArgs unintended side effects
or cross talk between containers by default
also avoids interfering with vscode's X11 forwarding

* [nav2_planner] Fix costmap thread reset on cleanup (#3548)

* remove costmap thread reset on cleanup

* Init costmap thread in on_configure method

* Move costmap_thread init in on_configure method

* Add IsBatteryChargingCondition (#3553)

* Add IsBatteryChargingCondition

* Minor fixes in battery charging and add testing

* Fix format

* Added isBatteryChargingCondition BT node to params

* Impl noise filtering layer in the costmap_2d (#2567)

Signed-off-by: ryzhikovas <ryzhikovas@gmail.com>

* Improve Dev Container Web App Visualization (#3551)

* Add Caddyfile to reverse proxy websockets
in an attempt to avoid authentication tokens in headers
when forwarding ports from codespaces via web interface

- https://docs.github.com/en/codespaces/developing-in-codespaces/forwarding-ports-in-your-codespace#using-command-line-tools-and-rest-clients-to-access-ports
- https://caddyserver.com/docs/quick-starts/reverse-proxy
- https://caddy.community/t/caddy-v2-how-to-proxy-websoket-v2ray-websocket-tls/7040/13

* Update caddy related tasks

* Rename Gzweb task to Gzweb Bridge
to make room for more gzweb tasks

* Add Gzweb Client Task

* Add Caddyfile to reverse proxy websockets
now for Gzweb

* Specify config file to avoid crosstalk
between caddy stop commands

* Fix reverse proxy for websockets
by correcting matcher using headers
as websocket request header value is lowercase for gzweb and foxglove

* Comment out log output files for debugging

* Simplify tasks by removing client tasks

* Stop tasks by using terminate
via the workbench.action.tasks.terminate command

* Move Caddyfile

* Add Web Server tasks

* Move Caddyfile

* Update log output file path

* Update root path

* Update reverse_proxy for both gzweb and foxglove
by using the path argument for respective matchers

- https://caddyserver.com/docs/caddyfile/matchers#path-matchers

* Use snippets
to keep Caddyfile DRY
- https://caddyserver.com/docs/caddyfile/concepts#snippets

* Use rewrite to catch trailing slash
as file_server defaults do not correct reverse_proxy.
This make typing the websocket URL more forgiving

- https://caddyserver.com/docs/caddyfile/patterns#trailing-slashes

* Improve websocket snippet
to keep Caddyfile DRY

* Use header_regexp for case-insensitive matching
given web port forwarding from Codespaces is odd
and rewrites the value of this header field to lowercases
even when local browser request is sent as `Upgrade`

* Add helper index page to web server
to link to web apps for reverse proxy

* Limit templates to fix gzweb
by adding matcher for only root index
otherwise gzweb's own index.html gets overwritten

* Add comments to Cadyfile
to document tricky configuration

* Stage working redirect

* Simplify index.html

* Add helper redirect to simplify foxglove
to set the respective queries values to automate websocket setup,
and ensure the websocket schema matches the https request

* Avoid hardcoding port number

* Clean up comments

* Use header to compute redirect
to take into account requesting forwarding
or more codespace port forwarding shenanigans

* Use shorthand placeholders
- https://caddyserver.com/docs/caddyfile/concepts#placeholders

* Formatting

* Keep trailing slash
to stay consistent with caddy file_server directive
that serves a 308 Permanent Redirect
for both foxglove and gzweb paths anyway

* Refactor matcher logic
to account for requests either from
host ports from local dev containers
or forwarded requests from codespace web port forwarding

* Split snippet into globals
for composability

* Update comments

* Add Placeholders
for debugging

* Use tables to center

* Use github markdown
- https://github.com/sindresorhus/github-markdown-css

* Simplify vars

* Rename vars

* Revert "Rename vars"
as dotted var names do not work in Caddyfile

This reverts commit 3e2d1b3.

* Add System Monitor
to debug CPU load and memory issues

* Update headings

* Update layout

* Update layout

* Add Foxglove layout for Nav2

* Symlink assets folder for web server

* Fetch Foxglove layout using layoutUrl
a new parameter to load layout json data from URL
- https://github.com/orgs/foxglove/discussions/217

* Cleanup

* Use fork to fetch Foxglove layout using layoutUrl
until this PR is merged:
- https://github.com/foxglove/studio/pull/5987

* Update Caddyfile to handle relative root
by using local srv folder

* Inject mobile view html tags
using the caddy replace module
- https://caddyserver.com/docs/modules/http.handlers.replace_response
- https://github.com/caddyserver/replace-response

* Simplify Caddyfile

* Use snippet for apps

* Simplify Caddyfile

* Simplify Caddyfile

* Build caddy using custom modules

* Remove unused symlinks

* Add comments

* Use environment and defined variables for config
to avoid hard coded paths

* Add FoxgloveUrl to vars
for reuse in templates

* Fix trailing slash for DataSourceUrl

* Use exec to run gzserver with xvfb
to prevent ros launch from orphaning process
and ensure gzserver receives SIGTERM signal
given gzserver often hangs after only SIGINT
- https://unix.stackexchange.com/a/196053/213124

* Update redirect for foxglove
to redirect from path /foxglove/autolayout

* Add redirect for foxglove
to redirect from path /foxglove/autoconnect
but does not use LayoutUrl
as to not change from cached layout

* Use web app manifest
to set display as standalone
- https://web.dev/add-manifest/
- https://developer.mozilla.org/en-US/docs/Web/Manifest

* Template manifest files
to embed host info into app name

* Add manifests for other web apps

* Add shortcuts for Foxglove
- https://developer.mozilla.org/en-US/docs/Web/Manifest/shortcuts
- https://web.dev/app-shortcuts/

* Format

* Update comments

* Revert use of fork

* Remove debug directive

* Improve usability of PWAs in Dev Containers (#3576)

* Add WIP icons

* Add WIP icons for gzweb

* Add WIP icons for glances

* Set cross origin to use credentials
ensuring auth cookie is included in request header
when requesting for web app manifest file
thus avoiding CORS policy violations in browser
when accessing forwarded codespaces ports from the web

> The request for the manifest is made without credentials (even if it's on the same domain), thus if the manifest requires credentials, you must include `crossorigin="use-credentials"` in the manifest tag.

- https://web.dev/add-manifest/
- https://stackoverflow.com/a/57184506/2577586

* Use ReqHost variable in templates
to account for X-Forwarded-Host value in header

* Delete duplicate manifest

* Set id property in app manifests
so we can address them independently from their start_url
- https://developer.chrome.com/blog/pwa-manifest-id/

* Ensure apps are uniquely identifies
by adding trailing slash to id
and thus different URI directories

* Refactor root landing page into nav2 app
by moving page file into nav2 sub folder
adding root redirect pointing to /nav2/
and updating html, markdown, manifest files respectively

* Fix https detection for Caddy reverse proxies
by also checking X-Forwarded-Proto in request header

* Remove unnecessary files

* Prune smaller images

* Prune duplicate icon

* Clean up html tags

* Update manifest icons

* Rename icons

* Revert "Prune duplicate icon"

This reverts commit 5710401.

* Add back favicon for shortcut

* Add self index for completeness and bookmarking

* Simplify icon linking

* Delete binary files

* Fix hyperlink path

* Include image files using gitattributes
to track these binary files via git LFS

* Add icons using git lfs

* Standardized all icon paths

* Use external links for icons
to avoid the need for using git LFS
although this is a bit of a hack

* Stage any and maskable icons

* Use any and masked icons

* Set colors to match maskable icon colors

* Update icon

* Use lossless compression
without removing background
- https://shortpixel.com/online-image-compression

* Use WebP instead of PNG
for smaller file sizes
- https://en.wikipedia.org/wiki/WebP

* Move icons into icons folder

* Use _SRV environment variables for service paths

* Download media files from github
during docker image build
to avoid adding always online dependencies
when creating or starting dev containers

* Delete media icons from git repo
now that we download media from anonymized URLs on github
- https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/attaching-files

* Add comments

* Enable file browsing for non app paths
for remote debugging of media and asset files

* Consolidate assets into single folder

* Add links for file browser paths
to Server Diagnostics

* Delete unused symlink

* Update landing page to match manifest
by including same shortcuts and start url

* Patch gzweb to disable modelList
avoiding 404s for thumbnails
as they are hardcoded into js

* Update comments

* Simplify Caddyfile by reverting to symlinking
but add ROOT_SRV env for custom overriding

* Loop over nav2 srv folders when symlinking
to generalize over folder names

* Add matcher for file browsing root directory
while still redirecting to nav2 app by default

* Use placeholders for root variable
to consolidate env default fallback settings
e.g `:/srv`

* Promote file browser in Nav2 app shortcuts

* Fix and update SRV envs

* Postpone symlinking for Nav2 web app
to when post-create-command script then runs
given full repo is not copied into builder stage in Dockerfile.
While this could be postponed to update-content-command
leaving it here avoids blowing user changes
after the container has been created or modified.

* Add guard to check if srv folder exists

* Add refresh rate shortcuts to glances

* Add file browser shortcut to nav2

* Set scope for nav2 PWA to root
to allow for opening child apps inside nav2 app

* Display child apps in fullscreen mode by default
as users can still open them in standalone via nav2 app
given the nav2 app's scope is the parent root path

* Update shortcuts and landing page

* Document PWA scope and installation order
when using Nav2 PWA scoped as root

* Revert setting scope for nav2 PWA to root path
as adding file browser shortcut to nav2 PWA is not worth the trouble
of having to explain installation order caveats and URL launch behavior.
File browser shortcut is still accessible from inside nav2 pwa launcher
but merely displays in browser preview
given root / is out of scope for /nav2/

* Update server diagnostics for troubleshooting

* Verify checksum of archive before extraction
incase anonymized URL changes expected archive

* Fix the condition in ackerman motion model constraints (#3581)

* Fix the condition in ackerman motion model constraints

* Fix ackerman motion model tests

* Fix another ackerman motion model test

* Fix broken symlink for gzweb (#3585)

to load world models

* Fix broken link to contributing guidelines (#3587)

The original URL (https://navigation.ros.org/contribute/index.html) seems not to exist, returning an HTTP 404. Hence, I've replaced the link with a page that seems most relevant.

* Adding Our Sponsors - May 2023 (#3593)

* adding our sponsors - may 2023

* adding blurb

* adding links

* adding links

* adding links

* adding Open Nav

* Add CostmapFilterInfoServer as a component (#3596)

* Resolve #3532: reset i (#3597)

* [MPPI] empty path_follow_critic proper fix (#3599)

* [MPPI] empty path_follow_critic proper fix

* fix linting issue

---------

Co-authored-by: Guillaume Doisy <guillaume@dexory.com>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>

* bumping humble to 1.1.7 for release

---------

Signed-off-by: Trung Kien <letrungkien.k53.hut@gmail.com>
Signed-off-by: Øystein Sture <os@skarvtech.com>
Signed-off-by: ryzhikovas <ryzhikovas@gmail.com>
Co-authored-by: Alexey Merzlyakov <60094858+AlexeyMerzlyakov@users.noreply.github.com>
Co-authored-by: Jose Luis Blanco-Claraco <joseluisblancoc@gmail.com>
Co-authored-by: DylanDeCoeyer-Quimesis <102609575+DylanDeCoeyer-Quimesis@users.noreply.github.com>
Co-authored-by: Trung Kien <letrungkien.k53.hut@gmail.com>
Co-authored-by: HovorunB <87417416+HovorunB@users.noreply.github.com>
Co-authored-by: Tony Najjar <tony.najjar@logivations.com>
Co-authored-by: Ruffin <roxfoxpox@gmail.com>
Co-authored-by: Øystein Sture <oysstu@users.noreply.github.com>
Co-authored-by: mrmara <48493979+mrmara@users.noreply.github.com>
Co-authored-by: antoniomarangi <antonio.marangi@alba-robot.com>
Co-authored-by: Tony Najjar <tony.najjar.1997@gmail.com>
Co-authored-by: Griswald Brooks <griswald.brooks@gmail.com>
Co-authored-by: BriceRenaudeau <48433002+BriceRenaudeau@users.noreply.github.com>
Co-authored-by: Dirk Braunschweiger <1677757+dirkmb@users.noreply.github.com>
Co-authored-by: Dirk Braunschweiger <dirk.braunschweiger@symovo.de>
Co-authored-by: Guillaume Doisy <doisyg@users.noreply.github.com>
Co-authored-by: Guillaume Doisy <guillaume@dexory.com>
Co-authored-by: Alberto Tudela <ajtudela@gmail.com>
Co-authored-by: ryzhikovas <ryzhikovas@gmail.com>
Co-authored-by: Alexandr Buyval <alexbuyval@gmail.com>
Co-authored-by: Hyung-Taik Choi <htc.refactor@gmail.com>
Co-authored-by: Filipe Cerveira <filipecerveira@gmail.com>
  • Loading branch information
23 people authored Jun 9, 2023
1 parent e5394ae commit b7e0686
Show file tree
Hide file tree
Showing 147 changed files with 7,112 additions and 314 deletions.
9 changes: 7 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -301,10 +301,15 @@ _commands:
when: always
- store_artifacts:
path: << parameters.workspace >>/log/test
- store_test_results:
path: << parameters.workspace >>/test_results
- store_artifacts:
path: << parameters.workspace >>/test_results
- run:
name: Prepare Test Results
working_directory: << parameters.workspace >>
command: find test_results -name "Test.xml" -type f -delete
when: always
- store_test_results:
path: << parameters.workspace >>/test_results

_steps:
pre_checkout: &pre_checkout
Expand Down
132 changes: 132 additions & 0 deletions .devcontainer/caddy/Caddyfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,132 @@
# Snippet for global matchers and variables
# to logically expression request conditions
# E.g. for conditionally changing redirects
(globals) {
# Use gzip compression for all responses
encode gzip

# Matcher for http request scheme. E.g. "http" or "https"
@http_scheme {
expression {http.request.scheme}=="https" || {header.X-Forwarded-Scheme}=="https" || {header.X-Forwarded-Proto}=="https"
}
# If any http scheme is "https", then use "wss"
vars @http_scheme WsScheme "wss"
# Else default to "ws"
vars WsScheme "ws"

# Matcher for forwarded request headers
@host_forwarded {
header X-Forwarded-Host *
}
# If http headers exists, then use them
vars @host_forwarded ReqHost {header.X-Forwarded-Host}
# Else default to host in request
vars ReqHost {http.request.hostport}

# Matcher for websocket connection upgrade requests
@websockets {
# Avoid case sensitivity issues when matching field values
# E.g. when values are rewritten by Codespace port forwarding
header_regexp Connection (?i)(Upgrade)
header Upgrade websocket
}
}

# Snippet for redirect with given URL queries values
# to simplify remote development with web apps
# E.g auto redirect websocket URL to match request scheme
(redirect) {
# Configure redirect to match request scheme
vars LayoutUrl "/assets/foxglove/nav2_layout.json"
vars DataSourceUrl "{vars.WsScheme}://{vars.ReqHost}{args.0}/"
redir /autoconnect "{args.0}/?ds=foxglove-websocket&ds.url={vars.DataSourceUrl}"
redir /autolayout "{args.0}/?ds=foxglove-websocket&ds.url={vars.DataSourceUrl}&layoutUrl={vars.LayoutUrl}"
}

# Snippet for dummy imports
(dummy) {
}

# Snippet for enabling mobile web app features
# to improve user experience on small screen devices
# E.g. for enabling fullscreen mode on iOS and Android
(mobile) {
# Match for directory redirects to index.html
route / {
# Inject link to manifest just after <head> tag
# https://developer.mozilla.org/docs/Web/Manifest
replace `<head>` `<head><link rel="manifest" href="manifest.json" crossorigin="use-credentials"/>`
}
# Redirect relative handle_path'ed manifest.json to /manifests directory
redir /manifest.json /assets{http.request.orig_uri.path.dir}manifest.json
}

# Snippet for hosted web app using websockets
# to serve static files and reverse proxying connections
# E.g. for serving GzWeb and Foxglove web apps
(app) {
# handle and strip path prefix from redirect
handle_path {args.0}/* {
# Set root directory for static files
root * {http.vars.root}{args.0}
# Enable mobile web app features
import mobile
# Reverse proxy websockets to backend address
reverse_proxy @websockets {args.1}
# Import custom snippets
import {args.2} {args.0}
}
}

# Listen for http requests on port 8080
# regardless of hostname or domain address
# E.g. whatever Codespaces assigns to host
:8080 {
# Include global matchers and variables
import globals
root * {$ROOT_SRV:/srv}
file_server browse

# Handle root content
# I.e. assets internal to workspace
handle /* {
# Template manifest.json files
templates */manifest.json {
mime application/json
}
}

# Handle nav2 web app
# I.e. main landing page
handle_path /nav2/* {
root * {http.vars.root}/nav2
import mobile
# Render markdown files as html
templates
}

# Matcher for requests without browse query
@no_browse {
path /
not query browse=true
}
# Redirect to nav2 web app by default
redir @no_browse /nav2/

# Import app snippets for web apps
import app "/gzweb" "localhost:9090" "dummy"
import app "/foxglove" "localhost:8765" "redirect"

# Handle glances web app
redir /glances /glances/
handle_path /glances/* {
import mobile
# Reverse proxy to glances backend
reverse_proxy * "localhost:61208"
}

# For debugging
# log {
# output file /var/log/caddy/server.log
# }
}
40 changes: 40 additions & 0 deletions .devcontainer/caddy/srv/assets/foxglove/manifest.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
{
"name": "Foxglove: {{placeholder "http.vars.ReqHost"}}",
"short_name": "Foxglove: {{placeholder "http.vars.ReqHost"}}",
"icons": [
{
"src": "/media/icons/foxglove/any_icon_x512.webp",
"sizes": "512x512",
"type": "image/webp",
"purpose": "any"
},
{
"src": "/media/icons/foxglove/maskable_icon_x512.webp",
"sizes": "512x512",
"type": "image/webp",
"purpose": "maskable"
}
],
"id": "/foxglove/",
"start_url": "/foxglove/autoconnect",
"theme_color": "#6F3BE8",
"background_color": "#6F3BE8",
"display": "fullscreen",
"shortcuts" : [
{
"name": "Auto Connect",
"url": "/foxglove/autoconnect",
"description": "Auto connect to default data source"
},
{
"name": "Auto Layout",
"url": "/foxglove/autolayout",
"description": "Auto connect using default layout"
},
{
"name": "Manual Connect",
"url": "/foxglove/",
"description": "Manually connect to data source"
}
]
}
Loading

0 comments on commit b7e0686

Please sign in to comment.