Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'angles' dependency to nav2_costmap_2d package.xml #1947

Merged
merged 1 commit into from
Aug 17, 2020

Conversation

naiveHobo
Copy link
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses None
Primary OS tested on Ubuntu 18.04

Description of contribution in a few bullet points

  • Added 'angles' as dependency in nav2_costmap_2d package.xml to fix failing foxy debian builds

Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn those build farm changes. Thanks, I have 0 idea how I missed that this was failing.

@SteveMacenski SteveMacenski merged commit d616e49 into ros-navigation:main Aug 17, 2020
@naiveHobo naiveHobo deleted the costmap-foxy branch August 17, 2020 19:57
@jacobperron
Copy link
Contributor

@SteveMacenski Foxy builds have been failing since August 11th: http://build.ros2.org/view/Fbin_uF64/job/Fbin_uF64__nav2_costmap_2d__ubuntu_focal_amd64__binary/

It would be good to get this patch released for Foxy to fix the regression. I'd like to do a Foxy sync this week.

@SteveMacenski
Copy link
Member

I've been waiting until the notice of a Foxy sync to get as much stuff in the new sync as possible. Did you announce the pending sync? I must have missed it.

@jacobperron
Copy link
Contributor

I'm about to announce it, just checking on the regression status and noticed this one.

SteveMacenski added a commit that referenced this pull request Aug 24, 2020
* waypoint_follower node has _rclcpp_node as well as base node (#1940)

* Add #include <vector> for vector<> (#1946)

To fix cpplint

* Add 'angles' dependency to nav2_costmap_2d package.xml (#1947)

* transform goal to costmap frame (#1949)

The plan recieved is usually in global frame, but
our local costmap is often in odom frame. This
fixes a regression from #1857

* Add mutex lock into inflation layer to avoid thread issue in updating footprint (#1952)

Signed-off-by: Daisuke Sato <daisukes@cmu.edu>

* Fix being unable to change StandardTrajectoryGenerator parameter vtheta_samples (#1619)

* Fix tests declaring parameters real nodes don't

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>

* Fix loadParameterWithDeprecation not getting initial parameter values

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>

* Create sim_time variable before using it

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>

* Line length < 100

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>

* Add missing {

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>

* Linter fixes

Signed-off-by: Shane Loretz <sloretz@openrobotics.org>

* sim_granularity -> time_granularity

Signed-off-by: Shane Loretz <sloretz@openrobotics.org>

* Linter fix

Signed-off-by: Shane Loretz <sloretz@openrobotics.org>

* update version to 0.4.3

* removing redundant dep on angles

Co-authored-by: Ruffin <roxfoxpox@gmail.com>
Co-authored-by: Sarthak Mittal <sarthakmittal2608@gmail.com>
Co-authored-by: Michael Ferguson <mfergs7@gmail.com>
Co-authored-by: Daisuke Sato <43101027+daisukes@users.noreply.github.com>
Co-authored-by: Shane Loretz <sloretz@openrobotics.org>
ruffsl pushed a commit to ruffsl/navigation2 that referenced this pull request Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants