Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add duration parameter to the cantransform call in updateCostmap in r… #3053

Closed
wants to merge 1 commit into from
Closed

Add duration parameter to the cantransform call in updateCostmap in r… #3053

wants to merge 1 commit into from

Conversation

arslogavitabrevis
Copy link

Range_sensor_layer

Basic Info

Info
Ticket this addresses 2975
Primary OS tested on Ubuntu 20.04

Description of contribution in a few bullet points

  • Added a tolerance for the canTransform call in range_sensor_layer. The transformation tolerance value is receivend form the parameter transform_tolerance that was already declared.

For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@mergify
Copy link
Contributor

mergify bot commented Jun 29, 2022

@arslogavitabrevis, all pull requests must be targeted towards the main development branch.
Once merged into main, it is possible to backport to @galactic, but it must be in main
to have these changes reflected into new distributions.

@mergify
Copy link
Contributor

mergify bot commented Jun 29, 2022

@arslogavitabrevis, please properly fill in PR template in the future. @SteveMacenski, use this instead.

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@arslogavitabrevis arslogavitabrevis changed the base branch from galactic to main June 29, 2022 17:19
@arslogavitabrevis arslogavitabrevis changed the base branch from main to galactic June 29, 2022 17:19
@arslogavitabrevis arslogavitabrevis mentioned this pull request Jun 29, 2022
Closed
SteveMacenski
SteveMacenski reviewed Jun 29, 2022
View reviewed changes
Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM beyond the galactic base

nav2_costmap_2d/plugins/range_sensor_layer.cpp
@@ -292,8 +292,11 @@ void RangeSensorLayer::updateCostmap(
in.header.stamp = range_message.header.stamp;
in.header.frame_id = range_message.header.frame_id;

std::string * errstr = NULL;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to include that error string in the RCLCPP INFO when it fails to give more context, if you're going to collect it!

@SteveMacenski SteveMacenski changed the base branch from galactic to main June 30, 2022 21:32
@SteveMacenski SteveMacenski changed the base branch from main to galactic June 30, 2022 21:32
@SteveMacenski
Copy link
Member

@arslogavitabrevis any update?

SteveMacenski added a commit that referenced this pull request Jul 7, 2022
@SteveMacenski
forward porting #3053
3f2dbf0
@SteveMacenski SteveMacenski mentioned this pull request Jul 7, 2022
Merged
@SteveMacenski
Copy link
Member

#3064 to complete

SteveMacenski added a commit that referenced this pull request Jul 11, 2022
@SteveMacenski
forward porting #3053 (#3064)
bb0d177 
* forward porting #3053

* adding TF warning suggestion
mergify bot pushed a commit that referenced this pull request Jul 11, 2022
@SteveMacenski @mergify
forward porting #3053 (#3064)
bc42a83 
* forward porting #3053

* adding TF warning suggestion

(cherry picked from commit bb0d177)
mergify bot pushed a commit that referenced this pull request Jul 11, 2022
@SteveMacenski @mergify
forward porting #3053 (#3064)
5fd66ea 
* forward porting #3053

* adding TF warning suggestion

(cherry picked from commit bb0d177)
SteveMacenski added a commit that referenced this pull request Jul 11, 2022
@mergify @SteveMacenski
forward porting #3053 (#3064) (#3070)
6a9508b 
* forward porting #3053

* adding TF warning suggestion

(cherry picked from commit bb0d177)

Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
SteveMacenski added a commit that referenced this pull request Jul 11, 2022
@mergify @SteveMacenski
forward porting #3053 (#3064) (#3069)
91883ce 
* forward porting #3053

* adding TF warning suggestion

(cherry picked from commit bb0d177)

Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
hodgespodge pushed a commit to RobotCodeLab/navigation2 that referenced this pull request Sep 12, 2022
@mergify @SteveMacenski @hodgespodge
forward porting ros-navigation#3053 (ros-navigation#3064) (ros-naviga…
83d592a 
…tion#3070)

* forward porting ros-navigation#3053

* adding TF warning suggestion

(cherry picked from commit bb0d177)

Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
jwallace42 pushed a commit to jwallace42/navigation2 that referenced this pull request Dec 14, 2022
@SteveMacenski
forward porting ros-navigation#3053 (ros-navigation#3064)
84cd1d8 
* forward porting ros-navigation#3053

* adding TF warning suggestion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveMacenski SteveMacenski SteveMacenski left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arslogavitabrevis @SteveMacenski