-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add duration parameter to the cantransform call in updateCostmap in r… #3053
Add duration parameter to the cantransform call in updateCostmap in r… #3053
Conversation
…ange_sensor_layer
@arslogavitabrevis, all pull requests must be targeted towards the |
@arslogavitabrevis, please properly fill in PR template in the future. @SteveMacenski, use this instead.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM beyond the galactic base
@@ -292,8 +292,11 @@ void RangeSensorLayer::updateCostmap( | |||
in.header.stamp = range_message.header.stamp; | |||
in.header.frame_id = range_message.header.frame_id; | |||
|
|||
std::string * errstr = NULL; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to include that error string in the RCLCPP INFO when it fails to give more context, if you're going to collect it!
@arslogavitabrevis any update? |
#3064 to complete |
…tion#3070) * forward porting ros-navigation#3053 * adding TF warning suggestion (cherry picked from commit bb0d177) Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
* forward porting ros-navigation#3053 * adding TF warning suggestion
Range_sensor_layer
Basic Info
Description of contribution in a few bullet points
For Maintainers: