-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export BT util test files #3372
Merged
SteveMacenski
merged 7 commits into
ros-navigation:main
from
jwallace42:export_bt_test_files
Jan 18, 2023
Merged
Export BT util test files #3372
SteveMacenski
merged 7 commits into
ros-navigation:main
from
jwallace42:export_bt_test_files
Jan 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jwallace42, please properly fill in PR template in the future. @SteveMacenski, use this instead.
|
SteveMacenski
requested changes
Jan 17, 2023
SteveMacenski
approved these changes
Jan 18, 2023
Woof. Lots of linting issues this created. You need to update the header guards for 10 files from moving them around |
andrewlycas
pushed a commit
to StratomInc/navigation2
that referenced
this pull request
Feb 23, 2023
* export test files * removed space * move order * file header refactor * space * code review * lint fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
In order to have users write tests for bt nodes in order modules, the test utility files must be exported.
Description of documentation updates required from your changes
Future work that may be required in bullet points
For Maintainers: