Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aadding base footprint publisher to nav2_util #3995

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

SteveMacenski
Copy link
Member

Reverts #3994

To be merged once a new release of rolling adds geometry_msgs 0.34.0

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: Patch coverage is 89.74359% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 89.63%. Comparing base (677e6ac) to head (64a3614).

Files Patch % Lines
nav2_util/src/base_footprint_publisher.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3995      +/-   ##
==========================================
- Coverage   89.87%   89.63%   -0.24%     
==========================================
  Files         432      434       +2     
  Lines       19660    19699      +39     
==========================================
- Hits        17670    17658      -12     
- Misses       1990     2041      +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

mergify bot commented Dec 23, 2023

This pull request is in conflict. Could you fix it @SteveMacenski?

@SteveMacenski SteveMacenski merged commit 13e2005 into main Apr 23, 2024
11 of 13 checks passed
@SteveMacenski SteveMacenski deleted the revert-3994-revert-3860-footprint_publisher branch April 23, 2024 21:49
tonynajjar added a commit to angsa-robotics/navigation2 that referenced this pull request Apr 25, 2024
tonynajjar pushed a commit to angsa-robotics/navigation2 that referenced this pull request Apr 29, 2024
tonynajjar pushed a commit to angsa-robotics/navigation2 that referenced this pull request Apr 29, 2024
enricosutera pushed a commit to enricosutera/navigation2 that referenced this pull request May 19, 2024
Marc-Morcos pushed a commit to Marc-Morcos/navigation2 that referenced this pull request Jul 4, 2024
Marc-Morcos pushed a commit to Marc-Morcos/navigation2 that referenced this pull request Jul 4, 2024
Manos-G pushed a commit to Manos-G/navigation2 that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant