-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set start and goal as float #4255
Set start and goal as float #4255
Conversation
eb22ae2
to
6a233ed
Compare
@BriceRenaudeau, your PR has failed to build. Please check CI outputs and resolve issues. |
da0fb12
to
35442e0
Compare
CI failure not related. |
@BriceRenaudeau the first 2 failures seem related to this PR. I've never before seen those tests fail and they're targeting Smac |
Le planner returns: "Start occupied" on the verySmallPath tests. |
3486821
to
2518661
Compare
@BriceRenaudeau, your PR has failed to build. Please check CI outputs and resolve issues. |
Indeed - there are no failures of this kind before this PR. This must be causing it - CI still unhappy :( |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4255 +/- ##
==========================================
+ Coverage 89.75% 89.78% +0.03%
==========================================
Files 431 431
Lines 19574 19594 +20
==========================================
+ Hits 17568 17593 +25
+ Misses 2006 2001 -5 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Brice <brice.renaudeau@gmail.com>
Signed-off-by: Brice <brice.renaudeau@gmail.com>
Signed-off-by: Brice <brice.renaudeau@gmail.com>
Signed-off-by: Brice <brice.renaudeau@gmail.com>
Signed-off-by: Brice <brice.renaudeau@gmail.com>
366b68d
to
50f387f
Compare
Wonderful! |
* Set start and goal as float Signed-off-by: Brice <brice.renaudeau@gmail.com> * fix worldToMapContinuous type Signed-off-by: Brice <brice.renaudeau@gmail.com> * add static_cast<float> Signed-off-by: Brice <brice.renaudeau@gmail.com> * fix linting Signed-off-by: Brice <brice.renaudeau@gmail.com> * floor float to check start = goal Signed-off-by: Brice <brice.renaudeau@gmail.com> --------- Signed-off-by: Brice <brice.renaudeau@gmail.com>
* Set start and goal as float Signed-off-by: Brice <brice.renaudeau@gmail.com> * fix worldToMapContinuous type Signed-off-by: Brice <brice.renaudeau@gmail.com> * add static_cast<float> Signed-off-by: Brice <brice.renaudeau@gmail.com> * fix linting Signed-off-by: Brice <brice.renaudeau@gmail.com> * floor float to check start = goal Signed-off-by: Brice <brice.renaudeau@gmail.com> --------- Signed-off-by: Brice <brice.renaudeau@gmail.com>
* Set start and goal as float Signed-off-by: Brice <brice.renaudeau@gmail.com> * fix worldToMapContinuous type Signed-off-by: Brice <brice.renaudeau@gmail.com> * add static_cast<float> Signed-off-by: Brice <brice.renaudeau@gmail.com> * fix linting Signed-off-by: Brice <brice.renaudeau@gmail.com> * floor float to check start = goal Signed-off-by: Brice <brice.renaudeau@gmail.com> --------- Signed-off-by: Brice <brice.renaudeau@gmail.com> Signed-off-by: enricosutera <enricosutera@outlook.com>
* Set start and goal as float Signed-off-by: Brice <brice.renaudeau@gmail.com> * fix worldToMapContinuous type Signed-off-by: Brice <brice.renaudeau@gmail.com> * add static_cast<float> Signed-off-by: Brice <brice.renaudeau@gmail.com> * fix linting Signed-off-by: Brice <brice.renaudeau@gmail.com> * floor float to check start = goal Signed-off-by: Brice <brice.renaudeau@gmail.com> --------- Signed-off-by: Brice <brice.renaudeau@gmail.com>
* Set start and goal as float Signed-off-by: Brice <brice.renaudeau@gmail.com> * fix worldToMapContinuous type Signed-off-by: Brice <brice.renaudeau@gmail.com> * add static_cast<float> Signed-off-by: Brice <brice.renaudeau@gmail.com> * fix linting Signed-off-by: Brice <brice.renaudeau@gmail.com> * floor float to check start = goal Signed-off-by: Brice <brice.renaudeau@gmail.com> --------- Signed-off-by: Brice <brice.renaudeau@gmail.com>
* Set start and goal as float Signed-off-by: Brice <brice.renaudeau@gmail.com> * fix worldToMapContinuous type Signed-off-by: Brice <brice.renaudeau@gmail.com> * add static_cast<float> Signed-off-by: Brice <brice.renaudeau@gmail.com> * fix linting Signed-off-by: Brice <brice.renaudeau@gmail.com> * floor float to check start = goal Signed-off-by: Brice <brice.renaudeau@gmail.com> --------- Signed-off-by: Brice <brice.renaudeau@gmail.com>
worldToMapContinous
to compute the decimals for the world to map conversion.setGoal
to use floats as inputs andstatic_cast
to unsigned int's for thegetIndex
method.Basic Info
For Maintainers: