Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set start and goal as float #4255

Conversation

BriceRenaudeau
Copy link
Contributor

  • Create a worldToMapContinous to compute the decimals for the world to map conversion.
  • Change the setGoal to use floats as inputs and static_cast to unsigned int's for the getIndex method.
  • Do the same with setStart as well

Basic Info

Info Please fill out this column
Ticket(s) this addresses #3955 and #4249
Primary OS tested on Ubuntu
Robotic platform tested on sim
Does this PR contain AI generated software? No

For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@BriceRenaudeau BriceRenaudeau force-pushed the SMAC-planner]-Start-and-goal-are-moved-to-closest-cell branch from eb22ae2 to 6a233ed Compare April 10, 2024 13:31
Copy link
Contributor

mergify bot commented Apr 10, 2024

@BriceRenaudeau, your PR has failed to build. Please check CI outputs and resolve issues.
You may need to rebase or pull in main due to API changes (or your contribution genuinely fails).

@BriceRenaudeau BriceRenaudeau force-pushed the SMAC-planner]-Start-and-goal-are-moved-to-closest-cell branch from da0fb12 to 35442e0 Compare April 10, 2024 14:07
@BriceRenaudeau
Copy link
Contributor Author

CI failure not related.

@SteveMacenski SteveMacenski linked an issue Apr 10, 2024 that may be closed by this pull request
@SteveMacenski
Copy link
Member

@BriceRenaudeau the first 2 failures seem related to this PR. I've never before seen those tests fail and they're targeting Smac

@BriceRenaudeau
Copy link
Contributor Author

@BriceRenaudeau the first 2 failures seem related to this PR. I've never before seen those tests fail and they're targeting Smac

Le planner returns: "Start occupied" on the verySmallPath tests.

@BriceRenaudeau BriceRenaudeau force-pushed the SMAC-planner]-Start-and-goal-are-moved-to-closest-cell branch 2 times, most recently from 3486821 to 2518661 Compare April 11, 2024 14:31
Copy link
Contributor

mergify bot commented Apr 11, 2024

@BriceRenaudeau, your PR has failed to build. Please check CI outputs and resolve issues.
You may need to rebase or pull in main due to API changes (or your contribution genuinely fails).

@SteveMacenski
Copy link
Member

SteveMacenski commented Apr 11, 2024

Le planner returns: "Start occupied" on the verySmallPath tests.

Indeed - there are no failures of this kind before this PR. This must be causing it - CI still unhappy :(

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.78%. Comparing base (f815e8b) to head (50f387f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4255      +/-   ##
==========================================
+ Coverage   89.75%   89.78%   +0.03%     
==========================================
  Files         431      431              
  Lines       19574    19594      +20     
==========================================
+ Hits        17568    17593      +25     
+ Misses       2006     2001       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

BriceRenaudeau and others added 5 commits April 12, 2024 15:36
Signed-off-by: Brice <brice.renaudeau@gmail.com>
Signed-off-by: Brice <brice.renaudeau@gmail.com>
Signed-off-by: Brice <brice.renaudeau@gmail.com>
Signed-off-by: Brice <brice.renaudeau@gmail.com>
Signed-off-by: Brice <brice.renaudeau@gmail.com>
@BriceRenaudeau BriceRenaudeau force-pushed the SMAC-planner]-Start-and-goal-are-moved-to-closest-cell branch from 366b68d to 50f387f Compare April 12, 2024 13:36
@SteveMacenski SteveMacenski merged commit cc2b696 into ros-navigation:main Apr 12, 2024
13 checks passed
@SteveMacenski
Copy link
Member

Wonderful!

ajtudela pushed a commit to grupo-avispa/navigation2 that referenced this pull request Apr 19, 2024
* Set start and goal as float

Signed-off-by: Brice <brice.renaudeau@gmail.com>

* fix worldToMapContinuous type

Signed-off-by: Brice <brice.renaudeau@gmail.com>

* add static_cast<float>

Signed-off-by: Brice <brice.renaudeau@gmail.com>

* fix linting

Signed-off-by: Brice <brice.renaudeau@gmail.com>

* floor float to check start = goal

Signed-off-by: Brice <brice.renaudeau@gmail.com>

---------

Signed-off-by: Brice <brice.renaudeau@gmail.com>
tonynajjar pushed a commit to angsa-robotics/navigation2 that referenced this pull request Apr 26, 2024
* Set start and goal as float

Signed-off-by: Brice <brice.renaudeau@gmail.com>

* fix worldToMapContinuous type

Signed-off-by: Brice <brice.renaudeau@gmail.com>

* add static_cast<float>

Signed-off-by: Brice <brice.renaudeau@gmail.com>

* fix linting

Signed-off-by: Brice <brice.renaudeau@gmail.com>

* floor float to check start = goal

Signed-off-by: Brice <brice.renaudeau@gmail.com>

---------

Signed-off-by: Brice <brice.renaudeau@gmail.com>
enricosutera pushed a commit to enricosutera/navigation2 that referenced this pull request May 19, 2024
* Set start and goal as float

Signed-off-by: Brice <brice.renaudeau@gmail.com>

* fix worldToMapContinuous type

Signed-off-by: Brice <brice.renaudeau@gmail.com>

* add static_cast<float>

Signed-off-by: Brice <brice.renaudeau@gmail.com>

* fix linting

Signed-off-by: Brice <brice.renaudeau@gmail.com>

* floor float to check start = goal

Signed-off-by: Brice <brice.renaudeau@gmail.com>

---------

Signed-off-by: Brice <brice.renaudeau@gmail.com>
Signed-off-by: enricosutera <enricosutera@outlook.com>
Marc-Morcos pushed a commit to Marc-Morcos/navigation2 that referenced this pull request Jul 4, 2024
* Set start and goal as float

Signed-off-by: Brice <brice.renaudeau@gmail.com>

* fix worldToMapContinuous type

Signed-off-by: Brice <brice.renaudeau@gmail.com>

* add static_cast<float>

Signed-off-by: Brice <brice.renaudeau@gmail.com>

* fix linting

Signed-off-by: Brice <brice.renaudeau@gmail.com>

* floor float to check start = goal

Signed-off-by: Brice <brice.renaudeau@gmail.com>

---------

Signed-off-by: Brice <brice.renaudeau@gmail.com>
Manos-G pushed a commit to Manos-G/navigation2 that referenced this pull request Aug 1, 2024
* Set start and goal as float

Signed-off-by: Brice <brice.renaudeau@gmail.com>

* fix worldToMapContinuous type

Signed-off-by: Brice <brice.renaudeau@gmail.com>

* add static_cast<float>

Signed-off-by: Brice <brice.renaudeau@gmail.com>

* fix linting

Signed-off-by: Brice <brice.renaudeau@gmail.com>

* floor float to check start = goal

Signed-off-by: Brice <brice.renaudeau@gmail.com>

---------

Signed-off-by: Brice <brice.renaudeau@gmail.com>
masf7g pushed a commit to quasi-robotics/navigation2 that referenced this pull request Oct 22, 2024
* Set start and goal as float

Signed-off-by: Brice <brice.renaudeau@gmail.com>

* fix worldToMapContinuous type

Signed-off-by: Brice <brice.renaudeau@gmail.com>

* add static_cast<float>

Signed-off-by: Brice <brice.renaudeau@gmail.com>

* fix linting

Signed-off-by: Brice <brice.renaudeau@gmail.com>

* floor float to check start = goal

Signed-off-by: Brice <brice.renaudeau@gmail.com>

---------

Signed-off-by: Brice <brice.renaudeau@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SMAC planner] Start and goal are moved to closest cell
2 participants