Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rviz use sim time with TB3 demo #4274

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

tonynajjar
Copy link
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses (add tickets here #1)
Primary OS tested on Ubuntu
Robotic platform tested on (Steve's Robot, gazebo simulation of Tally, hardware turtlebot)
Does this PR contain AI generated software? (No; Yes and it is marked inline in the code)

Description of contribution in a few bullet points

  • Add use_sim_time argument to rviz launch file and use it from tb3 demo launch file

This is to fix the rviz plugins using the system time

Description of documentation updates required from your changes


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>
@SteveMacenski SteveMacenski merged commit 1f980a1 into ros-navigation:main Apr 24, 2024
9 of 11 checks passed
enricosutera pushed a commit to enricosutera/navigation2 that referenced this pull request May 19, 2024
Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>
Signed-off-by: enricosutera <enricosutera@outlook.com>
Marc-Morcos pushed a commit to Marc-Morcos/navigation2 that referenced this pull request Jul 4, 2024
Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>
savalena pushed a commit to savalena/navigation2 that referenced this pull request Jul 5, 2024
Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>
Manos-G pushed a commit to Manos-G/navigation2 that referenced this pull request Aug 1, 2024
Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants