Feedback requested - Initial design documents templates #1
Conversation
| @@ -0,0 +1,18 @@ | |||
| # Requirement Title | |||
| The <navigation system> should be able to <shall> <do something> | |||
There was a problem hiding this comment.
I think these angle brackets should be escaped. Markdown allows for some inline markup, so these are not being interpreted correctly by the renderer. They don't show up correctly in Visual Studio code, at least. Searching online, it seems you can use a single backslash before the opening angle bracket: \<navigation system>, for example, instead of <navigation system>.
design/README.md
Outdated
| @@ -0,0 +1,15 @@ | |||
| # ROS2 Navigation Design documenation | |||
| ## More details | ||
| - I want to be able to write or use my own collision avoidance algorithm without having to re-compile the entire stack from source | ||
| - Ideally I can just change out a node using a custom launch file | ||
| - This maps to the "Collision avoidance" use case |
There was a problem hiding this comment.
I'd suggest use case names be capitalized: "Collision avoidance" -> "Collision Avoidance"
design/README.md
Outdated
| @@ -0,0 +1,15 @@ | |||
| # ROS2 Navigation Design documenation | |||
| This is where the ROS2 Navigation design documentation is being collected and vetted | |||
There was a problem hiding this comment.
"ROS2 Navigation" here is inconsistent with the previous README.md, which uses "ROS2 navigation"
design/README.md
Outdated
| @@ -0,0 +1,15 @@ | |||
| # ROS2 Navigation Design documenation | |||
There was a problem hiding this comment.
Inconsistent capitalization. I'd say either "ROS2 Navigation design documentation" or "ROS2 Navigation Design Documentation" Should be consistent on titles.
| - Why is this needed? | ||
| - What is the expected user interaction? | ||
| - What use case does this map to? | ||
|
|
There was a problem hiding this comment.
I suggest we add: "Are there any non-functional requirements associated with this functional requirement?"
| @@ -0,0 +1,16 @@ | |||
| # Use case Title | |||
There was a problem hiding this comment.
Inconsistent capitalization: "Use Case Title" or "Use case title"
| @@ -0,0 +1,16 @@ | |||
| # Use case Title | |||
| As a <Developer, Researcher, Technician, etc.> I want the robot to <action> so that <I, the robot, etc.> can <do something important> | |||
There was a problem hiding this comment.
As before, we should escape these angle brackets.
| ## More details | ||
| - Why is this needed? | ||
| - What is the expected user interaction? | ||
|
|
There was a problem hiding this comment.
I suggest we add: "Are there any non-functional requirements associated with this use case?"
|
@mjeronimo - I made fixes & changes you suggested. Please review again. |
|
Thanks for the review help! |
|
You bet! Looking forward to getting input from the ROS community. |
…atch-1 Adding map server migration guide
* corrected the BT example to the current one * fixed xml code block formatting * completed first portion of custom_bt tutorial * added NavigateWithReplanning explaination * added recovery fallback tutorial * Apply suggestions from Steve's code review Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> * Added BT Custom Node Walk Through (ros-navigation#1) * adding reference to the getting started guide * fixed xml indentation * adding images, test to see how it renders * fixing XML, and BT rendering * adding overview of custom BT nodes * added pictures for pipeline sequence * fixed typos on image, and guide * added recovery node explaination * addding round robin explaination * getting rid of build folder and vscode folder * Editing, Added Explanation through Recovery subtree (ros-navigation#2) * Apply suggestions from code review Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> * Update Foxy.rst * Nav through poses2: Adding parameters (ros-navigation#158) * adding documentation for nav through poses PR * adding new params for nav through poses * attempt at moving custom Nav2 BT nodes to it's own section * attempt to fix the pipe rendering issue * changing references so that they are navigate to pose with replanning and recovery * putting new page in a folder in an attempt to get the BT XML page working * fix page link for config guide, play around to render bullets * brushing up in response to comments * fixing link so that they lead directly to the specific nodes * correcting minor typos and comments * moving to main behavior tree section * fixing typo in index so that TOC works * trying relative path in case that fixes the link to nav2_specific_nodes * still trying to link to overview/specific_nodes * ok hopefully this is the final time here, successful link * fixing images Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Initial design documentation templates and examples