Migrate TB3 to nav2 minimal turtlebot repository & add the TB4 bringup option for modern gazebo #4401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Suggestions for navigation2#3634
Signed-off-by: Addisu Z. Taddese <addisuzt@intrinsic.ai>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Co-authored-by: Addisu Z. Taddese <addisuzt@intrinsic.ai> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
|
This pull request is in conflict. Could you fix it @SteveMacenski? |
|
@SteveMacenski, your PR has failed to build. Please check CI outputs and resolve issues. |
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
|
@SteveMacenski, your PR has failed to build. Please check CI outputs and resolve issues. |
SteveMacenski
changed the title
Marc-Morcos
pushed a commit
to Marc-Morcos/navigation2
that referenced
this pull request
Jul 4, 2024
…p option for modern gazebo (ros-navigation#4401) * Initial support to the new Gazebo Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Added feedback Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Fixed build Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Added feeback Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Fixed physics tag Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Fixed physics tag Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Fix copyright and urdf Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * min range cannot be zero Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Simplify files Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Added feedback Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Added feedback Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Fix Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Try to reduce load Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Removed cast shadows Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Use Gazebo plugins instead of gz_ros2_control Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * update dependency Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Removed dependency Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Removed ros2_control and use ogre Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Use param file to configure bridge Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Use sdf model and change to ogre instead of ogre2 for sensors Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * Support Garden and later, performance improvements Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * Use xacro for world file (ros-navigation#2) Signed-off-by: Addisu Z. Taddese <addisuzt@intrinsic.ai> * Reviewer feedback Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * Add comment explaining temp file Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * Fix linter Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * Update nav2_bringup/worlds/gz_world_only.sdf.xacro Co-authored-by: Addisu Z. Taddese <addisuzt@intrinsic.ai> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * port GZ Classic launch changes to modern GZ and remove GZ Classic launch file * adding changes * changes done for TB4 * tb3 sim prototype * fix missing ref * linting * fix branch name * remove assets * removing refs to turtlebot3_gazebo * update map * add new depot map * Update Nav2 side of multirobot launch files * linting --------- Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> Signed-off-by: Addisu Z. Taddese <addisuzt@intrinsic.ai> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org> Co-authored-by: Addisu Z. Taddese <addisuzt@intrinsic.ai>
Marc-Morcos
pushed a commit
to Marc-Morcos/navigation2
that referenced
this pull request
Jul 4, 2024
…p option for modern gazebo (ros-navigation#4401) * Initial support to the new Gazebo Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Added feedback Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Fixed build Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Added feeback Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Fixed physics tag Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Fixed physics tag Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Fix copyright and urdf Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * min range cannot be zero Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Simplify files Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Added feedback Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Added feedback Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Fix Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Try to reduce load Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Removed cast shadows Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Use Gazebo plugins instead of gz_ros2_control Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * update dependency Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Removed dependency Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Removed ros2_control and use ogre Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Use param file to configure bridge Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Use sdf model and change to ogre instead of ogre2 for sensors Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * Support Garden and later, performance improvements Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * Use xacro for world file (ros-navigation#2) Signed-off-by: Addisu Z. Taddese <addisuzt@intrinsic.ai> * Reviewer feedback Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * Add comment explaining temp file Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * Fix linter Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * Update nav2_bringup/worlds/gz_world_only.sdf.xacro Co-authored-by: Addisu Z. Taddese <addisuzt@intrinsic.ai> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * port GZ Classic launch changes to modern GZ and remove GZ Classic launch file * adding changes * changes done for TB4 * tb3 sim prototype * fix missing ref * linting * fix branch name * remove assets * removing refs to turtlebot3_gazebo * update map * add new depot map * Update Nav2 side of multirobot launch files * linting --------- Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> Signed-off-by: Addisu Z. Taddese <addisuzt@intrinsic.ai> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org> Co-authored-by: Addisu Z. Taddese <addisuzt@intrinsic.ai>
savalena
pushed a commit
to savalena/navigation2
that referenced
this pull request
Jul 5, 2024
…p option for modern gazebo (ros-navigation#4401) * Initial support to the new Gazebo Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Added feedback Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Fixed build Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Added feeback Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Fixed physics tag Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Fixed physics tag Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Fix copyright and urdf Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * min range cannot be zero Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Simplify files Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Added feedback Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Added feedback Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Fix Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Try to reduce load Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Removed cast shadows Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Use Gazebo plugins instead of gz_ros2_control Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * update dependency Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Removed dependency Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Removed ros2_control and use ogre Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Use param file to configure bridge Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Use sdf model and change to ogre instead of ogre2 for sensors Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * Support Garden and later, performance improvements Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * Use xacro for world file (ros-navigation#2) Signed-off-by: Addisu Z. Taddese <addisuzt@intrinsic.ai> * Reviewer feedback Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * Add comment explaining temp file Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * Fix linter Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * Update nav2_bringup/worlds/gz_world_only.sdf.xacro Co-authored-by: Addisu Z. Taddese <addisuzt@intrinsic.ai> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * port GZ Classic launch changes to modern GZ and remove GZ Classic launch file * adding changes * changes done for TB4 * tb3 sim prototype * fix missing ref * linting * fix branch name * remove assets * removing refs to turtlebot3_gazebo * update map * add new depot map * Update Nav2 side of multirobot launch files * linting --------- Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> Signed-off-by: Addisu Z. Taddese <addisuzt@intrinsic.ai> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org> Co-authored-by: Addisu Z. Taddese <addisuzt@intrinsic.ai>
Manos-G
pushed a commit
to Manos-G/navigation2
that referenced
this pull request
Aug 1, 2024
…p option for modern gazebo (ros-navigation#4401) * Initial support to the new Gazebo Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Added feedback Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Fixed build Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Added feeback Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Fixed physics tag Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Fixed physics tag Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Fix copyright and urdf Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * min range cannot be zero Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Simplify files Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Added feedback Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Added feedback Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Fix Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Try to reduce load Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Removed cast shadows Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Use Gazebo plugins instead of gz_ros2_control Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * update dependency Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Removed dependency Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Removed ros2_control and use ogre Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Use param file to configure bridge Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Use sdf model and change to ogre instead of ogre2 for sensors Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * Support Garden and later, performance improvements Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * Use xacro for world file (ros-navigation#2) Signed-off-by: Addisu Z. Taddese <addisuzt@intrinsic.ai> * Reviewer feedback Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * Add comment explaining temp file Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * Fix linter Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * Update nav2_bringup/worlds/gz_world_only.sdf.xacro Co-authored-by: Addisu Z. Taddese <addisuzt@intrinsic.ai> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * port GZ Classic launch changes to modern GZ and remove GZ Classic launch file * adding changes * changes done for TB4 * tb3 sim prototype * fix missing ref * linting * fix branch name * remove assets * removing refs to turtlebot3_gazebo * update map * add new depot map * Update Nav2 side of multirobot launch files * linting --------- Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> Signed-off-by: Addisu Z. Taddese <addisuzt@intrinsic.ai> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org> Co-authored-by: Addisu Z. Taddese <addisuzt@intrinsic.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leverages: https://github.com/ros-navigation/nav2_minimal_turtlebot_simulation/tree/main