Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mutex to reloadDbCb to fail if called during docking #4574

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Add mutex to reloadDbCb to fail if called during docking #4574

merged 1 commit into from
Jul 29, 2024

Conversation

redvinaa
Copy link
Contributor

@redvinaa
Add mutex to reloadDbCb to fail if called during docking
00047d2 
Signed-off-by: redvinaa <redvinaa@gmail.com>
@codecov Codecov
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Files Coverage Δ
...docking/include/opennav_docking/docking_server.hpp 100.00% <ø> (ø)
...av2_docking/opennav_docking/src/docking_server.cpp 89.73% <100.00%> (-0.06%) ⬇️
nav2_docking/opennav_docking/src/dock_database.cpp 90.00% <66.66%> (-2.11%) ⬇️

... and 4 files with indirect coverage changes

@SteveMacenski SteveMacenski merged commit 57415d6 into ros-navigation:main Jul 29, 2024
10 of 11 checks passed
mergify bot pushed a commit that referenced this pull request Jul 29, 2024
@redvinaa @mergify
Add mutex to reloadDbCb to fail if called during docking (#4574)
f54aa50 
Signed-off-by: redvinaa <redvinaa@gmail.com>
(cherry picked from commit 57415d6)
@mergify mergify bot mentioned this pull request Jul 29, 2024
Merged
SteveMacenski pushed a commit that referenced this pull request Jul 29, 2024
@mergify @redvinaa
Add mutex to reloadDbCb to fail if called during docking (#4574) (#4576)
4dd1be9 
Signed-off-by: redvinaa <redvinaa@gmail.com>
(cherry picked from commit 57415d6)

Co-authored-by: Vince Reda <60265874+redvinaa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveMacenski SteveMacenski SteveMacenski approved these changes

Assignees
No one assigned
Labels
backport-jazzy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@redvinaa @SteveMacenski