Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix latest failing tests in CI #597

Merged
1 commit merged into from
Mar 7, 2019
Merged

Fix latest failing tests in CI #597

1 commit merged into from
Mar 7, 2019

Conversation

ghost
Copy link

@ghost ghost commented Mar 7, 2019

Basic Info

Info Please fill out this column
Ticket(s) this addresses NA
Primary OS tested on Ubuntu 18.04
Robotic platform tested on NA

Description of contribution in a few bullet points

  • A bunch of tests were failing CI as can be seen in this build log
  • This started happening due to a change in the launch_testing package.
  • Seems we were using the package wrong and the change exposed that problem as described in add_test_action no longer triggers shutdown on completion ros2/launch#194
  • This change removes a duplicate addition of the test action from the launch description.

@ghost ghost requested review from orduno and mhpanah March 7, 2019 18:01
mhpanah
mhpanah approved these changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@mhpanah mhpanah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ghost ghost merged commit a396dc5 into ros-navigation:master Mar 7, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orduno @mhpanah