Use Boost::python3 if Boost < 1.67 #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
mjcarroll
approved these changes
Jan 24, 2022
ijnek
added a commit
that referenced
this pull request
Sep 17, 2022
This reverts commit f54a269. Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
Ace314159
added a commit
to Ace314159/vision_opencv
that referenced
this pull request
Sep 18, 2022
…"" This reverts commit 822069c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a mistake in #421 - when boost is less than 1.67 use the
Boost::python3target instead of theBoost::pythonXYtarget.This time in addition to testing this PR by building and testing
cv_bridgeon Focal locally, I also ran this CMake code in a stub project on almalinux 8 to make sure it works with boost 1.66