Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable StaticTransformBroadcaster in Intra-process enabled components #607

Merged
merged 4 commits into from
Jun 22, 2023
Merged

Enable StaticTransformBroadcaster in Intra-process enabled components #607

merged 4 commits into from
Jun 22, 2023

Conversation

roncapat
Copy link
Contributor

@roncapat roncapat commented Jun 13, 2023 •
edited
Loading

Follow up of this comment made by @FranzAlbers (and PR #572 in general).

FYI @nachovizzo(PRBonn/kiss-icp#171) and @Fixit-Davide.

clalancette
clalancette requested changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small changes, then I'll run CI on it.

tf2_ros/include/tf2_ros/static_transform_broadcaster.h Outdated Show resolved Hide resolved
tf2_ros/include/tf2_ros/static_transform_broadcaster.h Outdated Show resolved Hide resolved
@roncapat
Copy link
Contributor Author

I also added a small test as I did for the TransformListener :)

clalancette
clalancette approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the addition of the test!

@roncapat
Copy link
Contributor Author

roncapat commented Jun 22, 2023 •
edited
Loading

@clalancette wait wait, I missed some fixes to the comments
sorry!

EDIT: done, just need to see if uncrustify is happy with different newlines in the comment blocks. Sorry again for that :)

@clalancette
Copy link
Contributor

clalancette commented Jun 22, 2023 •
edited
Loading

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette merged commit edad1bc into ros2:rolling Jun 22, 2023
@roncapat
Copy link
Contributor Author

Thanks a lot! Can we backport to iron and humble?

@ahcorde
Copy link
Contributor

ahcorde commented Jun 23, 2023

https://github.com/Mergifyio backport iron humble

@mergify
Copy link
Contributor

mergify bot commented Jun 23, 2023 •
edited
Loading

backport iron humble

✅ Backports have been created

This was referenced Jun 23, 2023
Merged
Merged
mergify bot pushed a commit that referenced this pull request Jun 23, 2023
@roncapat @mergify
Enable StaticTransformBroadcaster in Intra-process enabled components (…
dc9a2a2 
…#607)

* Update static_transform_broadcaster.h

(cherry picked from commit edad1bc)
mergify bot pushed a commit that referenced this pull request Jun 23, 2023
@roncapat @mergify
Enable StaticTransformBroadcaster in Intra-process enabled components (…
7721b88 
…#607)

* Update static_transform_broadcaster.h

(cherry picked from commit edad1bc)

# Conflicts:
#	tf2_ros/include/tf2_ros/static_transform_broadcaster.h
ahcorde pushed a commit that referenced this pull request Jun 30, 2023
@mergify @roncapat
Enable StaticTransformBroadcaster in Intra-process enabled components (…
4320dfd 
…#607) (#611)

* Update static_transform_broadcaster.h

(cherry picked from commit edad1bc)

Co-authored-by: Patrick Roncagliolo <ronca.pat@gmail.com>
clalancette pushed a commit that referenced this pull request Jul 10, 2023
@mergify @roncapat
Enable StaticTransformBroadcaster in Intra-process enabled components…
936a352 
… (backport #607) (#612)

* Enable StaticTransformBroadcaster in Intra-process enabled components (#607)

* Update static_transform_broadcaster.h

(cherry picked from commit edad1bc)

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Co-authored-by: Patrick Roncagliolo <ronca.pat@gmail.com>
This was referenced Sep 21, 2023
Merged
Closed
roncapat added a commit to roncapat/geometry2 that referenced this pull request Jan 22, 2024
@roncapat
Revert "Enable StaticTransformBroadcaster in Intra-process enabled co…
af5f462 
…mponents (ros2#607)"

This reverts commit edad1bc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@ahcorde ahcorde Awaiting requested review from ahcorde ahcorde is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roncapat @clalancette @ahcorde